Skip to content

WIP: name-test followup

Simon McVittie requested to merge smcv/dbus:name-test-followup into master

After cherry-picking commit d9de6ab2 "Add build system variable DBUS_NAME_TEST_EXEC to cover differences in executable paths" I noticed that it was using a build-time path in the installed test data, whereas it should have been using an installed path (we don't actually install test-privserver yet anyway, but if we did, it would be in a name-test subdirectory of $(testexecdir)).

I also noticed that we aren't setting DBUS_NAME_TEST_EXEC everywhere we set DBUS_TEST_EXEC.

Reviewers: I've marked this as WIP because I have an alternative that I'm also going to try (!67 (merged)): moving test-privserver into test/, so that all helper executables are in test/ and the need to distinguish between DBUS_TEST_EXEC and DBUS_NAME_TEST_EXEC vanishes. I think I prefer !67 (merged), so don't bother reviewing this unless !67 (merged) has some serious problem that I didn't spot.

Edited by Simon McVittie

Merge request reports