Skip to content

WIP: autotools: Remove redundant Solaris extensions

Simon McVittie requested to merge smcv/dbus:redundant-solaris-extensions into master

@alanc pointed out on !11 (merged) that AC_USE_SYSTEM_EXTENSIONS already defines _POSIX_PTHREAD_SEMANTICS, and (if it doesn't break compilation) __EXTENSIONS__.

I have not tested this on Solaris. @alanc, would you be able to do that?

We still don't define either of these macros in the CMake build system, but that isn't a regression, because we never did that before.

I am suspicious that the second commit (for __EXTENSIONS__) might not be right; __EXTENSIONS__ was added for https://bugs.freedesktop.org/show_bug.cgi?id=53286, but that was long after Lennart added AC_USE_SYSTEM_EXTENSIONS in 2009, so I would have expected the patch in fd.o 53286 to have been unnecessary. I'm not sure what's going on there. Perhaps the conservative approach would be to skip the second patch and only apply the first?

Merge request reports