generate run-with-tmp-session-bus.conf in a way that CMake can deal with
Submitted by Simon McVittie
Assigned to D-Bus Maintainers
Description
I've reverted the commits 4f404b56 and 5071f3e87aaf225e56ce1a684d8325431b499f92 from master ("made session service dirs customizable") because:
-
they make the tests fail under Unix with Autotools (by far the most prominent way to build D-Bus) - I think I see what you were trying to do, but the variable assignment in Makefile.am isn't needed for that, and a use of AC_SUBST is needed
-
they weren't reviewed, or (as far as I could see while catching up after Christmas) discussed
-
they don't reference a bug report or explain the reasoning, so I can't see why these changes were made
I think I can see what the goal was - generating run-with-tmp-session-bus.conf from the build system, rather than from the shell script that runs the tests - and I agree that it's nice to use the same source file for session.conf and run-with-tmp-session-bus.conf, but please do not commit changes without at least one of testing or thorough review, and preferably both.
Version: 1.5