1. 04 Jan, 2012 1 commit
    • Simon McVittie's avatar
      Revert all changes since a36d4918 · 5df8c3db
      Simon McVittie authored
      Someone seems to have merged part of master into 1.4. Again. Let's go
      back to the "last known good" point (the branch-point of some 1.4
      branches I had locally), then we can cherry-pick the changes that
      should have gone in.
      5df8c3db
  2. 14 Mar, 2011 1 commit
  3. 10 Mar, 2011 1 commit
  4. 04 Mar, 2011 1 commit
  5. 20 Dec, 2010 1 commit
  6. 23 Nov, 2010 1 commit
  7. 19 Mar, 2010 1 commit
  8. 14 Jul, 2009 1 commit
  9. 10 Jul, 2009 1 commit
  10. 19 May, 2009 1 commit
  11. 06 May, 2009 2 commits
  12. 21 Apr, 2009 1 commit
  13. 17 Apr, 2009 1 commit
    • Colin Walters's avatar
      Bug 17803 - Fix both test case and validation logic · e8f8c1c5
      Colin Walters authored
      The previous commit had errors in both the test case and
      the validation logic.  The test case was missing a trailing
      comma before the previous one, so we weren't testing the
      signature we thought we were.
      
      The validation logic was wrong because if the type was not valid,
      we'd drop through the entire if clause, and thus skip returning
      an error code, and accept the signature.
      e8f8c1c5
  14. 06 Jan, 2009 1 commit
  15. 11 Nov, 2008 1 commit
  16. 01 Oct, 2008 2 commits
  17. 11 Oct, 2007 1 commit
  18. 14 Jul, 2007 1 commit
  19. 03 Aug, 2006 1 commit
  20. 17 Jul, 2006 1 commit
    • John Palmieri's avatar
      * doc/TODO: · b459906a
      John Palmieri authored
      * dbus/dbus-bus.c:
      * dbus-errors.c:
      * dbus/dbus-marshal-validate.c:
        Removed TODO items which were fixed or are no longer relevent
      b459906a
  21. 12 Sep, 2005 1 commit
  22. 15 Jun, 2005 1 commit
    • John Palmieri's avatar
      * dbus/dbus-marshal-validate.h: Added a new validation · 5e389fdf
      John Palmieri authored
              error code DBUS_VALIDITY_UNKNOWN_OOM_ERROR = -4 for
              out of memory errors when validating signitures
      
              * dbus/dbus-marshal-header.c: use DBUS_VALIDITY_UNKNOWN_OOM_ERROR
              in places where we previously used DBUS_VALID and a FALSE return
              value to indicate OOM
      
              * dbus/dbus-marshal-validate.c (_dbus_validate_signature_with_reason):
              Use a stack to track the number of elements inside containers.  The
              stack values are then used to validate that dict entries have only two
              elements within them.
              (validate_body_helper): check the reason for failure when validating
              varients
      
              * dbus/dbus-message.c (load_message): use
              DBUS_VALIDITY_UNKNOWN_OOM_ERROR in places where we previously used
              DBUS_VALID and a FALSE return value to indicate OOM
      
              * doc/TODO: remove "- validate dict entry number of fields" as this
              patch fixes it
      5e389fdf
  23. 24 Feb, 2005 1 commit
    • Colin Walters's avatar
      2005-02-24 Colin Walters <walters@verbum.org> · 54a2e9f7
      Colin Walters authored
      	* dbus/dbus-signature.c: New file; implements various functions
      	related to type signatures.  Includes an interator for parsing,
      	validation functions.
      	(dbus_type_is_basic): Moved here from
      	dbus-marshal-basic.c:_dbus_type_is_basic.
      	(dbus_type_is_container): Moved here from
      	dbus-marshal-basic.c:_dbus_type_is_container.
      
      	All callers of _dbus_type_is_container and _dbus_type_is_basic
      	updated, and include dbus-signature.h.
      
      	* dbus/dbus-signature.h: New file; prototypes for the above.
      
      	* dbus/Makefile.am (DBUS_LIB_SOURCES): Add dbus-signature.c,
      	dbus-signature.h.
      
      	* dbus/dbus-marshal-basic.c (map_type_char_to_type): New utility
      	function factored out of _dbus_first_type_in_signature.
      	(_dbus_first_type_in_signature_c_str): New function; returns first
      	type code for a type signature character.
      
      	* dbus/dbus-marshal-basic.h: Prototype _dbus_first_type_in_signature_c_str,
      	handle function moves.
      
      	* dbus/dbus-marshal-recursive.h: Export _dbus_type_signature_next.
      
      	* dbus/dbus-marshal-recursive.c (_dbus_type_signature_next): New
      	function; skips to next complete type in type signature.
      	Implemented using previous skip_one_complete_type.  Now
      	skip_one_complete_type just delegates to
      	_dbus_type_signature_next.
      
      	* dbus/dbus-marshal-basic.c (_dbus_type_is_basic): Moved
      	to dbus-signature.c
      	(_dbus_type_is_container): Ditto.
      
      	* doc/dbus-specification.xml: Update introspection sample to
      	use real type signatures.
      
      	* dbus/dbus-test.h: Prototype signature test.
      
      	* dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Run
      	signature tests.
      
      	* dbus/dbus-protocol.h (DBUS_ERROR_INVALID_SIGNATURE): New error.
      54a2e9f7
  24. 11 Feb, 2005 1 commit
    • Havoc Pennington's avatar
      2005-02-10 Havoc Pennington <hp@redhat.com> · 71f3b461
      Havoc Pennington authored
      	* dbus/dbus-message-factory.c (generate_special): modify test to
      	avoid using a non-basic dict key
      
      	* dbus/dbus-marshal-validate-util.c: add test for the below
      
      	* doc/dbus-specification.xml: require that dict keys are a basic
      	type
      
      	* dbus/dbus-marshal-validate.c
      	(_dbus_validate_signature_with_reason): require that dict key is a
      	basic type
      71f3b461
  25. 06 Feb, 2005 2 commits
    • Havoc Pennington's avatar
      2005-02-06 Havoc Pennington <hp@redhat.com> · 96a47516
      Havoc Pennington authored
      	* dbus/dbus-message-factory.c (generate_special): more tests
      
      	* dbus/dbus-marshal-validate.c (validate_body_helper): detect
      	array length that exceeds the maximum
      96a47516
    • Havoc Pennington's avatar
      2005-02-05 Havoc Pennington <hp@redhat.com> · 8f04e1e0
      Havoc Pennington authored
      	* dbus/dbus-message-factory.c (generate_special): more test cases,
      	increasing coverage
      
      	* dbus/dbus-marshal-validate.c (validate_body_helper): return the
      	reason why a signature was invalid
      
      	* dbus/dbus-marshal-header.c (load_and_validate_field): fix to
      	skip the length of the string before we look at it in validation
      
      	* dbus/dbus-string-util.c (_dbus_string_test): add tests for
      	equal_substring
      
      	* dbus/dbus-message.c (_dbus_message_loader_new): default
      	max_message_length to DBUS_MAXIMUM_MESSAGE_LENGTH
      8f04e1e0
  26. 05 Feb, 2005 1 commit
    • Havoc Pennington's avatar
      2005-02-05 Havoc Pennington <hp@redhat.com> · 0e53d4ee
      Havoc Pennington authored
      	* dbus/dbus-marshal-validate.c (validate_body_helper): fix crash
      	if the signature of a variant was empty
      	(_dbus_validate_signature_with_reason): catch "(a)" (array inside
      	struct with no element type)
      
      	* dbus/dbus-message-factory.c (generate_uint32_changed): add more
      	mangled messages to break things
      0e53d4ee
  27. 30 Jan, 2005 2 commits
    • Havoc Pennington's avatar
      2005-01-30 Havoc Pennington <hp@redhat.com> · 98ad8a8e
      Havoc Pennington authored
      	* glib/dbus-gobject.c (introspect_properties): fix the XML
      	generated
      
      	* dbus/dbus-message.c (dbus_message_unref): add an in_cache flag
      	which effectively detects the use of freed messages
      
      	* glib/dbus-gobject.c (handle_introspect): modify and return the
      	reply message instead of the incoming message
      
      	* dbus/dbus-object-tree.c (handle_default_introspect_unlocked):
      	gee, maybe it should SEND THE XML instead of just making a string
      	and freeing it again ;-)
      
      	* tools/dbus-print-message.c (print_message): improve printing of
      	messages
      
      	* configure.in: add debug-glib.service to the output
      98ad8a8e
    • Havoc Pennington's avatar
      2005-01-30 Havoc Pennington <hp@redhat.com> · 41f52c96
      Havoc Pennington authored
              dbus-viewer introspected and displayed the bus driver
      
      	* dbus/dbus-object-tree.c
      	(object_tree_test_iteration): add tests for a handler registered on "/"
      
      	* dbus/dbus-object-tree.c
      	(_dbus_decompose_path): fix to handle path "/" properly
      	(run_decompose_tests): add tests for path decomposition
      
      	* glib/dbus-gutils.c (_dbus_gutils_split_path): fix to handle "/"
      	properly
      
      	* glib/dbus-gobject.c (handle_introspect): fix quotes
      
      	* test/glib/run-test.sh: support launching the bus, then running
      	dbus-viewer
      
      	* test/glib/test-service-glib.c (main): put in a trivial gobject
      	subclass and register it on the connection
      
      	* bus/driver.c (bus_driver_handle_introspect): implement
      	introspection of the bus driver service
      
      	* dbus/dbus-protocol.h: add #defines for the XML namespace,
      	identifiers, doctype decl
      
      	* bus/driver.c (bus_driver_handle_get_service_owner): handle
      	attempts to get owner of DBUS_SERVICE_ORG_FREEDESKTOP_DBUS by
      	returning the service unchanged.
      	(bus_driver_handle_message): remove old check for reply_serial in
      	method calls, now the message type deals with that
      	(bus_driver_handle_message): handle NULL interface
      
      	* glib/dbus-gproxy.c (dbus_g_proxy_get_bus_name): new function
      
      	* glib/dbus-gloader-expat.c (description_load_from_string): allow
      	-1 for len
      
      	* tools/dbus-viewer.c: add support for introspecting a service on
      	a bus
      
      	* glib/dbus-gproxy.c (dbus_g_pending_call_ref): add
      	(dbus_g_pending_call_unref): add
      41f52c96
  28. 28 Jan, 2005 2 commits
    • Havoc Pennington's avatar
      2005-01-28 Havoc Pennington <hp@redhat.com> · c7816d45
      Havoc Pennington authored
      	* doc/dbus-specification.xml: update to describe 16-bit types and
      	dict entries
      
      	* dbus/dbus-marshal-basic.c (_dbus_unpack_uint16): fix broken
      	assertion
      
      	* dbus/dbus-protocol.h (DBUS_TYPE_DICT_ENTRY): add DICT_ENTRY as a
      	type
      
      	* dbus/dbus-marshal-recursive.c: implement
      c7816d45
    • Havoc Pennington's avatar
      2005-01-27 Havoc Pennington <hp@redhat.com> · 3ed9db54
      Havoc Pennington authored
      	* dbus/dbus-arch-deps.h.in: add 16/32-bit types
      
      	* configure.in: find the right type for 16 and 32 bit ints as well
      	as 64
      
      	* dbus/dbus-protocol.h (DBUS_TYPE_INT16, DBUS_TYPE_UINT16): add
      	the 16-bit types so people don't have to stuff them in 32-bit or
      	byte arrays.
      3ed9db54
  29. 27 Jan, 2005 2 commits
  30. 24 Jan, 2005 1 commit
  31. 18 Jan, 2005 2 commits
    • Havoc Pennington's avatar
      2005-01-18 Havoc Pennington <hp@redhat.com> · 8873c90f
      Havoc Pennington authored
              * Throughout, grand renaming to strip out the use of "service",
      	just say "name" instead (or "bus name" when ambiguous).  Did not
      	change the internal code of the message bus itself, only the
      	programmer-facing API and messages.
      
      	* doc/dbus-specification.xml: further update the message bus section
      
      	* bus/config-parser.c (all_are_equiv): fix bug using freed string
      	in error case
      8873c90f
    • Havoc Pennington's avatar
      2005-01-17 Havoc Pennington <hp@redhat.com> · 4fce2850
      Havoc Pennington authored
      	* dbus/dbus-types.h: remove 16-bit types since we don't use them
      	ever
      
      	* dbus/dbus-marshal-validate.c (_dbus_validate_path): disallow any
      	"invalid name character" not only non-ASCII
      
      	* doc/dbus-specification.xml: further update spec, message bus
      	parts are still out-of-date but the marshaling etc. stuff is now
      	accurate-ish
      4fce2850
  32. 17 Jan, 2005 2 commits
    • Havoc Pennington's avatar
      2005-01-17 Havoc Pennington <hp@redhat.com> · ad937e16
      Havoc Pennington authored
              * Throughout, align variant bodies according to the contained
      	type, rather than always to 8. Should save a fair bit of space in
      	message headers.
      
      	* dbus/dbus-marshal-validate.c (_dbus_validate_body_with_reason):
      	fix handling of case where p == end
      
      	* doc/TODO: remove the dbus_bool_t item and variant alignment items
      ad937e16
    • Havoc Pennington's avatar
      2005-01-17 Havoc Pennington <hp@redhat.com> · 62e46533
      Havoc Pennington authored
      	* dbus/dbus-types.h: hardcode dbus_bool_t to 32 bits
      
      	* Throughout: modify DBUS_TYPE_BOOLEAN to be a 32-bit type instead
      	of an 8-bit type. Now dbus_bool_t is the type to use whenever you
      	are marshaling/unmarshaling a boolean.
      62e46533