1. 16 Apr, 2015 4 commits
  2. 20 Feb, 2015 3 commits
  3. 27 Jan, 2015 1 commit
  4. 29 Oct, 2014 1 commit
  5. 06 Jan, 2014 1 commit
  6. 08 Oct, 2013 1 commit
  7. 13 Sep, 2013 2 commits
  8. 05 Sep, 2013 2 commits
  9. 03 Sep, 2013 1 commit
    • Simon McVittie's avatar
      Tests: allow dbus-glib to be replaced with use of libdbus-internal · 30e7a813
      Simon McVittie authored
      We only use dbus-glib for its main loop; within dbus, DBusLoop is
      available as an alternative, although it isn't thread-safe and
      isn't public API.
      
      For tests that otherwise only use libdbus public API, it's desirable to
      be able to avoid DBusLoop, so we can run them against an installed
      libdbus as an integration test. However, if we don't have dbus-glib,
      we're going to have to use an in-tree main loop, which might as well
      be DBusLoop.
      
      The major disadvantage of using dbus-glib is that it isn't safe to
      link both dbus-1 and dbus-internal at the same time. This is awkward
      for a future test case that wants to use _dbus_getsid() in dbus-daemon.c,
      but only on Windows (fd.o #54445). If we use the same API wrapper around
      both dbus-glib and DBusLoop, we can compile that test against dbus-glib
      or against DBusLoop, depending on the platform.
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68852Reviewed-by: Ralf Habacker's avatarRalf Habacker <ralf.habacker@freenet.de>
      30e7a813
  10. 23 Aug, 2013 1 commit
  11. 28 Jun, 2013 1 commit
  12. 17 Jun, 2013 1 commit
  13. 22 Feb, 2013 1 commit
  14. 12 Apr, 2012 2 commits
    • David Zeuthen's avatar
      Avoid using monotonic time in the DBUS_COOKIE_SHA1 authentication method · 87035143
      David Zeuthen authored
      When libdbus-1 moved to using monotonic time support for the
      DBUS_COOKIE_SHA1 authentication was broken, in particular
      interoperability with non-libdbus-1 implementations such as GDBus.
      
      The problem is that if monotonic clocks are available in the OS,
      _dbus_get_current_time() will not return the number of seconds since
      the Epoch so using it for DBUS_COOKIE_SHA1 will violate the D-Bus
      specification. If both peers are using libdbus-1 it's not a problem
      since both ends will use the wrong time and thus agree. However, if
      the other end is another implementation and following the spec it will
      not work.
      
      First, we change _dbus_get_current_time() back so it always returns
      time since the Epoch and we then rename it _dbus_get_real_time() to
      make this clear. We then introduce _dbus_get_monotonic_time() and
      carefully make all current users of _dbus_get_current_time() use it,
      if applicable. During this audit, one of the callers,
      _dbus_generate_uuid(), was currently using monotonic time but it was
      decided to make it use real time instead.
      Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      Reviewed-by: default avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=48580
      87035143
    • David Zeuthen's avatar
      Avoid using monotonic time in the DBUS_COOKIE_SHA1 authentication method · 8734e4a1
      David Zeuthen authored
      When libdbus-1 moved to using monotonic time support for the
      DBUS_COOKIE_SHA1 authentication was broken, in particular
      interoperability with non-libdbus-1 implementations such as GDBus.
      
      The problem is that if monotonic clocks are available in the OS,
      _dbus_get_current_time() will not return the number of seconds since
      the Epoch so using it for DBUS_COOKIE_SHA1 will violate the D-Bus
      specification. If both peers are using libdbus-1 it's not a problem
      since both ends will use the wrong time and thus agree. However, if
      the other end is another implementation and following the spec it will
      not work.
      
      First, we change _dbus_get_current_time() back so it always returns
      time since the Epoch and we then rename it _dbus_get_real_time() to
      make this clear. We then introduce _dbus_get_monotonic_time() and
      carefully make all current users of _dbus_get_current_time() use it,
      if applicable. During this audit, one of the callers,
      _dbus_generate_uuid(), was currently using monotonic time but it was
      decided to make it use real time instead.
      Signed-off-by: default avatarDavid Zeuthen <davidz@redhat.com>
      Reviewed-by: default avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=48580
      8734e4a1
  15. 04 Jan, 2012 1 commit
    • Simon McVittie's avatar
      Revert all changes since a36d4918 · 5df8c3db
      Simon McVittie authored
      Someone seems to have merged part of master into 1.4. Again. Let's go
      back to the "last known good" point (the branch-point of some 1.4
      branches I had locally), then we can cherry-pick the changes that
      should have gone in.
      5df8c3db
  16. 21 Sep, 2011 1 commit
  17. 05 Aug, 2011 1 commit
  18. 29 Jul, 2011 9 commits
  19. 25 May, 2011 2 commits
  20. 25 Jan, 2011 1 commit
  21. 21 Jan, 2011 1 commit
    • Simon McVittie's avatar
      test-privserver-client: wait for server to die between iterations · 4fa3a89d
      Simon McVittie authored
      This fixes a race condition: the server exits while the client continues
      to the next iteration. If the server wins, the test passes. If the client
      wins, it sends a message to the dying service, never gets a reply, and the
      test fails.
      
      My branch to refactor the main loop for fd.o #23194 seems to make the
      client more likely to win this race, resulting in intermittent test
      failures.
      
      This is an instance of the general problem described by fd.o #11454.
      4fa3a89d
  22. 06 Jan, 2011 1 commit
  23. 15 Dec, 2010 1 commit
    • Will Thompson's avatar
      Revert "test-autolaunch is only known to work in launchd environments." · c3a94b57
      Will Thompson authored
      This reverts commit 4626b405.
      test-autolaunch works fine in non-launchd environments (and non-X11
      environments, based on a quick test passing enable_x11=no to configure).
      On the contrary: this commit *broke* the build on non-launchd
      environments, because test/name-test/run-test.sh still tried to run this
      test even if it hadn't been built.
      c3a94b57