1. 16 May, 2016 1 commit
  2. 13 May, 2016 1 commit
  3. 10 May, 2013 1 commit
  4. 09 May, 2013 1 commit
  5. 21 Feb, 2012 2 commits
    • Simon McVittie's avatar
    • Simon McVittie's avatar
      Never use non-libdbus threading primitives · 8d2b3131
      Simon McVittie authored
      This lets us simplify considerably, by assuming that we always have both
      recursive and suitable-for-condition-variable mutexes.
      The Windows implementation has been compiled (on 32-bit mingw-w64)
      but not tested. Justification for the approach used on Windows,
      and in particular, using the existing "non-recursive" locks as if
      they were recursive:
      * We've been using them in conjunction with condition variables all
        along, so they'd better be suitable
      * On fd.o #36204, Ralf points out that mutexes created via CreateMutex
        are, in fact, recursive
      * Havoc's admonitions about requiring "Java-style" recursive locking
        (waiting for a condition variable while holding a recursive lock
        requires releasing that lock n times) turn out not to apply to
        either of our uses of DBusCondVar in DBusConnection, because the
        lock is only held for a short time, without calling into user code;
        indeed, our Unix implementation isn't recursive anyway, so if
        the Windows implementation reaches the deadlocking situation
        somehow (waiting for condition variable while locked more than once),
        the Unix implementation would already have deadlocked on the same
        code path (trying to lock more than once)
      One possible alternative to a CreateMutex mutex for use with condition
      variables would be a CRITICAL_SECTION. I'm not going to implement this,
      but Windows developers are welcome to do so.
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=36204
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=43744Reviewed-by: Thiago Macieira's avatarThiago Macieira <thiago@kde.org>
  6. 29 Dec, 2010 1 commit
  7. 13 Apr, 2010 1 commit
  8. 19 Mar, 2010 1 commit
  9. 01 Dec, 2009 1 commit
    • Tor Lillqvist's avatar
      Avoid warnings on Windows · 459c19b9
      Tor Lillqvist authored
      Remove unused functions, or put in #if 0 if potentially useful. Make
      internal functions used just in one file static. Use -Werror after all
      also on Windows. Construct the installation root from the location of
      the dbus DLL, not from the location of the program .exe of the
  10. 30 Nov, 2009 1 commit
  11. 14 Jul, 2009 1 commit
  12. 10 Jul, 2009 1 commit
  13. 14 Jul, 2007 1 commit
  14. 15 Mar, 2007 1 commit
  15. 13 Dec, 2006 1 commit
  16. 27 Oct, 2006 1 commit
    • Havoc Pennington's avatar
      2006-10-26 Havoc Pennington <hp@redhat.com> · 5886f532
      Havoc Pennington authored
              * dbus/dbus-threads.[hc]: Documentation improvements. Clarify how
      	condition variables relate to recursive mutexes.
              * dbus/dbus-sysdeps-pthread.c, dbus/dbus-sysdeps-win-thread.c,
      	dbus/dbus-threads.c: Split the platforms-specific thread
      	implementations into their own files.
      	* dbus/dbus-sysdeps-pthread.c
      	(_dbus_pthread_condvar_wait_timeout): invert the return value, it
      	was backward. Not that anything uses it.