1. 19 Jan, 2003 1 commit
    • Havoc Pennington's avatar
      2003-01-18 Havoc Pennington <hp@pobox.com> · 502fbda2
      Havoc Pennington authored
      	* dbus/dbus-transport-unix.c (unix_do_iteration): only do the
      	reading/writing if read_watch != NULL or write_watch != NULL.
      
      	* dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
      	the message loader code to actually load message->header and
      	message->body into the newly-created message.
      
      	* dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
      	in OOM case
      
      	* dbus/dbus-connection.c (dbus_connection_set_max_message_size)
      	(dbus_connection_get_max_message_size)
      	(dbus_connection_set_max_live_messages_size)
      	(dbus_connection_get_max_live_messages_size): implement some
      	resource limitation functions
      
      	* dbus/dbus-resources.c: new file implementing some of the
      	resource limits stuff
      
      	* dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
      	missing docs, add @todo to handle OOM etc.
      
      	* dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
      	docs
      502fbda2
  2. 18 Jan, 2003 4 commits
    • Havoc Pennington's avatar
      2003-01-18 Havoc Pennington <hp@pobox.com> · 0363701c
      Havoc Pennington authored
      	* dbus/dbus-connection.c (dbus_connection_unref): disconnect the
      	connection if it hasn't been already.
      
      	* dbus/dbus-connection.h: kill off the idea of an ErrorFunction,
      	replace with DisconnectFunction.
      0363701c
    • Havoc Pennington's avatar
      2003-01-18 Havoc Pennington <hp@pobox.com> · 6ac750b0
      Havoc Pennington authored
              Building --disable-verbose-mode --disable-asserts --disable-tests
      	cuts the library from 112K to 45K or so
      
      	* configure.in: check for varargs macro support,
      	add --enable-verbose-mode, --enable-asserts.
      
      	* dbus/dbus-internals.h (_dbus_assert): support
      	DBUS_DISABLE_ASSERT
      	(_dbus_verbose): support DBUS_ENABLE_VERBOSE_MODE
      6ac750b0
    • Havoc Pennington's avatar
      2003-01-18 Havoc Pennington <hp@pobox.com> · 650c2745
      Havoc Pennington authored
      	* dbus/dbus-test.c: include config.h so that tests actually run
      
      	* dbus/dbus-string.c: add assertions that stuff is 8-byte aligned,
      	so the failure mode when that assumption fails will be plenty
      	obvious.
      650c2745
    • Havoc Pennington's avatar
      2003-01-18 Havoc Pennington <hp@pobox.com> · 368e150a
      Havoc Pennington authored
      	* configure.in: default --enable-tests to $USE_MAINTAINER_MODE
      
      	* dbus/Makefile.am: fix it up so dubs-test-main.c is included in
      	the distribution
      
      	* test/Makefile.am: don't use special variable "TESTS" for echo-*
      	since we don't want to use those in make check
      368e150a
  3. 15 Jan, 2003 5 commits
  4. 14 Jan, 2003 1 commit
    • Anders Carlsson's avatar
      2003-01-14 Anders Carlsson <andersca@codefactory.se> · 1b9a4589
      Anders Carlsson authored
      	* bus/connection.c: (connection_error_handler),
      	(bus_connection_setup):
      	* bus/main.c: (main):
      	Make sure that the DBusConnectionData struct is NULLed
      	out to prevent a segfault.
      
      	* dbus/dbus-errors.c: (dbus_result_to_string):
      	* dbus/dbus-errors.h:
      	* dbus/dbus-message.c: (dbus_message_get_fields),
      	(dbus_message_get_fields_valist), (_dbus_message_test):
      	* dbus/dbus-message.h:
      	Make dbus_message_get_fields return a result code so we can
      	track invalid fields as well as oom.
      1b9a4589
  5. 11 Jan, 2003 1 commit
  6. 09 Jan, 2003 1 commit
    • Havoc Pennington's avatar
      2003-01-08 Havoc Pennington <hp@pobox.com> · 993be105
      Havoc Pennington authored
      	* dbus/dbus-string.c (_dbus_string_align_length): new function
      
      	* dbus/dbus-test-main.c: move main() for test app here
      	* dbus/dbus-test.c
      	(dbus_internal_symbol_do_not_use_run_tests): we have to export a
      	symbol to run tests, because dbus-test isn't in the main
      	library
      
              Code review nitpicks.
      
      	* dbus/dbus-message.c (dbus_message_write_header): add newlines
      	for people with narrow emacs ;-). Assert client_serial was filled
      	in. Assert message->name != NULL.
      	(dbus_message_append_fields): have "first_field_type" arg separate
      	from va list, needed for C++ binding that also uses varargs IIRC
      	and helps with type safety
      	(dbus_message_new): add @todo about using DBusString to store
      	service/name internally
      	(dbus_message_new): don't leak ->service and ->name on OOM later
      	in the function
      	(dbus_message_unref): free the service name
      	(dbus_message_get_fields): same change to varargs
      	i.e. first_field_type
      	(_dbus_message_loader_return_buffer): assert that the message data
      	is aligned (if not it's a bug in our code). Put in verbose griping
      	about why we set corrupted = TRUE.
      	(decode_header_data): add FIXME that char* is evil.  Was going to
      	add FIXME about evil locale-specific string.h strncmp, but just
      	switched to wacky string-as-uint32 optimization. Move check for
      	"no room for field name" above get_const_data_len() to avoid
      	assertion failure in get_const_data_len if we have trailing 2
      	bytes or the like. Check for service and name fields being
      	provided twice. Don't leak service/name on error. Require field
      	names to be aligned to 4 bytes.
      
      	* dbus/dbus-marshal.c: move byte swap stuff to header
      	(_dbus_pack_int32): uscore-prefix
      	(_dbus_unpack_int32): uscore-prefix
      	(_dbus_unpack_uint32): export
      	(_dbus_demarshal_string): add @todo complaining about use of
      	memcpy()
      	(_dbus_marshal_get_field_end_pos): add @todo about bad error
      	handling allowing corrupt data to go unchecked
      993be105
  7. 08 Jan, 2003 2 commits
  8. 07 Jan, 2003 4 commits
    • Anders Carlsson's avatar
      2003-01-08 Anders Carlsson <andersca@codefactory.se> · 000d29a2
      Anders Carlsson authored
      	* dbus/dbus-internals.c: (_dbus_type_to_string):
      	New function that returns a string describing a type.
      
      	* dbus/dbus-marshal.c: (_dbus_demarshal_byte_array):
      	* dbus/dbus-marshal.h:
      	* dbus/dbus-message.c: (dbus_message_get_fields_valist),
      	(dbus_message_iter_get_field_type), (dbus_message_iter_get_double),
      	(dbus_message_iter_get_byte_array):
      	* dbus/dbus-message.h:
      	Add new convenience functions for appending and getting message fields.
      	Also add demarshalling routines for byte arrays.
      000d29a2
    • Anders Carlsson's avatar
      2003-01-08 Anders Carlsson <andersca@codefactory.se> · 1f23ea99
      Anders Carlsson authored
      	reviewed by: <delete if not using a buddy>
      
      	* dbus/dbus-internals.c: (_dbus_type_to_string):
      	New function that returns a string describing a type.
      
      	* dbus/dbus-internals.h:
      	* dbus/dbus-message.c: (dbus_message_append_fields),
      	(dbus_message_append_fields_valist), (dbus_message_get_fields),
      	(dbus_message_get_fields_valist), (_dbus_message_test):
      	* dbus/dbus-message.h:
      	Add new convenience functions for appending and getting message fields.
      	Also add a test for those.
      1f23ea99
    • Anders Carlsson's avatar
      2003-01-07 Anders Carlsson <andersca@codefactory.se> · 1b53cbcc
      Anders Carlsson authored
      	* dbus/dbus-connection-internal.h:
      	* dbus/dbus-connection.c: (_dbus_connection_new_for_transport),
      	(_dbus_connection_get_next_client_serial),
      	(dbus_connection_send_message):
      	* dbus/dbus-internals.h:
      	* dbus/dbus-marshal.c: (unpack_uint32), (dbus_unpack_int32),
      	(dbus_pack_int32), (_dbus_marshal_double), (_dbus_marshal_int32),
      	(_dbus_marshal_uint32), (_dbus_demarshal_double),
      	(_dbus_demarshal_int32), (_dbus_demarshal_uint32),
      	(_dbus_demarshal_string), (_dbus_marshal_get_field_end_pos),
      	(_dbus_verbose_bytes), (_dbus_marshal_test):
      	* dbus/dbus-marshal.h:
      	* dbus/dbus-message-internal.h:
      	* dbus/dbus-message.c: (_dbus_message_set_client_serial),
      	(dbus_message_write_header), (_dbus_message_lock),
      	(dbus_message_new), (dbus_message_ref), (dbus_message_unref),
      	(dbus_message_get_name), (dbus_message_append_int32),
      	(dbus_message_append_uint32), (dbus_message_append_double),
      	(dbus_message_append_string), (dbus_message_append_byte_array),
      	(dbus_message_get_fields_iter), (dbus_message_iter_ref),
      	(dbus_message_iter_unref), (dbus_message_iter_has_next),
      	(dbus_message_iter_next), (dbus_message_iter_get_field_type),
      	(dbus_message_iter_get_string), (dbus_message_iter_get_int32),
      	(dbus_message_iter_get_uint32), (dbus_message_iter_get_double),
      	(decode_header_data), (_dbus_message_loader_return_buffer),
      	(message_iter_test), (_dbus_message_test):
      	* dbus/dbus-message.h:
      	* dbus/dbus-protocol.h:
      	* dbus/dbus-test.c: (main):
      	* dbus/dbus-test.h:
      	* glib/test-dbus-glib.c: (message_handler), (main):
      	* test/echo-client.c: (main):
      	* test/watch.c: (check_messages):
      	Make messages sendable and receivable for real.
      1b53cbcc
    • Havoc Pennington's avatar
  9. 06 Jan, 2003 4 commits
    • Anders Carlsson's avatar
      2003-01-07 Anders Carlsson <andersca@codefactory.se> · 3d2dee2a
      Anders Carlsson authored
      	* dbus/dbus-marshal.c: (_dbus_marshal_double),
      	(_dbus_marshal_string), (_dbus_marshal_byte_array):
      	* dbus/dbus-message.c: (dbus_message_append_int32),
      	(dbus_message_append_uint32), (dbus_message_append_double),
      	(dbus_message_append_string), (dbus_message_append_byte_array):
      	Handle OOM restoration.
      3d2dee2a
    • Anders Carlsson's avatar
      2003-01-07 Anders Carlsson <andersca@codefactory.se> · 5175ad00
      Anders Carlsson authored
      	* dbus/dbus-marshal.c: (_dbus_marshal_string),
      	(_dbus_demarshal_string), (_dbus_marshal_test):
      	* dbus/dbus-marshal.h:
      	Document these functions.
      
      	* dbus/dbus-message.c: (dbus_message_get_name),
      	(dbus_message_append_int32), (dbus_message_append_uint32),
      	(dbus_message_append_double), (dbus_message_append_string),
      	(dbus_message_append_byte_array):
      	* dbus/dbus-message.h:
      	Add functions for adding message fields of different types.
      
      	* dbus/dbus-protocol.h:
      	Add the different types.
      5175ad00
    • Havoc Pennington's avatar
    • Havoc Pennington's avatar
      2003-01-05 Havoc Pennington <hp@pobox.com> · 96a9f803
      Havoc Pennington authored
      	* bus/connection.c: implement routines for handling connections,
      	first thing is keeping a list of owned services on each connection
      	and setting up watches etc.
      
      	* bus/services.c: implement a mapping from service names to lists
      	of connections
      
      	* dbus/dbus-hash.c: add DBUS_HASH_POINTER
      
      	* dbus/dbus-threads.c (dbus_static_mutex_lock): add functions
      	to use static mutexes for global data
      
      	* dbus/dbus-connection.c (dbus_connection_set_data): add new
      	collection of functions to set/get application-specific data
      	on the DBusConnection.
      96a9f803
  10. 04 Jan, 2003 2 commits
    • Havoc Pennington's avatar
      2003-01-04 Havoc Pennington <hp@pobox.com> · c92339de
      Havoc Pennington authored
      	* dbus/dbus-sysdeps.c (_dbus_sleep_milliseconds): new function
      	(_dbus_poll): new function
      
      	* dbus/dbus-internals.h (_DBUS_STRUCT_OFFSET): new macro
      	copied from GLib
      
      	* bus/loop.c: initial code for the daemon main loop
      c92339de
    • Havoc Pennington's avatar
      2003-01-04 Havoc Pennington <hp@pobox.com> · 01af5ff4
      Havoc Pennington authored
      	* test/watch.c (error_handler): make it safe if the error handler
      	is called multiple times (if we s/error handler/disconnect
      	handler/ we should just guarantee it's called only once)
      
      	* dbus/dbus-transport.c (_dbus_transport_disconnect): call the
      	error handler on disconnect (it's quite possible we should
      	just change the error handler to a "disconnect handler," I'm
      	not sure we have any other meaningful errors)
      
      	* configure.in: check for getpwnam_r
      
      	* dbus/dbus-transport.c, dbus/dbus-transport-unix.c,
      	dbus/dbus-auth.c: add credentials support, add EXTERNAL auth
      	mechanism as in SASL spec, using socket credentials
      
      	* dbus/dbus-sysdeps.c (_dbus_read_credentials_unix_socket): new function
      	(_dbus_send_credentials_unix_socket): new function
      
      	* dbus/dbus-sysdeps.c (_dbus_accept_unix_socket): rename just
      	dbus_accept()
      	(_dbus_write): only check errno if <0 returned
      	(_dbus_write_two): ditto
      01af5ff4
  11. 02 Jan, 2003 1 commit
    • Anders Carlsson's avatar
      2003-01-02 Anders Carlsson <andersca@codefactory.se> · 1ed128b5
      Anders Carlsson authored
      	* dbus/dbus-marshal.c: (_dbus_marshal_utf8_string),
      	(_dbus_marshal_byte_array), (_dbus_demarshal_utf8_string),
      	(_dbus_marshal_test):
      	* dbus/dbus-marshal.h:
      	Add _dbus_marshal_byte_array and rename _dbus_marshal_string
      	to _dbus_marshal_utf8_string. Also fix some tests.
      1ed128b5
  12. 28 Dec, 2002 2 commits
  13. 27 Dec, 2002 6 commits
    • Kristian Rietveld's avatar
      2002-12-28 Kristian Rietveld <kris@gtk.org> · ebd603e7
      Kristian Rietveld authored
              * dbus/Makefile.am: fixup export-symbols-regex.
      ebd603e7
    • Anders Carlsson's avatar
      2002-12-27 Anders Carlsson <andersca@codefactory.se> · e36ea3b2
      Anders Carlsson authored
      	* acinclude.m4: Add this file and put the
      	PKG_CHECK_MODULE macro in it.
      e36ea3b2
    • Anders Carlsson's avatar
      2002-12-27 Anders Carlsson <andersca@codefactory.se> · acb0d169
      Anders Carlsson authored
      	* dbus/dbus-marshal.c: (_dbus_marshal_string),
      	(_dbus_demarshal_double), (_dbus_demarshal_int32),
      	(_dbus_demarshal_uint32), (_dbus_demarshal_string),
      	(_dbus_marshal_test):
      	Make the demarshalling routines align the pos argument.
      	Add string marshalling tests and fix the obvious bugs
      	discovered.
      acb0d169
    • Anders Carlsson's avatar
      Ssh · aa22d9db
      Anders Carlsson authored
      aa22d9db
    • Havoc Pennington's avatar
      2002-12-26 Havoc Pennington <hp@pobox.com> · b3ef8b0e
      Havoc Pennington authored
      	* dbus/dbus-auth.c: fixes fixes fixes
      
      	* dbus/dbus-transport-unix.c: wire up support for
      	encoding/decoding data on the wire
      
      	* dbus/dbus-auth.c (_dbus_auth_encode_data)
      	(_dbus_auth_decode_data): append to target string
      	instead of nuking it.
      b3ef8b0e
    • Havoc Pennington's avatar
      2002-12-26 Havoc Pennington <hp@pobox.com> · ff5283ab
      Havoc Pennington authored
      	* dbus/dbus-marshal.h (DBUS_COMPILER_BYTE_ORDER): #ifdef
      	WORDS_BIGENDIAN then compiler byte order is DBUS_BIG_ENDIAN,
      	doh
      
      	* dbus/dbus-marshal.c: Add macros to do int swapping in-place and
      	avoid swap_bytes() overhead (ignoring possible assembly stuff for
      	now). Main point is because I wanted unpack_uint32 to implement
      	_dbus_verbose_bytes
      	(_dbus_verbose_bytes): new function
      
      	* dbus/dbus-string.c (_dbus_string_validate_ascii): new function
      
      	* dbus/dbus-message.c (_dbus_message_loader_get_is_corrupted): add
      	mechanism to handle a corrupt message stream
      	(_dbus_message_loader_new): fix preallocation to only prealloc,
      	not prelengthen
      
      	* dbus/dbus-string.c (_dbus_string_skip_blank): fix this function
      	(_dbus_string_test): enhance tests for copy/move and fix the
      	functions
      
      	* dbus/dbus-transport-unix.c: Hold references in more places to
      	avoid reentrancy problems
      
      	* dbus/dbus-transport.c: ditto
      
      	* dbus/dbus-connection.c (dbus_connection_dispatch_message): don't
      	leak reference count in no-message case
      
      	* test/watch.c (do_mainloop): handle adding/removing watches
      	during iteration over the watches. Also, ref the connection/server
      	stored on a watch, so we don't try to mangle a destroyed one.
      
      	* dbus/dbus-transport-unix.c (do_authentication): perform
      	authentication
      
      	* dbus/dbus-auth.c (get_state): add a state
      	AUTHENTICATED_WITH_UNUSED_BYTES and return it if required
      	(_dbus_auth_get_unused_bytes): append the unused bytes
      	to the passed in string, rather than prepend
      
      	* dbus/dbus-transport.c (_dbus_transport_init_base): create
      	the auth conversation DBusAuth
      
      	* dbus/dbus-transport-unix.c (_dbus_transport_new_for_fd)
      	(_dbus_transport_new_for_domain_socket): when creating a
      	transport, pass in whether it's a client-side or server-side
      	transport so we know which DBusAuth to create
      ff5283ab
  14. 25 Dec, 2002 5 commits
    • Anders Carlsson's avatar
      2002-12-26 Anders Carlsson <andersca@codefactory.se> · f3729626
      Anders Carlsson authored
      	* dbus/dbus-marshal.c: (_dbus_marshal_string),
      	(_dbus_demarshal_double), (_dbus_demarshal_int32),
      	(_dbus_demarshal_uint32), (_dbus_demarshal_string),
      	(_dbus_marshal_test):
      	* dbus/dbus-marshal.h:
      	Add string marshal functions and have the demarshal functions
      	return the new position.
      f3729626
    • Havoc Pennington's avatar
      2002-12-25 Havoc Pennington <hp@pobox.com> · 22977874
      Havoc Pennington authored
      	* doc/dbus-sasl-profile.txt: docs on the authentication protocol,
      	it is a simple protocol that just maps directly to SASL.
      
      	* dbus/dbus-auth.h, dbus/dbus-auth.c: authentication protocol
      	initial implementation, not actually used yet.
      
      	* dbus/dbus-string.c (_dbus_string_find): new function
      	(_dbus_string_equal): new function
      	(_dbus_string_base64_encode): new function
      	(_dbus_string_base64_decode): new function
      22977874
    • Anders Carlsson's avatar
      2002-12-25 Anders Carlsson <andersca@codefactory.se> · f25559f5
      Anders Carlsson authored
      	* dbus/Makefile.am:
      	* dbus/dbus-marshal.c: (swap_bytes), (_dbus_marshal_double),
      	(_dbus_marshal_int32), (_dbus_marshal_uint32),
      	(_dbus_demarshal_double), (_dbus_demarshal_int32),
      	(_dbus_demarshal_uint32), (_dbus_marshal_test):
      	* dbus/dbus-marshal.h:
      	* dbus/dbus-protocol.h:
      	* dbus/dbus-test.c: (main):
      	* dbus/dbus-test.h:
      	Add un-optimized marshalling/demarshalling routines.
      f25559f5
    • Harri Porten's avatar
      0d1de761
    • Zack Rusin's avatar
      Starting the work on Qt integration. · e8c4af78
      Zack Rusin authored
      e8c4af78
  15. 24 Dec, 2002 1 commit
    • Havoc Pennington's avatar
      2002-12-24 Havoc Pennington <hp@pobox.com> · 17fbe2b7
      Havoc Pennington authored
      	* glib/dbus-gthread.c: fix include
      
      	* glib/dbus-glib.h: rename DBusMessageHandler for now.
      	I think glib API needs to change, though, as you don't
      	want to use DBusMessageFunction, you want to use the
      	DBusMessageHandler object. Probably
      	dbus_connection_open_with_g_main_loop()
      	and dbus_connection_setup_g_main_loop() or something like that
      	(but think of better names...) that just create a connection
      	that has watch/timeout functions etc. already set up.
      
      	* dbus/dbus-connection.c
      	(dbus_connection_send_message_with_reply): new function just to
      	show how the message handler helps us deal with replies.
      
      	* dbus/dbus-list.c (_dbus_list_remove_last): new function
      
      	* dbus/dbus-string.c (_dbus_string_test): free a string that
      	wasn't
      
      	* dbus/dbus-hash.c: use memory pools for the hash entries
      	(rebuild_table): be more paranoid about overflow, and
      	shrink table when we can
      	(_dbus_hash_test): reduce number of sprintfs and write
      	valid C89. Add tests for case where we grow and then
      	shrink the hash table.
      
      	* dbus/dbus-mempool.h, dbus/dbus-mempool.c: memory pools
      
      	* dbus/dbus-connection.c (dbus_connection_register_handler)
      	(dbus_connection_unregister_handler): new functions
      
      	* dbus/dbus-message.c (dbus_message_get_name): new
      
      	* dbus/dbus-list.c: fix docs typo
      
      	* dbus/dbus-message-handler.h, dbus/dbus-message-handler.c:
      	an object representing a handler for messages.
      17fbe2b7