- 26 Oct, 2015 9 commits
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Jan Alexander Steffens authored
As discussed in <https://github.com/systemd/systemd/issues/1600>. See also <https://bugs.archlinux.org/task/46721>, <https://bugzilla.gnome.org/show_bug.cgi?id=756420> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92612 [smcv: use AC_PATH_PROG to find systemctl; ignore systemctl failure] Signed-off-by:
Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by:
David Herrmann <dh.herrmann@gmail.com> [smcv: add links to earlier bug reports elsewhere]
-
Simon McVittie authored
Otherwise, we can't reliably run tests for Windows, because the default listening address on Windows is "autolaunch:" which is global to a machine, resulting in testing an installed dbus-daemon instead of the one we intended to test. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92538Signed-off-by:
Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
- 22 Oct, 2015 1 commit
-
-
Simon McVittie authored
These rely on the --systemd-activation code path, which is not compiled for Windows. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92538Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
- 21 Oct, 2015 1 commit
-
-
Ralf Habacker authored
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92298Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 19 Oct, 2015 3 commits
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
If the user gave us a syntactically invalid error name, we'd overwrite the MatchRuleInvalid error with NoMemory, causing an assertion failure (crash) in the dbus-daemon. This is not a denial-of-service vulnerability on the system bus, because monitoring is a privileged action, and root privilege is checked before this code is reached. However, it's an annoying bug on the session bus. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92298Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk> Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de> Signed-off-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 06 Oct, 2015 1 commit
-
-
Simon McVittie authored
-
- 05 Oct, 2015 4 commits
-
-
Simon McVittie authored
Both build systems arrange for this to be the case, and we already assume that it's absolute on Unix. On Windows, it's probably going to be /mingw/share or something; it gets relocated via _dbus_replace_install_prefix() at runtime. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83539Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
Simon McVittie authored
In particular, changing the meaning of DBUS_DATADIR part way through the file is really confusing. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83539Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
Simon McVittie authored
This was already done for the contents of .service files, but not config files. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92028Tested-by:
Ralf Habacker <ralf.habacker@freenet.de> Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
Simon McVittie authored
This means we handle OOM correctly, and makes it obvious that we are not overflowing buffers. This change does not affect the actual content of the strings. Instead of redefining DBUS_DATADIR to be a function call (which hides the fact that DBUS_DATADIR is used), this patch makes each use explicit: DBUS_DATADIR is always the #define from configure or cmake, before replacing the prefix. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83539Tested-by:
Ralf Habacker <ralf.habacker@freenet.de> Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
- 02 Oct, 2015 4 commits
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
This makes an installed tree with /some-prefix/ etc/ dbus-1/ session-local.conf share/ dbus-1/ session.conf relocatable to any location. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92028Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de> Tested-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
Simon McVittie authored
This fixes the error reporting if you make two attempts to activate a service that cannot be activated due to an error that is reported synchronously, such as a system service with no User= line in its .service file. This is easy to reproduce with the gdbus(1) tool, which sends an Introspect call in addition to the one you asked it to. If you try to activate a service using gdbus call --session -d com.example.FailToActivate \ -o / -m org.freedesktop.DBus.Peer.Ping then gdbus will actually send two method calls: one Introspect, and one Ping. The Introspect gets the correct error reply, but when dbus-daemon enters bus_activation_activate_service() for the Ping call, it sees that there is a pending activation and does an early-return. The pending activation does not finish until the timeout is reached. A couple of error cases handled this correctly, but the majority did not; make them all go into the same code path. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92200Reviewed-by:
Thiago Macieira <thiago@kde.org>
-
- 30 Sep, 2015 6 commits
-
-
Simon McVittie authored
-
Natanael Copa authored
Use the standard C99 PRI*64 macros instead of checking for specific GNU libc version. We also specifically check for windows which does not have proper C99 support. This fixes printing of int64 on non-GNU 32 bit systems (like musl libc). Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92043Reviewed-by:
Thiago Macieira <thiago@kde.org> Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk> [smcv: fix extra % in the Windows fallbacks; include <inttypes.h> where needed]
-
Simon McVittie authored
It turns out to be easier to implement the Windows version of these in a relocatable way if it can assume that the argument starts empty, which is in fact true in practice. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83539Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
Simon McVittie authored
-
Simon McVittie authored
-
Milan Crha authored
Doing strcat() into a static buffer produces incorrect results for the second and subsequent services if they are not in the ${prefix}; for example, if the first call should have returned "C:\bar\bin\service1" and the second should have returned "C:\bar\bin\service2", the second result would actually be "C:\bar\bin\service1C:\bar\bin\service2". Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83539Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk> [smcv: added commit message; used strncpy/strncat to avoid overflow] Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
- 20 Sep, 2015 1 commit
-
-
Ralf Habacker authored
The canonical location for bus setup changed from ${sysconfdir}/dbus-1 to ${datadir}/dbus-1 (or their CMake equivalents) in version 1.9.18. Also stop trying to use bus/session.conf from the build tree, which will not work if our ${prefix} contains an older ${sysconfdir}/dbus-1/session.conf. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92028Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
- 17 Sep, 2015 1 commit
-
-
Simon McVittie authored
-
- 25 Aug, 2015 6 commits
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
libcap-ng < 0.7.7 leaks one non-close-on-exec fd during initialization. test-bus asserts that all fds beyond 2 passed to an executed subprocess have the close-on-exec flag set, which will fail at that leaked fd. This was unnoticed until commit 517c4685, because libaudit was previously only initialized if we were configured to switch uid, which the regression tests do not do; the system bus is normally the only place that happens, but the system bus is not normally run with the "embedded tests" enabled (since they are bad for performance and security). Bug: https://bugs.freedesktop.org/show_bug.cgi?id=91684Reviewed-by:
Philip Withnall <philip.withnall@collabora.co.uk>
-
Simon McVittie authored
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=91684Reviewed-by:
Tyler Hicks <tyhicks@canonical.com>
-
- 06 Aug, 2015 3 commits
-
-
Simon McVittie authored
-
Simon McVittie authored
-
Simon McVittie authored
-