1. 15 Nov, 2017 1 commit
  2. 13 Oct, 2016 1 commit
    • Simon McVittie's avatar
      Clean up how we arrange for environ to be declared · 91ae697d
      Simon McVittie authored
      Annoyingly, the POSIX way to declare environ (as
      "extern char **environ") is a redundant declaration in glibc with
      _GNU_SOURCE; work around that.
      
      We also have a workaround for _NSGetEnviron() needing to be used
      instead of direct access to environ in at least some circumstances on
      Mac OS. Attempt to sync that up between all the files that use environ,
      consistently sorting the most special special-cases first (Windows
      for files that are compiled there, then Mac, then GNU, with
      lowest-common-denominator POSIX last).
      
      The affected files are already OS-specific, so I'm not bothering to
      introduce a nicer or higher-level API for this.
      
      Based on the best bits of an earlier patch from me, and an earlier
      patch from Thomas Zimmermann.
      Signed-off-by: default avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
      Reviewed-by: default avatarThomas Zimmermann <tdz@users.sourceforge.net>
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=97357
      91ae697d
  3. 30 Sep, 2016 1 commit
  4. 28 Jun, 2013 1 commit
  5. 13 Feb, 2012 1 commit
  6. 08 Feb, 2012 1 commit
  7. 19 Mar, 2010 1 commit
  8. 14 Jul, 2009 1 commit
  9. 10 Jul, 2009 1 commit
  10. 14 Jul, 2007 1 commit
  11. 12 Jul, 2007 1 commit
    • Havoc Pennington's avatar
      2007-07-12 Havoc Pennington <hp@redhat.com> · ed57b9c6
      Havoc Pennington authored
      	* dbus/dbus-sysdeps-util.c (_dbus_sysdeps_test): invert the test
      	for parsing hex as double to be sure it fails to work
      
      	* dbus/dbus-sysdeps.c (_dbus_string_parse_double): don't allow hex numbers.
      ed57b9c6
  12. 21 Jun, 2007 2 commits
    • Havoc Pennington's avatar
      2007-06-21 Havoc Pennington <hp@redhat.com> · ee721d13
      Havoc Pennington authored
      	* dbus/dbus-watch.c (dbus_watch_get_fd): 1) its behavior should
      	not be the same as before, the ABI has never been declared stable
      	on Windows and 2) do not commit to cross-platform files without
      	posting the exact patch to the mailing list
      
      	* dbus/dbus-sysdeps-util.c (_dbus_sysdeps_test): as I have pointed
      	out before, either 0xff needs to work on both platforms, or none
      	of the dbus code can rely on it working. That means the options
      	are 1) audit the code for anywhere that relies on 0xff working, if
      	none found ideally add a test that it *doesn't* work and make unix
      	reject it explicitly, but in any case this test would go away or
      	2) make it work on Windows also, then we don't have to figure out
      	whether we rely on it.
      
      	And in either case, post the exact patch to the mailing list and
      	don't just commit.
      ee721d13
    • Ralf Habacker's avatar
      * dbus/dbus-sysdeps-win.c (_dbus_sysdeps_test): don't check 0xff as floating... · 909c8ef4
      Ralf Habacker authored
      * dbus/dbus-sysdeps-win.c (_dbus_sysdeps_test): don't check 0xff as floating point, this isn't supported on win32 math implementation
      909c8ef4
  13. 13 Dec, 2006 1 commit
  14. 30 Aug, 2006 1 commit
  15. 14 Aug, 2006 1 commit
    • John Palmieri's avatar
      Patches by Kjartan Maraas <kmaraas at gnome dot org> · c1091cbb
      John Palmieri authored
              * bus/services.c (bus_service_list_queued_owners):
              Add a pointer cast to fix compiler warning
      
              * dbus/dbus-dataslot.c (_dbus_data_slot_list_get):
              return a NULL instead of FALSE since the return type
              is not expecting a boolean
      
              * dbus/dbus-marshal-basic.c (_dbus_marshal_test):
              Remove unused variable
      
              * dbus/dbus-marshal-recursive-util.c (node_new):
              return a NULL instead of FALSE since the return type
              is not expecting a boolean
      
              * dbus/dbus-server-debug-pipe.c (_dbus_transport_debug_pipe_new):
              Send a NULL into _dbus_transport_new_for_fd instead of a FALSE
              because we are expecting a pointer not a boolean
      
              * dbus/dbus-sysdeps-util.c (_dbus_get_tmpdir):
              add void as the parameter so some compilers
              don't complain
      
              * dbus/dbus-transport-unix.c (_dbus_transport_new_for_domain_socket,
                _dbus_transport_new_for_tcp_socket):
              Send a NULL into _dbus_transport_new_for_fd instead of a FALSE
              because we are expecting a pointer not a boolean
      
              * test/shell-test.c (test_command_line):
              cast the second argument to _dbus_list_append to avoid compiler
              warnings
      
              * test/test-names.c (main): remove unused variable
      
              * test/test-service.c (check_hello_from_self_reply):
              Initialize echo_message and echo_reply to NULL
      
              * test/test-shell-service.c (handle_echo):
              Remove unused variable and cast the third parameter passed to
              dbus_connection_get_object_path_data to avoid compiler warrnings
      
              * test/name-test/test-names.c (clear_message_queue):
              Remove unused function
      
              * test/name-test/test-pending-call-dispatch.c:
              Fix format string in printf
      c1091cbb
  16. 08 Aug, 2006 1 commit
    • John Palmieri's avatar
      These are all patches from Kjartan Maraas <kmaraas at gnome dot org> · 9a3145b9
      John Palmieri authored
      with cleanups of bugs found from Coverity reports:
      
      * dbus/dbus-sysdeps-util.c (_dbus_write_pid_file):
        close the file on error to avoid a leak
      
      * bus/expirelist.c (bus_expire_list_test):
        Check for NULL on dbus_new0
      
      * bus/activation.c (update_directory):
        remove dead code
      
      * bus/config-parser.c (merge_service_context_hash, start_selinux_child):
        Fix some leaks
      
      * bus/bus.c (process_config_every_time):
        Fixed a leak
      
      * bus/desktop-file.c (parse_key_value):
        Fixed leak
      
      * bus/selinux.c (bus_selinux_id_table_insert):
        Fixed leak
      9a3145b9
  17. 24 Feb, 2006 1 commit
    • John Palmieri's avatar
      2006-02-24 John (J5) Palmieri <johnp@redhat.com> · a2866f73
      John Palmieri authored
      	* patch from Sjoerd Simons <sjoerd at debian.org>:
      
      	* dbus/dbus-sysdeps-util.c (_dbus_group_info_free): Moved to
      	dbus/dbus-sysdeps.c
      
      	* dbus/dbus-userdb.c (_dbus_group_info_free_allocated): Don't
      	call _dbus_group_info_free_allocated which causes infinite loop,
      	correctly call _dbus_group_info_free
      a2866f73
  18. 08 Jul, 2005 1 commit
    • Joe Shaw's avatar
      2005-07-08 Joe Shaw <joeshaw@novell.com> · b1e21dad
      Joe Shaw authored
      	* configure.in: Add a configure option, --with-console-auth-dir
      
      	* dbus/dbus-sysdeps-util.c (_dbus_user_at_console): Use the
      	new setting.  Patch from Kay Sievers.
      b1e21dad
  19. 11 May, 2005 1 commit
  20. 08 May, 2005 1 commit
  21. 05 Mar, 2005 1 commit
    • Havoc Pennington's avatar
      2005-03-05 Havoc Pennington <hp@redhat.com> · ae94f92b
      Havoc Pennington authored
      	* dbus/dbus-sysdeps.c:
      	(pseudorandom_generate_random_bytes_buffer): fix to have no return
      	value
      	(_dbus_generate_random_bytes_buffer): fix return value
      
      	* dbus/dbus-sysdeps-util.c: s/GETPWNAME/GETPWNAM/ so configure
      	checks actually work, from Tom Parker <fdo@tevp.net>
      ae94f92b
  22. 17 Jan, 2005 1 commit
    • Havoc Pennington's avatar
      2005-01-16 Havoc Pennington <hp@redhat.com> · 7bf62e31
      Havoc Pennington authored
              This is about it on what can be disabled/deleted from libdbus
      	easily, back below 150K anyhow. Deeper cuts are more work than
      	just turning the code off as I've done here.
      
      	* dbus/dbus-marshal-basic.c (_dbus_pack_int32): we don't need the
      	signed int convenience funcs
      
      	* dbus/dbus-internals.c (_dbus_verbose_real): omit when not in
      	verbose mode
      
      	* dbus/dbus-string-util.c, dbus/dbus-string.c: more breaking
      	things out of libdbus
      
      	* dbus/dbus-sysdeps.c, dbus/dbus-sysdeps-util.c: same
      
      	* dbus/dbus-hash.c: purge the TWO_STRINGS crap (well, make it
      	tests-enabled-only, though it should probably be deleted)
      
      	* dbus/dbus-message-util.c: same stuff
      
      	* dbus/dbus-auth-util.c: same stuff
      7bf62e31