Commit d10ac7c5 authored by Ralf Habacker's avatar Ralf Habacker

bus_registry_new: Assert in case of not valid context parameter to avoid...

bus_registry_new: Assert in case of not valid context parameter to avoid potiental crashes (CID 54764).

Because the context parameter is dereferenced several times in related code without a null check,
we need to make sure to have a valid context.

Reported by Coverity: CID 54764: Dereference after null check (FORWARD_NULL)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021Reviewed-by: default avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
parent 907c0b36
......@@ -76,6 +76,7 @@ bus_registry_new (BusContext *context)
{
BusRegistry *registry;
_dbus_assert (context);
registry = dbus_new0 (BusRegistry, 1);
if (registry == NULL)
return NULL;
......@@ -461,8 +462,7 @@ bus_registry_acquire_service (BusRegistry *registry,
}
if (!bus_apparmor_allows_acquire_service (connection,
(registry->context ?
bus_context_get_type (registry->context) : NULL),
bus_context_get_type (registry->context),
_dbus_string_get_const_data (service_name), error))
goto out;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment