Skip to content
  • Ralf Habacker's avatar
    _dbus_string_skip_blank(): Let the final assert follow the previous search · 8d54aa2f
    Ralf Habacker authored and Simon McVittie's avatar Simon McVittie committed
    This appears to have been a copy/paste mistake. If only blanks (defined as
    spaces or tabs) were removed, then it cannot be right to check for white
    space (defined as spaces, tabs, carriage return or linefeed) afterwards.
    
    If libdbus was compiled with assertions enabled, then this is a
    denial-of-service issue for dbus-daemon or other users of DBusServer:
    an unauthenticated user with access to the server's socket can send
    whitespace that triggers this assertion failure. We recommend that
    production versions of dbus, for example in OS distributions, should be
    compiled with checks but without assertions.
    
    [smcv: expanded commit message]
    
    Thanks: Evgeny Vereshchagin
    Resolves: #421
    8d54aa2f