Skip to content
  • Simon McVittie's avatar
    Consistently save and restore errno · c7fdbe77
    Simon McVittie authored
    Some functions in dbus-transport-socket.c make a (wrapped)
    socket syscall, then call other APIs, then test the result and
    errno of the socket syscall.
    
    This would break horribly if those "other APIs" overwrote errno with
    their own value (... and this is part of why errno is an awful API).
    
    Notably, if running under DBUS_VERBOSE, _dbus_verbose() is basically
    fprintf(), which sets errno; and our Unix fd-passing support
    makes calls of the form _dbus_verbose ("Read/wrote %i unix fds\n", n)
    between the syscall and the result processing.
    
    Maybe one day we'll convert all of dbus' syscall wrappers to either
    raise a DBusError, or use the "negative errno" convention that systemd
    borrowed from the Linux kernel, and in particular, we would need to
    do that if we ever ported it to a platform where socket error reporting
    was not basically errno. However, in practice everyone uses something
    derived from BSD sockets, so "this sets errno, you know what errno is"
    is a good enough internal API if we make sure to use it correctly.
    
    Nothing calls _dbus_get_is_errno_nonzero(), so I just removed it instead
    of converting it to the new calling convention.
    
    Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83625
    c7fdbe77