Skip to content
  • Ralf Habacker's avatar
    Always assert that BUS_CONNECTION_DATA() returns non-NULL · d5e7e279
    Ralf Habacker authored
    Every DBusConnection in the dbus-daemon should have been through
    bus_connections_setup_connection(), so we can assert that the
    BusConnectionData has been attached to it. Having this assertion
    is enough to hint to Coverity that it does not need to worry about
    whether this pointer might be NULL.
    
    In regression tests, we do work with a few fake client-side
    DBusConnection instances in the same process; but it would be a
    serious bug if we mixed those up with the ones processed by
    dbus-daemon's real code, so the assertion is still valid.
    
    This patch has been inspired by (and fixes) the following coverity scan issues:
    CID 54846: Dereference null return value (NULL_RETURNS).
    CID 54854: Dereference null return value (NULL_RETURNS).
    
    Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
    
    
    Reviewed-by: default avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
    [smcv: fixed -Wdeclaration-after-statement; more informative commit message]
    Reviewed-by: default avatarRalf Habacker <ralf.habacker@freenet.de>
    d5e7e279