dbus-spawn-unix.c 42.8 KB
Newer Older
1
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
2
/* dbus-spawn-unix.c — Wrapper around fork/exec
3
 *
4
 * Copyright (C) 2002, 2003, 2004  Red Hat, Inc.
5 6
 * Copyright (C) 2003 CodeFactory AB
 *
7
 * Licensed under the Academic Free License version 2.1
8
 *
9 10 11 12 13 14 15 16 17
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
18
 *
19 20
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
21
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
22 23
 *
 */
24 25 26

#include <config.h>

27 28 29 30
#if defined(DBUS_WIN) || !defined(DBUS_UNIX)
#error "This file only makes sense on Unix OSs"
#endif

31
#include "dbus-spawn.h"
32
#include "dbus-sysdeps-unix.h"
33
#include "dbus-internals.h"
34
#include "dbus-test.h"
35
#include "dbus-protocol.h"
36 37 38 39 40

#include <unistd.h>
#include <fcntl.h>
#include <signal.h>
#include <sys/wait.h>
41
#include <stdio.h>
42
#include <stdlib.h>
43 44 45
#ifdef HAVE_ERRNO_H
#include <errno.h>
#endif
46
#ifdef HAVE_SYSTEMD
47 48 49
#ifdef HAVE_SYSLOG_H
#include <syslog.h>
#endif
50 51
#include <systemd/sd-journal.h>
#endif
52

53 54 55 56
#if defined(__APPLE__)
# include <crt_externs.h>
# define environ (*_NSGetEnviron ())
#elif !HAVE_DECL_ENVIRON
57
extern char **environ;
58
#endif
59

60 61 62 63 64
/**
 * @addtogroup DBusInternalsUtils
 * @{
 */

65 66 67 68 69
/*
 * I'm pretty sure this whole spawn file could be made simpler,
 * if you thought about it a bit.
 */

70 71 72
/**
 * Enumeration for status of a read()
 */
73 74
typedef enum
{
75 76 77
  READ_STATUS_OK,    /**< Read succeeded */
  READ_STATUS_ERROR, /**< Some kind of error */
  READ_STATUS_EOF    /**< EOF returned */
78 79 80 81 82 83 84 85 86
} ReadStatus;

static ReadStatus
read_ints (int        fd,
	   int       *buf,
	   int        n_ints_in_buf,
	   int       *n_ints_read,
	   DBusError *error)
{
87
  size_t bytes = 0;
88
  ReadStatus retval;
89

90 91 92
  _DBUS_ASSERT_ERROR_IS_CLEAR (error);

  retval = READ_STATUS_OK;
93

94 95
  while (TRUE)
    {
96 97
      ssize_t chunk;
      size_t to_read;
98 99 100 101 102

      to_read = sizeof (int) * n_ints_in_buf - bytes;

      if (to_read == 0)
        break;
103 104

    again:
105

106 107 108
      chunk = read (fd,
                    ((char*)buf) + bytes,
                    to_read);
109

110 111
      if (chunk < 0 && errno == EINTR)
        goto again;
112

113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141
      if (chunk < 0)
        {
          dbus_set_error (error,
			  DBUS_ERROR_SPAWN_FAILED,
			  "Failed to read from child pipe (%s)",
			  _dbus_strerror (errno));

          retval = READ_STATUS_ERROR;
          break;
        }
      else if (chunk == 0)
        {
          retval = READ_STATUS_EOF;
          break; /* EOF */
        }
      else /* chunk > 0 */
	bytes += chunk;
    }

  *n_ints_read = (int)(bytes / sizeof(int));

  return retval;
}

static ReadStatus
read_pid (int        fd,
          pid_t     *buf,
          DBusError *error)
{
142
  size_t bytes = 0;
143
  ReadStatus retval;
144

145 146 147
  _DBUS_ASSERT_ERROR_IS_CLEAR (error);

  retval = READ_STATUS_OK;
148

149 150
  while (TRUE)
    {
151 152 153
      ssize_t chunk;
      size_t to_read;

154 155 156 157
      to_read = sizeof (pid_t) - bytes;

      if (to_read == 0)
        break;
158 159

    again:
160

161 162 163 164 165
      chunk = read (fd,
                    ((char*)buf) + bytes,
                    to_read);
      if (chunk < 0 && errno == EINTR)
        goto again;
166

167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192
      if (chunk < 0)
        {
          dbus_set_error (error,
			  DBUS_ERROR_SPAWN_FAILED,
			  "Failed to read from child pipe (%s)",
			  _dbus_strerror (errno));

          retval = READ_STATUS_ERROR;
          break;
        }
      else if (chunk == 0)
        {
          retval = READ_STATUS_EOF;
          break; /* EOF */
        }
      else /* chunk > 0 */
	bytes += chunk;
    }

  return retval;
}

/* The implementation uses an intermediate child between the main process
 * and the grandchild. The grandchild is our spawned process. The intermediate
 * child is a babysitter process; it keeps track of when the grandchild
 * exits/crashes, and reaps the grandchild.
193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
 *
 * We automatically reap the babysitter process, killing it if necessary,
 * when the DBusBabysitter's refcount goes to zero.
 *
 * Processes:
 *
 * main process
 * | fork() A
 * \- babysitter
 *    | fork () B
 *    \- grandchild     --> exec -->    spawned process
 *
 * IPC:
 *                  child_err_report_pipe
 *          /-----------<---------<--------------\
 *          |                                    ^
 *          v                                    |
 * main process           babysitter          grandchild
 *          ^                 ^
 *          v                 v
 *          \-------<->-------/
 *            babysitter_pipe
 *
 * child_err_report_pipe is genuinely a pipe.
 * The READ_END (also called error_pipe_from_child) is used in the main
 * process. The WRITE_END (also called child_err_report_fd) is used in
 * the grandchild process.
 *
 * On failure, the grandchild process sends CHILD_EXEC_FAILED + errno.
 * On success, the pipe just closes (because it's close-on-exec) without
 * sending any bytes.
 *
 * babysitter_pipe is mis-named: it's really a bidirectional socketpair.
 * The [0] end (also called socket_to_babysitter) is used in the main
 * process, the [1] end (also called parent_pipe) is used in the babysitter.
 *
 * If the fork() labelled B in the diagram above fails, the babysitter sends
 * CHILD_FORK_FAILED + errno.
 * On success, the babysitter sends CHILD_PID + the grandchild's pid.
 * On SIGCHLD, the babysitter sends CHILD_EXITED + the exit status.
 * The main process doesn't explicitly send anything, but when it exits,
 * the babysitter gets POLLHUP or POLLERR.
235 236 237 238 239 240 241 242 243 244 245
 */

/* Messages from children to parents */
enum
{
  CHILD_EXITED,            /* This message is followed by the exit status int */
  CHILD_FORK_FAILED,       /* Followed by errno */
  CHILD_EXEC_FAILED,       /* Followed by errno */
  CHILD_PID                /* Followed by pid_t */
};

246 247 248
/**
 * Babysitter implementation details
 */
249 250
struct DBusBabysitter
{
251
  int refcount; /**< Reference count */
252

253 254
  char *log_name; /**< the name under which to log messages about this
		    process being spawned */
255

256
  DBusSocket socket_to_babysitter; /**< Connection to the babysitter process */
257
  int error_pipe_from_child; /**< Connection to the process that does the exec() */
258

259 260
  pid_t sitter_pid;  /**< PID Of the babysitter */
  pid_t grandchild_pid; /**< PID of the grandchild */
261

262
  DBusWatchList *watches; /**< Watches */
263

264 265
  DBusWatch *error_watch; /**< Error pipe watch */
  DBusWatch *sitter_watch; /**< Sitter pipe watch */
266

267 268 269
  DBusBabysitterFinishedFunc finished_cb;
  void *finished_data;

270 271 272 273 274
  int errnum; /**< Error number */
  int status; /**< Exit status code */
  unsigned int have_child_status : 1; /**< True if child status has been reaped */
  unsigned int have_fork_errnum : 1; /**< True if we have an error code from fork() */
  unsigned int have_exec_errnum : 1; /**< True if we have an error code from exec() */
275 276 277 278 279 280 281 282 283 284 285 286 287
};

static DBusBabysitter*
_dbus_babysitter_new (void)
{
  DBusBabysitter *sitter;

  sitter = dbus_new0 (DBusBabysitter, 1);
  if (sitter == NULL)
    return NULL;

  sitter->refcount = 1;

288
  sitter->socket_to_babysitter.fd = -1;
289
  sitter->error_pipe_from_child = -1;
290

291 292 293 294 295 296
  sitter->sitter_pid = -1;
  sitter->grandchild_pid = -1;

  sitter->watches = _dbus_watch_list_new ();
  if (sitter->watches == NULL)
    goto failed;
297

298 299 300 301 302 303 304 305 306 307 308
  return sitter;

 failed:
  _dbus_babysitter_unref (sitter);
  return NULL;
}

/**
 * Increment the reference count on the babysitter object.
 *
 * @param sitter the babysitter
309
 * @returns the babysitter
310
 */
311
DBusBabysitter *
312 313 314 315
_dbus_babysitter_ref (DBusBabysitter *sitter)
{
  _dbus_assert (sitter != NULL);
  _dbus_assert (sitter->refcount > 0);
316

317
  sitter->refcount += 1;
318 319

  return sitter;
320 321
}

322 323 324
static void close_socket_to_babysitter  (DBusBabysitter *sitter);
static void close_error_pipe_from_child (DBusBabysitter *sitter);

325 326
/**
 * Decrement the reference count on the babysitter object.
327 328 329
 * When the reference count of the babysitter object reaches
 * zero, the babysitter is killed and the child that was being
 * babysat gets emancipated.
330 331 332 333 334 335 336 337
 *
 * @param sitter the babysitter
 */
void
_dbus_babysitter_unref (DBusBabysitter *sitter)
{
  _dbus_assert (sitter != NULL);
  _dbus_assert (sitter->refcount > 0);
338

339 340
  sitter->refcount -= 1;
  if (sitter->refcount == 0)
341 342 343 344 345 346 347 348 349
    {
      /* If we haven't forked other babysitters
       * since this babysitter and socket were
       * created then this close will cause the
       * babysitter to wake up from poll with
       * a hangup and then the babysitter will
       * quit itself.
       */
      close_socket_to_babysitter (sitter);
350

351
      close_error_pipe_from_child (sitter);
352

353
      if (sitter->sitter_pid > 0)
354 355 356 357
        {
          int status;
          int ret;

358
          /* It's possible the babysitter died on its own above
359 360 361 362 363 364 365 366 367 368 369 370
           * from the close, or was killed randomly
           * by some other process, so first try to reap it
           */
          ret = waitpid (sitter->sitter_pid, &status, WNOHANG);

          /* If we couldn't reap the child then kill it, and
           * try again
           */
          if (ret == 0)
            kill (sitter->sitter_pid, SIGKILL);

          if (ret == 0)
371 372 373 374 375 376 377
            {
              do
                {
                  ret = waitpid (sitter->sitter_pid, &status, 0);
                }
              while (_DBUS_UNLIKELY (ret < 0 && errno == EINTR));
            }
378

379 380
          if (ret < 0)
            {
381
              if (errno == ECHILD)
382
                _dbus_warn ("Babysitter process not available to be reaped; should not happen");
383
              else
384
                _dbus_warn ("Unexpected error %d in waitpid() for babysitter: %s",
385 386 387 388
                            errno, _dbus_strerror (errno));
            }
          else
            {
389 390
              _dbus_verbose ("Reaped %ld, waiting for babysitter %ld\n",
                             (long) ret, (long) sitter->sitter_pid);
391

392 393 394 395 396 397 398 399 400
              if (WIFEXITED (sitter->status))
                _dbus_verbose ("Babysitter exited with status %d\n",
                               WEXITSTATUS (sitter->status));
              else if (WIFSIGNALED (sitter->status))
                _dbus_verbose ("Babysitter received signal %d\n",
                               WTERMSIG (sitter->status));
              else
                _dbus_verbose ("Babysitter exited abnormally\n");
            }
401 402

          sitter->sitter_pid = -1;
403 404 405 406 407
        }

      if (sitter->watches)
        _dbus_watch_list_free (sitter->watches);

408
      dbus_free (sitter->log_name);
409

410 411 412 413 414 415 416 417 418 419
      dbus_free (sitter);
    }
}

static ReadStatus
read_data (DBusBabysitter *sitter,
           int             fd)
{
  int what;
  int got;
420
  DBusError error = DBUS_ERROR_INIT;
421
  ReadStatus r;
422

423 424 425 426 427
  r = read_ints (fd, &what, 1, &got, &error);

  switch (r)
    {
    case READ_STATUS_ERROR:
428
      _dbus_warn ("Failed to read data from fd %d: %s", fd, error.message);
429 430 431 432 433 434 435 436
      dbus_error_free (&error);
      return r;

    case READ_STATUS_EOF:
      return r;

    case READ_STATUS_OK:
      break;
437 438 439 440

    default:
      _dbus_assert_not_reached ("invalid ReadStatus");
      break;
441
    }
442

443 444 445 446 447 448 449 450 451
  if (got == 1)
    {
      switch (what)
        {
        case CHILD_EXITED:
        case CHILD_FORK_FAILED:
        case CHILD_EXEC_FAILED:
          {
            int arg;
452

453 454 455 456 457
            r = read_ints (fd, &arg, 1, &got, &error);

            switch (r)
              {
              case READ_STATUS_ERROR:
458
                _dbus_warn ("Failed to read arg from fd %d: %s", fd, error.message);
459 460 461 462 463 464
                dbus_error_free (&error);
                return r;
              case READ_STATUS_EOF:
                return r;
              case READ_STATUS_OK:
                break;
465 466 467
              default:
                _dbus_assert_not_reached ("invalid ReadStatus");
                break;
468
              }
469

470 471 472 473
            if (got == 1)
              {
                if (what == CHILD_EXITED)
                  {
474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490
                    /* Do not reset sitter->errnum to 0 here. We get here if
                     * the babysitter reports that the grandchild process has
                     * exited, and there are two ways that can happen:
                     *
                     * 1. grandchild successfully exec()s the desired process,
                     * but then the desired process exits or is terminated
                     * by a signal. The babysitter observes this and reports
                     * CHILD_EXITED.
                     *
                     * 2. grandchild fails to exec() the desired process,
                     * attempts to report the exec() failure (which
                     * we will receive as CHILD_EXEC_FAILED), and then
                     * exits itself (which will prompt the babysitter to
                     * send CHILD_EXITED). We want the CHILD_EXEC_FAILED
                     * to take precedence (and have its errno logged),
                     * which _dbus_babysitter_set_child_exit_error() does.
                     */
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
                    sitter->have_child_status = TRUE;
                    sitter->status = arg;
                    _dbus_verbose ("recorded child status exited = %d signaled = %d exitstatus = %d termsig = %d\n",
                                   WIFEXITED (sitter->status), WIFSIGNALED (sitter->status),
                                   WEXITSTATUS (sitter->status), WTERMSIG (sitter->status));
                  }
                else if (what == CHILD_FORK_FAILED)
                  {
                    sitter->have_fork_errnum = TRUE;
                    sitter->errnum = arg;
                    _dbus_verbose ("recorded fork errnum %d\n", sitter->errnum);
                  }
                else if (what == CHILD_EXEC_FAILED)
                  {
                    sitter->have_exec_errnum = TRUE;
                    sitter->errnum = arg;
                    _dbus_verbose ("recorded exec errnum %d\n", sitter->errnum);
                  }
              }
          }
          break;
        case CHILD_PID:
          {
            pid_t pid = -1;

            r = read_pid (fd, &pid, &error);
517

518 519 520
            switch (r)
              {
              case READ_STATUS_ERROR:
521
                _dbus_warn ("Failed to read PID from fd %d: %s", fd, error.message);
522 523 524 525 526 527
                dbus_error_free (&error);
                return r;
              case READ_STATUS_EOF:
                return r;
              case READ_STATUS_OK:
                break;
528 529 530
              default:
                _dbus_assert_not_reached ("invalid ReadStatus");
                break;
531
              }
532

533
            sitter->grandchild_pid = pid;
534

535 536 537 538
            _dbus_verbose ("recorded grandchild pid %d\n", sitter->grandchild_pid);
          }
          break;
        default:
539
          _dbus_warn ("Unknown message received from babysitter process");
540 541 542 543 544 545 546 547 548 549 550
          break;
        }
    }

  return r;
}

static void
close_socket_to_babysitter (DBusBabysitter *sitter)
{
  _dbus_verbose ("Closing babysitter\n");
551 552 553 554 555 556 557 558 559 560

  if (sitter->sitter_watch != NULL)
    {
      _dbus_assert (sitter->watches != NULL);
      _dbus_watch_list_remove_watch (sitter->watches,  sitter->sitter_watch);
      _dbus_watch_invalidate (sitter->sitter_watch);
      _dbus_watch_unref (sitter->sitter_watch);
      sitter->sitter_watch = NULL;
    }

561
  if (sitter->socket_to_babysitter.fd >= 0)
562 563
    {
      _dbus_close_socket (sitter->socket_to_babysitter, NULL);
564
      sitter->socket_to_babysitter.fd = -1;
565
    }
566 567 568 569 570 571
}

static void
close_error_pipe_from_child (DBusBabysitter *sitter)
{
  _dbus_verbose ("Closing child error\n");
572 573 574 575 576 577 578 579 580 581 582 583

  if (sitter->error_watch != NULL)
    {
      _dbus_assert (sitter->watches != NULL);
      _dbus_watch_list_remove_watch (sitter->watches,  sitter->error_watch);
      _dbus_watch_invalidate (sitter->error_watch);
      _dbus_watch_unref (sitter->error_watch);
      sitter->error_watch = NULL;
    }

  if (sitter->error_pipe_from_child >= 0)
    {
584
      _dbus_close (sitter->error_pipe_from_child, NULL);
585 586
      sitter->error_pipe_from_child = -1;
    }
587 588 589 590 591 592 593 594 595 596 597 598 599
}

static void
handle_babysitter_socket (DBusBabysitter *sitter,
                          int             revents)
{
  /* Even if we have POLLHUP, we want to keep reading
   * data until POLLIN goes away; so this function only
   * looks at HUP/ERR if no IN is set.
   */
  if (revents & _DBUS_POLLIN)
    {
      _dbus_verbose ("Reading data from babysitter\n");
600
      if (read_data (sitter, sitter->socket_to_babysitter.fd) != READ_STATUS_OK)
601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634
        close_socket_to_babysitter (sitter);
    }
  else if (revents & (_DBUS_POLLERR | _DBUS_POLLHUP))
    {
      close_socket_to_babysitter (sitter);
    }
}

static void
handle_error_pipe (DBusBabysitter *sitter,
                   int             revents)
{
  if (revents & _DBUS_POLLIN)
    {
      _dbus_verbose ("Reading data from child error\n");
      if (read_data (sitter, sitter->error_pipe_from_child) != READ_STATUS_OK)
        close_error_pipe_from_child (sitter);
    }
  else if (revents & (_DBUS_POLLERR | _DBUS_POLLHUP))
    {
      close_error_pipe_from_child (sitter);
    }
}

/* returns whether there were any poll events handled */
static dbus_bool_t
babysitter_iteration (DBusBabysitter *sitter,
                      dbus_bool_t     block)
{
  DBusPollFD fds[2];
  int i;
  dbus_bool_t descriptors_ready;

  descriptors_ready = FALSE;
635

636 637 638 639 640 641 642 643 644
  i = 0;

  if (sitter->error_pipe_from_child >= 0)
    {
      fds[i].fd = sitter->error_pipe_from_child;
      fds[i].events = _DBUS_POLLIN;
      fds[i].revents = 0;
      ++i;
    }
645

646
  if (sitter->socket_to_babysitter.fd >= 0)
647
    {
648
      fds[i].fd = sitter->socket_to_babysitter.fd;
649 650 651 652 653 654 655 656 657
      fds[i].events = _DBUS_POLLIN;
      fds[i].revents = 0;
      ++i;
    }

  if (i > 0)
    {
      int ret;

658 659 660 661 662 663
      do
        {
          ret = _dbus_poll (fds, i, 0);
        }
      while (ret < 0 && errno == EINTR);

664
      if (ret == 0 && block)
665 666 667 668 669 670 671 672
        {
          do
            {
              ret = _dbus_poll (fds, i, -1);
            }
          while (ret < 0 && errno == EINTR);
        }

673 674 675
      if (ret > 0)
        {
          descriptors_ready = TRUE;
676

677 678 679 680 681
          while (i > 0)
            {
              --i;
              if (fds[i].fd == sitter->error_pipe_from_child)
                handle_error_pipe (sitter, fds[i].revents);
682
              else if (fds[i].fd == sitter->socket_to_babysitter.fd)
683 684 685 686 687 688 689 690 691 692 693 694
                handle_babysitter_socket (sitter, fds[i].revents);
            }
        }
    }

  return descriptors_ready;
}

/**
 * Macro returns #TRUE if the babysitter still has live sockets open to the
 * babysitter child or the grandchild.
 */
695
#define LIVE_CHILDREN(sitter) ((sitter)->socket_to_babysitter.fd >= 0 || (sitter)->error_pipe_from_child >= 0)
696 697 698 699 700 701 702 703 704 705 706 707 708 709 710

/**
 * Blocks until the babysitter process gives us the PID of the spawned grandchild,
 * then kills the spawned grandchild.
 *
 * @param sitter the babysitter object
 */
void
_dbus_babysitter_kill_child (DBusBabysitter *sitter)
{
  /* be sure we have the PID of the child */
  while (LIVE_CHILDREN (sitter) &&
         sitter->grandchild_pid == -1)
    babysitter_iteration (sitter, TRUE);

711 712
  _dbus_verbose ("Got child PID %ld for killing\n",
                 (long) sitter->grandchild_pid);
713

714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734
  if (sitter->grandchild_pid == -1)
    return; /* child is already dead, or we're so hosed we'll never recover */

  kill (sitter->grandchild_pid, SIGKILL);
}

/**
 * Checks whether the child has exited, without blocking.
 *
 * @param sitter the babysitter
 */
dbus_bool_t
_dbus_babysitter_get_child_exited (DBusBabysitter *sitter)
{

  /* Be sure we're up-to-date */
  while (LIVE_CHILDREN (sitter) &&
         babysitter_iteration (sitter, FALSE))
    ;

  /* We will have exited the babysitter when the child has exited */
735
  return sitter->socket_to_babysitter.fd < 0;
736 737
}

738
/**
739 740 741 742 743 744
 * Gets the exit status of the child. We do this so implementation specific
 * detail is not cluttering up dbus, for example the system launcher code.
 * This can only be called if the child has exited, i.e. call
 * _dbus_babysitter_get_child_exited(). It returns FALSE if the child
 * did not return a status code, e.g. because the child was signaled
 * or we failed to ever launch the child in the first place.
745 746 747 748 749 750
 *
 * @param sitter the babysitter
 * @param status the returned status code
 * @returns #FALSE on failure
 */
dbus_bool_t
751 752
_dbus_babysitter_get_child_exit_status (DBusBabysitter *sitter,
                                        int            *status)
753 754 755
{
  if (!_dbus_babysitter_get_child_exited (sitter))
    _dbus_assert_not_reached ("Child has not exited");
756

757 758 759
  if (!sitter->have_child_status ||
      !(WIFEXITED (sitter->status)))
    return FALSE;
760

761
  *status = WEXITSTATUS (sitter->status);
762 763 764
  return TRUE;
}

765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788
/**
 * Sets the #DBusError with an explanation of why the spawned
 * child process exited (on a signal, or whatever). If
 * the child process has not exited, does nothing (error
 * will remain unset).
 *
 * @param sitter the babysitter
 * @param error an error to fill in
 */
void
_dbus_babysitter_set_child_exit_error (DBusBabysitter *sitter,
                                       DBusError      *error)
{
  if (!_dbus_babysitter_get_child_exited (sitter))
    return;

  /* Note that if exec fails, we will also get a child status
   * from the babysitter saying the child exited,
   * so we need to give priority to the exec error
   */
  if (sitter->have_exec_errnum)
    {
      dbus_set_error (error, DBUS_ERROR_SPAWN_EXEC_FAILED,
                      "Failed to execute program %s: %s",
789
                      sitter->log_name, _dbus_strerror (sitter->errnum));
790 791 792 793 794
    }
  else if (sitter->have_fork_errnum)
    {
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY,
                      "Failed to fork a new process %s: %s",
795
                      sitter->log_name, _dbus_strerror (sitter->errnum));
796 797 798 799 800 801
    }
  else if (sitter->have_child_status)
    {
      if (WIFEXITED (sitter->status))
        dbus_set_error (error, DBUS_ERROR_SPAWN_CHILD_EXITED,
                        "Process %s exited with status %d",
802
                        sitter->log_name, WEXITSTATUS (sitter->status));
803 804 805
      else if (WIFSIGNALED (sitter->status))
        dbus_set_error (error, DBUS_ERROR_SPAWN_CHILD_SIGNALED,
                        "Process %s received signal %d",
806
                        sitter->log_name, WTERMSIG (sitter->status));
807 808 809
      else
        dbus_set_error (error, DBUS_ERROR_FAILED,
                        "Process %s exited abnormally",
810
                        sitter->log_name);
811 812 813 814 815
    }
  else
    {
      dbus_set_error (error, DBUS_ERROR_FAILED,
                      "Process %s exited, reason unknown",
816
                      sitter->log_name);
817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847
    }
}

/**
 * Sets watch functions to notify us when the
 * babysitter object needs to read/write file descriptors.
 *
 * @param sitter the babysitter
 * @param add_function function to begin monitoring a new descriptor.
 * @param remove_function function to stop monitoring a descriptor.
 * @param toggled_function function to notify when the watch is enabled/disabled
 * @param data data to pass to add_function and remove_function.
 * @param free_data_function function to be called to free the data.
 * @returns #FALSE on failure (no memory)
 */
dbus_bool_t
_dbus_babysitter_set_watch_functions (DBusBabysitter            *sitter,
                                      DBusAddWatchFunction       add_function,
                                      DBusRemoveWatchFunction    remove_function,
                                      DBusWatchToggledFunction   toggled_function,
                                      void                      *data,
                                      DBusFreeFunction           free_data_function)
{
  return _dbus_watch_list_set_functions (sitter->watches,
                                         add_function,
                                         remove_function,
                                         toggled_function,
                                         data,
                                         free_data_function);
}

848 849 850 851
static dbus_bool_t
handle_watch (DBusWatch       *watch,
              unsigned int     condition,
              void            *data)
852
{
853
  DBusBabysitter *sitter = _dbus_babysitter_ref (data);
854 855
  int revents;
  int fd;
856

857 858 859 860 861 862 863 864
  revents = 0;
  if (condition & DBUS_WATCH_READABLE)
    revents |= _DBUS_POLLIN;
  if (condition & DBUS_WATCH_ERROR)
    revents |= _DBUS_POLLERR;
  if (condition & DBUS_WATCH_HANGUP)
    revents |= _DBUS_POLLHUP;

865
  fd = dbus_watch_get_socket (watch);
866 867 868

  if (fd == sitter->error_pipe_from_child)
    handle_error_pipe (sitter, revents);
869
  else if (fd == sitter->socket_to_babysitter.fd)
870
    handle_babysitter_socket (sitter, revents);
871 872 873 874

  while (LIVE_CHILDREN (sitter) &&
         babysitter_iteration (sitter, FALSE))
    ;
875

876 877
  /* fd.o #32992: if the handle_* methods closed their sockets, they previously
   * didn't always remove the watches. Check that we don't regress. */
878
  _dbus_assert (sitter->socket_to_babysitter.fd != -1 || sitter->sitter_watch == NULL);
879
  _dbus_assert (sitter->error_pipe_from_child != -1 || sitter->error_watch == NULL);
880

881 882 883 884 885 886 887
  if (_dbus_babysitter_get_child_exited (sitter) &&
      sitter->finished_cb != NULL)
    {
      sitter->finished_cb (sitter, sitter->finished_data);
      sitter->finished_cb = NULL;
    }

888
  _dbus_babysitter_unref (sitter);
889 890 891
  return TRUE;
}

892
/** Helps remember which end of the pipe is which */
893
#define READ_END 0
894
/** Helps remember which end of the pipe is which */
895 896 897
#define WRITE_END 1


898 899 900 901 902 903 904 905
/* Avoids a danger in re-entrant situations (calling close()
 * on a file descriptor twice, and another module has
 * re-opened it since the first close).
 *
 * This previously claimed to be relevant for threaded situations, but by
 * trivial inspection, it is not thread-safe. It doesn't actually
 * matter, since this module is only used in the -util variant of the
 * library, which is only used in single-threaded situations.
906 907 908 909 910 911 912 913 914 915
 */
static int
close_and_invalidate (int *fd)
{
  int ret;

  if (*fd < 0)
    return -1;
  else
    {
916
      ret = _dbus_close (*fd, NULL);
917 918 919 920 921 922 923
      *fd = -1;
    }

  return ret;
}

static dbus_bool_t
924 925
make_pipe (int         p[2],
           DBusError  *error)
926
{
927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942
  int retval;

#ifdef HAVE_PIPE2
  dbus_bool_t cloexec_done;

  retval = pipe2 (p, O_CLOEXEC);
  cloexec_done = retval >= 0;

  /* Check if kernel seems to be too old to know pipe2(). We assume
     that if pipe2 is available, O_CLOEXEC is too.  */
  if (retval < 0 && errno == ENOSYS)
#endif
    {
      retval = pipe(p);
    }

943
  _DBUS_ASSERT_ERROR_IS_CLEAR (error);
944 945

  if (retval < 0)
946 947 948 949
    {
      dbus_set_error (error,
		      DBUS_ERROR_SPAWN_FAILED,
		      "Failed to create pipe for communicating with child process (%s)",
950
		      _dbus_strerror (errno));
951 952
      return FALSE;
    }
953

954 955 956 957 958 959 960 961
#ifdef HAVE_PIPE2
  if (!cloexec_done)
#endif
    {
      _dbus_fd_set_close_on_exec (p[0]);
      _dbus_fd_set_close_on_exec (p[1]);
    }

962 963 964 965 966 967 968 969
  return TRUE;
}

static void
do_write (int fd, const void *buf, size_t count)
{
  size_t bytes_written;
  int ret;
970

971
  bytes_written = 0;
972

973
 again:
974

975 976 977 978 979 980 981 982
  ret = write (fd, ((const char*)buf) + bytes_written, count - bytes_written);

  if (ret < 0)
    {
      if (errno == EINTR)
        goto again;
      else
        {
983
          _dbus_warn ("Failed to write data to pipe!");
984
          exit (1); /* give up, we suck */
985 986
        }
    }
987
  else
988
    bytes_written += ret;
989

990 991
  if (bytes_written < count)
    goto again;
992 993
}

994 995
static void write_err_and_exit (int fd, int msg) _DBUS_GNUC_NORETURN;

996 997 998 999
static void
write_err_and_exit (int fd, int msg)
{
  int en = errno;
1000 1001 1002

  do_write (fd, &msg, sizeof (msg));
  do_write (fd, &en, sizeof (en));
1003

1004
  exit (1);
1005 1006
}

1007 1008
static void
write_pid (int fd, pid_t pid)
1009
{
1010
  int msg = CHILD_PID;
1011

1012 1013 1014
  do_write (fd, &msg, sizeof (msg));
  do_write (fd, &pid, sizeof (pid));
}
1015

1016 1017
static void write_status_and_exit (int fd, int status) _DBUS_GNUC_NORETURN;

1018 1019 1020 1021
static void
write_status_and_exit (int fd, int status)
{
  int msg = CHILD_EXITED;
1022

1023 1024
  do_write (fd, &msg, sizeof (msg));
  do_write (fd, &status, sizeof (status));
1025

1026
  exit (0);
1027 1028
}

1029 1030 1031 1032 1033 1034
static void do_exec (int                       child_err_report_fd,
                     char             * const *argv,
                     char             * const *envp,
                     DBusSpawnChildSetupFunc   child_setup,
                     void                     *user_data) _DBUS_GNUC_NORETURN;

1035 1036
static void
do_exec (int                       child_err_report_fd,
Simon McVittie's avatar
Simon McVittie committed
1037 1038
	 char             * const *argv,
	 char             * const *envp,
1039 1040 1041
	 DBusSpawnChildSetupFunc   child_setup,
	 void                     *user_data)
{
1042
#ifdef DBUS_ENABLE_EMBEDDED_TESTS
1043 1044 1045
  int i, max_open;
#endif

1046
  _dbus_verbose_reset ();
1047
  _dbus_verbose ("Child process has PID " DBUS_PID_FORMAT "\n",
1048
                 _dbus_getpid ());
1049

1050 1051 1052
  if (child_setup)
    (* child_setup) (user_data);

1053
#ifdef DBUS_ENABLE_EMBEDDED_TESTS
1054
  max_open = sysconf (_SC_OPEN_MAX);
1055

1056 1057 1058 1059
  for (i = 3; i < max_open; i++)
    {
      int retval;

1060 1061
      if (i == child_err_report_fd)
        continue;
1062

1063 1064 1065
      retval = fcntl (i, F_GETFD);

      if (retval != -1 && !(retval & FD_CLOEXEC))
1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081
        {
          char description[256] = { 0 };
          char proc_self_fd[256] = { 0 };
          size_t description_length = sizeof (description) - 1;

          snprintf (proc_self_fd, sizeof (proc_self_fd) - 1,
                    "/proc/self/fd/%d", i);
          proc_self_fd[sizeof (proc_self_fd) - 1] = '\0';

          if (readlink (proc_self_fd, description, description_length) <= 0)
            snprintf (description, sizeof (description) - 1, "(unknown)");

          description[sizeof (description) - 1] = '\0';
          _dbus_warn ("Fd %d \"%s\" did not have the close-on-exec flag set!",
                      i, description);
        }
1082 1083
    }
#endif
1084 1085 1086 1087 1088 1089 1090

  if (envp == NULL)
    {
      _dbus_assert (environ != NULL);

      envp = environ;
    }
1091

1092
  execve (argv[0], argv, envp);
1093

1094 1095 1096
  /* Exec failed */
  write_err_and_exit (child_err_report_fd,
                      CHILD_EXEC_FAILED);
1097 1098 1099 1100 1101 1102 1103 1104 1105
}

static void
check_babysit_events (pid_t grandchild_pid,
                      int   parent_pipe,
                      int   revents)
{
  pid_t ret;
  int status;
1106

1107 1108 1109
  do
    {
      ret = waitpid (grandchild_pid, &status, WNOHANG);
1110 1111 1112
      /* The man page says EINTR can't happen with WNOHANG,
       * but there are reports of it (maybe only with valgrind?)
       */
1113 1114
    }
  while (ret < 0 && errno == EINTR);
1115 1116 1117 1118

  if (ret == 0)
    {
      _dbus_verbose ("no child exited\n");
1119

1120 1121 1122 1123 1124
      ; /* no child exited */
    }
  else if (ret < 0)
    {
      /* This isn't supposed to happen. */
1125
      _dbus_warn ("unexpected waitpid() failure in check_babysit_events(): %s",
1126
                  _dbus_strerror (errno));
1127
      exit (1);
1128 1129 1130 1131
    }
  else if (ret == grandchild_pid)
    {
      /* Child exited */
1132
      _dbus_verbose ("reaped child pid %ld\n", (long) ret);
1133

1134 1135 1136 1137
      write_status_and_exit (parent_pipe, status);
    }
  else
    {
1138
      _dbus_warn ("waitpid() reaped pid %d that we've never heard of",
1139
                  (int) ret);
1140
      exit (1);
1141 1142 1143 1144
    }

  if (revents & _DBUS_POLLIN)
    {
1145
      _dbus_verbose ("babysitter got POLLIN from parent pipe\n");
1146 1147 1148 1149 1150
    }

  if (revents & (_DBUS_POLLERR | _DBUS_POLLHUP))
    {
      /* Parent is gone, so we just exit */
1151
      _dbus_verbose ("babysitter got POLLERR or POLLHUP from parent\n");
1152
      exit (0);
1153 1154 1155 1156 1157 1158 1159 1160
    }
}

static int babysit_sigchld_pipe = -1;

static void
babysit_signal_handler (int signo)
{
1161 1162 1163
  /* Signal handlers that might set errno must save and restore the errno
   * that the interrupted function might have been relying on. */
  int saved_errno = errno;
1164
  char b = '\0';
1165

1166
 again:
1167
  if (write (babysit_sigchld_pipe, &b, 1) <= 0)
1168 1169
    if (errno == EINTR)
      goto again;
1170 1171

  errno = saved_errno;
1172 1173
}

1174 1175 1176
static void babysit (pid_t grandchild_pid,
                     int   parent_pipe) _DBUS_GNUC_NORETURN;

1177 1178 1179
static void
babysit (pid_t grandchild_pid,
         int   parent_pipe)
1180
{
1181 1182
  int sigchld_pipe[2];

1183 1184 1185 1186
  /* We don't exec, so we keep parent state, such as the pid that
   * _dbus_verbose() uses. Reset the pid here.
   */
  _dbus_verbose_reset ();
1187

1188 1189 1190 1191 1192 1193 1194
  /* I thought SIGCHLD would just wake up the poll, but
   * that didn't seem to work, so added this pipe.
   * Probably the pipe is more likely to work on busted
   * operating systems anyhow.
   */
  if (pipe (sigchld_pipe) < 0)
    {
1195
      _dbus_warn ("Not enough file descriptors to create pipe in babysitter process");
1196
      exit (1);
1197 1198 1199
    }

  babysit_sigchld_pipe = sigchld_pipe[WRITE_END];
1200 1201

  _dbus_set_signal_handler (SIGCHLD, babysit_signal_handler);
1202

1203 1204 1205 1206 1207 1208 1209
  write_pid (parent_pipe, grandchild_pid);

  check_babysit_events (grandchild_pid, parent_pipe, 0);

  while (TRUE)
    {
      DBusPollFD pfds[2];
1210

1211 1212 1213 1214 1215 1216 1217
      pfds[0].fd = parent_pipe;
      pfds[0].events = _DBUS_POLLIN;
      pfds[0].revents = 0;

      pfds[1].fd = sigchld_pipe[READ_END];
      pfds[1].events = _DBUS_POLLIN;
      pfds[1].revents = 0;
1218

1219 1220
      if (_dbus_poll (pfds, _DBUS_N_ELEMENTS (pfds), -1) < 0 && errno != EINTR)
        {
1221
          _dbus_warn ("_dbus_poll() error: %s", strerror (errno));
1222 1223
          exit (1);
        }
1224 1225 1226 1227 1228 1229 1230 1231

      if (pfds[0].revents != 0)
        {
          check_babysit_events (grandchild_pid, parent_pipe, pfds[0].revents);
        }
      else if (pfds[1].revents & _DBUS_POLLIN)
        {
          char b;
1232
          if (read (sigchld_pipe[READ_END], &b, 1) == -1)
1233 1234 1235
            {
              /* ignore */
            }
1236 1237 1238 1239
          /* do waitpid check */
          check_babysit_events (grandchild_pid, parent_pipe, 0);
        }
    }
1240

1241
  exit (1);
1242 1243 1244
}

/**
1245 1246 1247 1248 1249 1250 1251 1252
 * Spawns a new process.
 *
 * On Unix platforms, the child_setup function is passed the given
 * user_data and is run in the child after fork() but before calling exec().
 * This can be used to change uid, resource limits and so on.
 * On Windows, this functionality does not fit the multi-processing model
 * (Windows does the equivalent of fork() and exec() in a single API call),
 * and the child_setup function and its user_data are ignored.
1253
 *
1254 1255 1256 1257
 * Also creates a "babysitter" which tracks the status of the
 * child process, advising the parent if the child exits.
 * If the spawn fails, no babysitter is created.
 * If sitter_p is #NULL, no babysitter is kept.
1258
 *
1259
 * @param sitter_p return location for babysitter or #NULL
1260
 * @param log_name the name under which to log messages about this process being spawned
1261
 * @param argv the executable and arguments
1262
 * @param env the environment, or #NULL to copy the parent's
1263 1264 1265 1266 1267 1268
 * @param child_setup function to call in child pre-exec()
 * @param user_data user data for setup function
 * @param error error object to be filled in if function fails
 * @returns #TRUE on success, #FALSE if error is filled in
 */
dbus_bool_t
1269
_dbus_spawn_async_with_babysitter (DBusBabysitter          **sitter_p,
1270
                                   const char               *log_name,
Simon McVittie's avatar
Simon McVittie committed
1271
                                   char             * const *argv,
1272
                                   char                    **env,
1273
                                   DBusSpawnFlags            flags,
1274 1275 1276
                                   DBusSpawnChildSetupFunc   child_setup,
                                   void                     *user_data,
                                   DBusError                *error)
1277
{
1278
  DBusBabysitter *sitter;
1279
  int child_err_report_pipe[2] = { -1, -1 };
1280
  DBusSocket babysitter_pipe[2] = { DBUS_SOCKET_INIT, DBUS_SOCKET_INIT };
1281
  pid_t pid;
1282 1283
  int fd_out = -1;
  int fd_err = -1;
1284

1285
  _DBUS_ASSERT_ERROR_IS_CLEAR (error);
1286
  _dbus_assert (argv[0] != NULL);
1287

1288 1289 1290
  if (sitter_p != NULL)
    *sitter_p = NULL;

1291 1292 1293 1294 1295 1296 1297 1298 1299
  sitter = NULL;

  sitter = _dbus_babysitter_new ();
  if (sitter == NULL)
    {
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      return FALSE;
    }

1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310
  sitter->log_name = _dbus_strdup (log_name);
  if (sitter->log_name == NULL && log_name != NULL)
    {
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      goto cleanup_and_fail;
    }

  if (sitter->log_name == NULL)
    sitter->log_name = _dbus_strdup (argv[0]);

  if (sitter->log_name == NULL)
1311 1312 1313 1314
    {
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      goto cleanup_and_fail;
    }
1315

1316
  if (!make_pipe (child_err_report_pipe, error))
1317 1318
    goto cleanup_and_fail;

1319
  if (!_dbus_socketpair (&babysitter_pipe[0], &babysitter_pipe[1], TRUE, error))
1320
    goto cleanup_and_fail;
1321

1322 1323 1324 1325 1326 1327 1328
  /* Setting up the babysitter is only useful in the parent,
   * but we don't want to run out of memory and fail
   * after we've already forked, since then we'd leak
   * child processes everywhere.
   */
  sitter->error_watch = _dbus_watch_new (child_err_report_pipe[READ_END],
                                         DBUS_WATCH_READABLE,
1329
                                         TRUE, handle_watch, sitter, NULL);
1330 1331 1332 1333 1334
  if (sitter->error_watch == NULL)
    {
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      goto cleanup_and_fail;
    }
1335

1336 1337
  if (!_dbus_watch_list_add_watch (sitter->watches,  sitter->error_watch))
    {
1338 1339 1340 1341 1342 1343
      /* we need to free it early so the destructor won't try to remove it
       * without it having been added, which DBusLoop doesn't allow */
      _dbus_watch_invalidate (sitter->error_watch);
      _dbus_watch_unref (sitter->error_watch);
      sitter->error_watch = NULL;

1344 1345 1346
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      goto cleanup_and_fail;
    }
1347

1348
  sitter->sitter_watch = _dbus_watch_new (babysitter_pipe[0].fd,
1349
                                          DBUS_WATCH_READABLE,
1350
                                          TRUE, handle_watch, sitter, NULL);
1351 1352 1353 1354 1355
  if (sitter->sitter_watch == NULL)
    {
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      goto cleanup_and_fail;
    }
1356

1357 1358
  if (!_dbus_watch_list_add_watch (sitter->watches,  sitter->sitter_watch))
    {
1359 1360 1361 1362 1363 1364
      /* we need to free it early so the destructor won't try to remove it
       * without it having been added, which DBusLoop doesn't allow */
      _dbus_watch_invalidate (sitter->sitter_watch);
      _dbus_watch_unref (sitter->sitter_watch);
      sitter->sitter_watch = NULL;

1365 1366 1367 1368 1369
      dbus_set_error (error, DBUS_ERROR_NO_MEMORY, NULL);
      goto cleanup_and_fail;
    }

  _DBUS_ASSERT_ERROR_IS_CLEAR (error);
1370

1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
  if (flags & DBUS_SPAWN_SILENCE_OUTPUT)
    {
      fd_out = open ("/dev/null", O_RDONLY);

      if (fd_out < 0)
        {
          dbus_set_error (error, _dbus_error_from_errno (errno),
                          "Failed to open /dev/null: %s",
                          _dbus_strerror (errno));
          goto cleanup_and_fail;
        }

      _dbus_fd_set_close_on_exec (fd_out);

      fd_err = _dbus_dup (fd_out, error);

      if (fd_err < 0)
        goto cleanup_and_fail;
    }
1390
#ifdef HAVE_SYSTEMD
1391
  else if (flags & DBUS_SPAWN_REDIRECT_OUTPUT)
1392 1393 1394 1395 1396 1397 1398 1399
    {
      /* This may fail, but it's not critical.
       * In particular, if we were compiled with journald support but are now
       * running on a non-systemd system, this is going to fail, so we
       * have to cope gracefully. */
      fd_out = sd_journal_stream_fd (sitter->log_name, LOG_INFO, FALSE);
      fd_err = sd_journal_stream_fd (sitter->log_name, LOG_WARNING, FALSE);
    }
1400 1401
#endif

1402 1403 1404 1405 1406
  /* Make sure our output buffers aren't redundantly printed by both the
   * parent and the child */
  fflush (stdout);
  fflush (stderr);

1407
  pid = fork ();
1408

1409 1410 1411 1412 1413
  if (pid < 0)
    {
      dbus_set_error (error,
		      DBUS_ERROR_SPAWN_FORK_FAILED,
		      "Failed to fork (%s)",
1414 1415
		      _dbus_strerror (errno));
      goto cleanup_and_fail;
1416 1417 1418
    }
  else if (pid == 0)
    {
1419 1420
      /* Immediate child, this is the babysitter process. */
      int grandchild_pid;
1421

1422 1423 1424 1425 1426
      /* Be sure we crash if the parent exits
       * and we write to the err_report_pipe
       */
      signal (SIGPIPE, SIG_DFL);

1427 1428
      /* Close the parent's end of the pipes. */
      close_and_invalidate (&child_err_report_pipe[READ_END]);
1429
      close_and_invalidate (&babysitter_pipe[0].fd);
1430 1431 1432 1433

      fflush (stdout);
      fflush (stderr);

1434
      /* Create the child that will exec () */
1435
      grandchild_pid = fork ();
1436

1437 1438
      if (grandchild_pid < 0)
	{
1439
	  write_err_and_exit (babysitter_pipe[1].fd,
1440 1441
			      CHILD_FORK_FAILED);
          _dbus_assert_not_reached ("Got to code after write_err_and_exit()");
1442 1443
	}
      else if (grandchild_pid == 0)
1444
      {
1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460
#ifdef __linux__
          int fd = -1;

#ifdef O_CLOEXEC
          fd = open ("/proc/self/oom_score_adj", O_WRONLY | O_CLOEXEC);
#endif

          if (fd < 0)
            {
              fd = open ("/proc/self/oom_score_adj", O_WRONLY);
              _dbus_fd_set_close_on_exec (fd);
            }

          if (fd >= 0)
            {
              if (write (fd, "0", sizeof (char)) < 0)
1461
                _dbus_warn ("writing oom_score_adj error: %s", strerror (errno));
1462 1463 1464
              _dbus_close (fd, NULL);
            }
#endif
1465
          /* Go back to ignoring SIGPIPE, since it's evil
1466
           */
1467 1468
          signal (SIGPIPE, SIG_IGN);

1469
          close_and_invalidate (&babysitter_pipe[1].fd);
1470 1471 1472

          /* Redirect stdout, stderr to systemd Journal or /dev/null
           * as requested, if possible */
1473 1474 1475 1476 1477 1478
	  if (fd_out >= 0)
            dup2 (fd_out, STDOUT_FILENO);
	  if (fd_err >= 0)
            dup2 (fd_err, STDERR_FILENO);
          close_and_invalidate (&fd_out);
          close_and_invalidate (&fd_err);
1479

1480
	  do_exec (child_err_report_pipe[WRITE_END],
1481
		   argv,
1482
		   env,
1483
		   child_setup, user_data);
1484
          _dbus_assert_not_reached ("Got to code after exec() - should have exited on error");
1485 1486 1487
	}
      else
	{
1488
          close_and_invalidate (&child_err_report_pipe[WRITE_END]);
1489 1490
          close_and_invalidate (&fd_out);
          close_and_invalidate (&fd_err);
1491
          babysit (grandchild_pid, babysitter_pipe[1].fd);
1492
          _dbus_assert_not_reached ("Got to code after babysit()");
1493 1494 1495
	}
    }
  else
1496
    {
1497
      /* Close the uncared-about ends of the pipes */
1498
      close_and_invalidate (&child_err_report_pipe[WRITE_END]);
1499
      close_and_invalidate (&babysitter_pipe[1].fd);
1500 1501
      close_and_invalidate (&fd_out);
      close_and_invalidate (&fd_err);
1502

1503
      sitter->socket_to_babysitter = babysitter_pipe[0];
1504
      babysitter_pipe[0].fd = -1;
1505

1506 1507
      sitter->error_pipe_from_child = child_err_report_pipe[READ_END];
      child_err_report_pipe[READ_END] = -1;
1508

1509
      sitter->sitter_pid = pid;
1510

1511 1512 1513 1514
      if (sitter_p != NULL)
        *sitter_p = sitter;
      else
        _dbus_babysitter_unref (sitter);
1515

1516 1517
      dbus_free_string_array (env);

1518
      _DBUS_ASSERT_ERROR_IS_CLEAR (error);
1519

1520 1521 1522 1523 1524
      return TRUE;
    }

 cleanup_and_fail:

1525
  _DBUS_ASSERT_ERROR_IS_SET (error);
1526

1527 1528
  close_and_invalidate (&child_err_report_pipe[READ_END]);
  close_and_invalidate (&child_err_report_pipe[WRITE_END]);
1529 1530
  close_and_invalidate (&babysitter_pipe[0].fd);
  close_and_invalidate (&babysitter_pipe[1].fd);
1531 1532
  close_and_invalidate (&fd_out);
  close_and_invalidate (&fd_err);
<