Skip to content

bus/desktop-file.c: Fix incorrect logic for excluding invalid group names in…

Ralf Habacker requested to merge rhabacker/dbus:230-fix-logic-failure into master

bus/desktop-file.c: Fix incorrect logic for excluding invalid group names in is_valid_section_name()

According to the specification, group names in desktop files may contain all ASCII characters except '[' and ']' and control characters. The previous check is incorrect and has been fixed with this commit.

This error was found by the compiler check -Werror=logical-op with the message "Logical 'or' of collectively comprehensive tests is always true".

Fixes: #230 (closed) Signed-off-by: Ralf Habacker ralf.habacker@freenet.de

Closes #230 (closed)

Merge request reports