tests for OOM behaviour are skipped on Windows with CMake but not Autotools
% git grep DBUS_WIN_FIXME
README.win:- the code wrapped with DBUS_WIN_FIXME should be inspected if it required for windows
bus/dispatch.c:#ifdef DBUS_WIN_FIXME
cmake/config.h.cmake:# define DBUS_WIN_FIXME 1
dbus/dbus-memory.c:#ifdef DBUS_WIN_FIXME
cmake/config.h.cmake is only used under CMake, not Autotools.
The practical result is that:
-
The test for GetConnectionUnixProcessID is skipped when built for Windows with CMake, but not when built for Windows with Autotools. This is certainly wrong: GetConnectionUnixProcessID() is a cross-platform feature now, so we should fix that test so that it can pass on Windows (which I think !55 (merged) does) and enable it everywhere.
-
The tests for what happens when malloc() returns NULL are skipped when built for Windows with CMake, but not when built for Windows with Autotools. We should decide whether libdbus on Windows aims to be robust against out-of-memory conditions.
- If it does, we should run these tests, even though they're slow (you can temporarily skip them for quicker testing with the
DBUS_TEST_MALLOC_FAILURES
environment variable). - If it doesn't, we should probably make
dbus_malloc()
and friends abort on out-of-memory, like GLib's equivalents do, when running on Windows.
- If it does, we should run these tests, even though they're slow (you can temporarily skip them for quicker testing with the