sysdeps: use POSIX poll.h instead of sys/poll.h

See merge request !148

_dbus_generate_random_bytes: fallback to getrandom(2)

See merge request !147

POSIX.1-2001 and POSIX.1-2008 specifies include <poll.h> so use that
rather than the non-standard/legacy include <sys/poll.h>.

This fixes the following warnings when building with musl libc:

    1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
      |  ^~~~~~~
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>

Use getrandom(2) and fall back to /dev/urandom if it is missing or if it
fails some any reason.

This solves problem where dbus-uuidgen is called from a chroot which
lacks /dev/urandom.
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>

Fix indentation in bus source file

See merge request !149

sysdeps-win: Refactor cleanup of struct addrinfo during connect()

See merge request !145

Remove support for non-POSIX getpwnam_r()

See merge request !11

sysdeps-unix: Don't leak struct addrinfo on OOM during connect()

See merge request !144

As suggested on !143. Instead of remembering to free it in every error
condition, let's move its cleanup to the "out" phase so that it's done
every time.

Change the iterator variable tmp to be const so that it's obvious we
aren't meant to free that too.
Signed-off-by: Simon McVittie <smcv@collabora.com>

If we ran out of memory while handling connect() errors, we didn't
free the linked list of struct addrinfo. Move their cleanup to the
"out" phase of the function so that we always do it.

While I'm there, change the iterator variable tmp to be const, to make
it more obvious that we aren't meant to free it.

This is similar to commit 00badeba (!143) in the corresponding Windows
code path, but with some refactoring.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Fix missing release of the memory allocated in _dbus_connect_tcp_socket_with_nonce() in OOM case

See merge request !143

If there is no more memory available within the mentiond function, e.g.,
when checking memory management, the release of memory allocated by
getaddrinfo() is missing.

Coverity CID: 354880

bus: Don't explicitly clear BusConnections.monitors

Closes #291

See merge request !140

Fix cmake doc build

See merge request !137

Previously this would be attempted whenever xsltproc was found, but
would fail if Doxygen documentation was disabled.

Signed-off-by: Simon McVittie <smcv@collabora.com>

Each connection that is an active monitor holds a pointer to its own
link in this list, via BusConnectionData.link_in_monitors. We can't
validly free the list while these pointers exist: that would be a
use-after-free, when each connection gets disconnected and tries to
remove itself from the list.

Instead, let each connection remove itself from the list, then assert
that the list has become empty.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: #291

In _dbus_verbose_real() use DBusString instance to avoid possible stack smashing

Closes #45

See merge request !133

Instead of creating a fixed memory area on the stack that can lead to
a stack overflow if exceeded, this configuration now uses a DBusString
instance that dynamically manages memory.

Resolves: #45

Transcoding template file for version information under Windows to utf-8

See merge request !139

Fix libdbus version info

See merge request !138

The 'original filename' attribute was 'libdbus-1-3}.dll' with an unwanted
curly bracket.

cmake: complete adding version info to all installed executables on Windows

See merge request !136

cmake: add X11 include directories to tools

See merge request !129

Fixes compilation issues for case when X11 is not in a standard location

Fix static vars thread safety issues

Related to #88

See merge request !132

This doesn't verify that they're atomic, but does verify that they
return the right things.

This commit adds a new test function _dbus_test_check (a) to make
writing tests easier. It checks the given boolean expression and
generates a "not ok" test result if the expression is false.

Due to the current design of the test api, the test is only compiled
if embedded tests were enabled at the time of configuration.

It was also necessary to move the test_atomic target definitions in
test/Makefile.am to the --enable-embedded-tests section to avoid a
make distcheck build error.

The test case itself has been authored by smcv.
Co-authored-by: Simon McVittie <smcv@collabora.com>

This needs new atomic primitives: we don't have "set to a value",
and in fact that's a bit annoying to implement in terms of gcc
intrinsics. "Set to 0" and "set to nonzero" are easy, though.

Stop using selinux_set_mapping() function

Closes #198

See merge request !128

Currently, if the "dbus" security class or the associated AV doesn't
exist, dbus-daemon fails to initialize and exits immediately. Also the
security classes or access vector cannot be reordered in the policy.
This can be a problem for people developing their own policy or trying
to access a machine where, for some reasons, there is not policy defined
at all.

The code here copy the behaviour of the selinux_check_access() function.
We cannot use this function here as it doesn't allow us to define the
AVC entry reference.

See the discussion at https://marc.info/?l=selinux&m=152163374332372&w=2

Resolves: #198

doxygen: fix example for dbus_message_append_args

See merge request !126

Commit 724adb2f mangled the dbus_message_append_args() code example.
This fixes it by breaking the lines and aligning at the right places.
Signed-off-by: Felipe Franciosi <felipe@nutanix.com>

doc: Fix environment variable name in dbus-daemon(1)

Closes #275

See merge request !122

Spotted by Mubin. This documentation relates to the code in
add_bus_environment() in bus/activation.c.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
Fixes: #275

dbus-send: add --sender option

See merge request !116