Add a FreeBSD CI job

See merge request !280

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

Also bump the FDO_DISTRIBUTION_TAG to ensure the disk images
include meson.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

Python is already installed, but we need the python3 package to get the
/usr/local/bin/python3 symlink rather than the one with the version suffix.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

The /odd-limit/at test passes on 13.1 and 14.0 images, but fails on 13.1.
Debugging has not given me any useful hints why this may be the case, so
disable this test on 13.0 for now.

This allows us to drop the ci_test_fatal: "no" override which will ensure
that any FreeBSD regressions are caught.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

Now that the underlying issues with FreeBSD autotools CI have been fixed,
we can add a CI job to prevent future regressions.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

This is needed to add autotools support to the FreeBSD CI since we don't
include all the packages needed to build dbus-docs.tar.xz.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

The Makefile.am files contain % pattern rules that are not supported by
`make` (bmake) on FreeBSD. Since the replacing the patterns is non-trivial,
this commit updates the CI script to use GNU make when building on FreeBSD.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

We are already building as root and sudo is not currently installed on
the CI image, so the autotools build fails without this change.

Alexander Richardson authored Aug 08, 2022 and Simon McVittie committed Aug 10, 2022

Without this change the autotools build system fails to find glib and
reports an error. The CMake build worked prior to this change since CMake
has fallback logic to find glib even without pkg-config.

Alexander Richardson authored May 25, 2022 and Simon McVittie committed Aug 10, 2022

This uses https://gitlab.freedesktop.org/freedesktop/ci-templates,
and runs the FreeBSD build+test inside a QEMU VM.
This depends on the recently merged ci-templates MR
freedesktop/ci-templates!142,
so we bump the required ci-templates commit hash.

There is one undiagnosed failure in test-fdpass that needs investigation,
so for now failures are permitted. Autotools and meson jobs will be added
in follow-up commits.

Alexander Richardson authored Aug 09, 2022 and Simon McVittie committed Aug 10, 2022

This header is GCC specific header that on my system just contains
`#include_next <limits.h>`. FreeBSD also provides this header but it
contains a `#warning` that it should not be used. Replace the one use
with `#include <limit.h>` and drop the configure checks.

Alexander Richardson authored May 29, 2022 and Simon McVittie committed Aug 10, 2022

Commit 97bdefd4 move the
include(FindPkgConfig) call into a Linux-specific codepath, so pkg-config
was not being detected on FreeBSD. This mean that the check for
PKG_CONFIG_FOUND to determine whether to install .pc files later on
would always fail and .pc files were not installed on FreeBSD.

Alexander Richardson authored Aug 08, 2022 and Simon McVittie committed Aug 10, 2022

In this case the cast is safe since the manual guarantees that the
underlying storage is an array of `long`.

Alexander Richardson authored Aug 08, 2022 and Simon McVittie committed Aug 10, 2022

Add a conditional _DBUS_GNUC_NORETURN to avoid
`error: function 'back_to_root' could be declared with attribute 'noreturn'`

Alexander Richardson authored Aug 08, 2022 and Simon McVittie committed Aug 10, 2022

ENODATA is not available on FreeBSD. Since the actual errno value here
does not matter, use EPERM instead.
This fixes the DBus build on FreeBSD.

Alexander Richardson authored Aug 08, 2022 and Simon McVittie committed Aug 10, 2022

The function close_ignore_error() is only used in some cases. To avoid
duplicating the #ifdef condition, this patch moves the check just before
the definition of _dbus_close_all().

Alexander Richardson authored Aug 08, 2022 and Simon McVittie committed Aug 10, 2022

When adding the new FreeBSD CI, this was not implicitly forwarded to QEMU,
so the build script failed with confusing errors. Add an explicit check
that the variable is set to make those cases easier to debug.

Alexander Richardson authored May 25, 2022 and Simon McVittie committed Aug 10, 2022

This adds support for installing the required packages on FreeBSD.

Alexander Richardson authored May 25, 2022 and Simon McVittie committed Aug 10, 2022

FreeBSD has bash installed as /usr/local/bin/bash, so hardcoding /bin/bash
does not work. Instead use the portable replacement using env which will
find bash in $PATH.

meson: Only require C++ compiler when building for Windows

See merge request !333

dbus is generally a C-only project, but the Windows side has a tiny
amount of C++ to initialize global locks (because Windows doesn't have
a direct equivalent of PTHREAD_MUTEX_INITIALIZER). We don't need a C++
compiler when building for a non-Windows OS, so there's no need to
find it or check which options it supports.
Signed-off-by: Simon McVittie <smcv@collabora.com>

!332

 increased the CMake dependency.

The Meson build system is new, but it seems reasonable to mention the
new (optional) dependencies at top level.
Signed-off-by: Simon McVittie <smcv@collabora.com>

cmake: Fix top-level directory references when vendored into a larger project

See merge request !332

This makes it possible for projects to incorporate D-Bus as a CMake sub-project in a larger CMake project.
Before this PR, doing so would result in many errors.
This is because CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR would point to directories above the D-Bus project.
Using paths relative to the project directory, PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR, corrects for this.

With the minimum version set to 3.4, none of the policies need to be set explicitly to the `NEW` behavior.
Each of the policies removed here was introduced before CMake version 3.4.
By default then, each of them will be set to NEW automatically.
This is part of the behavior of cmake_minimum_required.
The cmake_policy commands are therefore redundant and have been removed.

Signed-off-by: Simon McVittie <smcv@collabora.com>

In other projects I've found that having a separate file that only
lists the release steps makes them easier to check.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Officially drop support for non-C99 compilers, and start using C99 low-hanging fruit

Closes #404

See merge request !331

We now require a (mostly-)C99 compiler, meaning we can rely on having
Standard C stdint.h.
Signed-off-by: Simon McVittie <smcv@collabora.com>

We now require a (mostly-)C99 compiler, which guarantees the presence
of these functions.
Signed-off-by: Simon McVittie <smcv@collabora.com>

We now require a mostly-C99 compiler like MSVC 2015, which provides
Standard C snprintf().
Signed-off-by: Simon McVittie <smcv@collabora.com>

dbus now requires a (mostly-)C99 compiler, which guarantees the presence
of Standard C va_copy().
Signed-off-by: Simon McVittie <smcv@collabora.com>

We now require a (mostly-)C99 compiler, and C99 guarantees the presence
of the inline keyword.
Signed-off-by: Simon McVittie <smcv@collabora.com>

We're considering MSVC 2015 to be sufficiently close to C99 for our
purposes, and we now have CI for it, so we can easily check whether any
desired C99 feature works. Other pre-C99 compilers are obsolete.

Resolves: #404

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

tests: Speed up bus-dispatch OOM testing by a factor of 30

See merge request !328