GitLab

dbus-send: Do more syntax validation

Closes #338

See merge request !211

Instead of a failed check or assertion failure and a core dump, let's
produce an error message on stderr and a graceful nonzero exit status.
It's still not going to *work*, but at least we can avoid crashing.

    $ dbus-send / com.example.Nope..Nope
    Interface name was not valid: 'com.example.Nope.'
    $ dbus-send / com.example.Nope.0
    Invalid signal name: Member name was not valid: '0'

Resolves: #338

Signed-off-by: Simon McVittie <smcv@collabora.com>

    $ dbus-send // nope
    Object path was not valid: '//'

Related to #338

.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Add a few clarifications to the spec

See merge request !203

ci: bump msys2 deps, fix broken links

See merge request !201

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

cmake: add macro add_unit_test to reduce code duplication

See merge request !196

This macro is now used by add_test_executable and
add_session_test_executable.

Cleanup package installation on CI

See merge request !187

With this commit a new variable 'ci_local_packages' has been introduced
to have a choice for using development packages from a local installation
or from the distribution.

Otherwise, ci-build.sh cannot be executed on a local system if there
are previous runs.

This required a reorganization of the steps that had been carried out.
The new order is:
   1. install packages with apt-get
   2. create user for build if required
   3. fetch and unpack tar balls
   4. create messagebus user

In tools/ci-build.sh the cross compile setup has to be moved further up
to match the correct subdirectory.

sysdeps-win: Expand/fix verbose logging

See merge request !193

This is useful for tracking auto launch support in dbus-daemon.

bus/selinux: Fix audit message types.

See merge request !173

The SELinux log callback includes a message type. Not all messages are
auditable and those that are have varying audit types. An audit message is
a security-relevant event: security state changes, MAC permission denied,
etc.  A message that is auditable is not necessarily sensitive.  Messages
that are not auditable are not security-relevant, like messages about
socket polling errors.  Update the auditing accordingly.

If the message is not auditable, fall through and write it to syslog.
Signed-off-by: Chris PeBenito <chpebeni@linux.microsoft.com>

Drop unused travis CI configuration files

See merge request !197

NEWS: Add missing directory 'lib' to three paths

See merge request !182

Since ${localstatedir}/dbus should be ${localstatedir}/lib/dbus,
insert the missing directory 'lib' into the three erroneous paths.

dbus-launch: Replace slashes in DISPLAY if present

Closes #8 and #311

See merge request !180

dbus-daemon fails to autolaunch with X11 on macOS 10.8+ because XQuartz
(the X11 package for macOS) provides a value for `$DISPLAY` that is
not expected by dbus, in that it contains `/` characters. This is
addressed by replacing the invalid path character `/` with `_`.

Resolves: #8
Resolves: #311

sysdeps: Don't raise RLIMIT_NOFILE beyond OPEN_MAX on macOS

Closes #309

See merge request !178

dbus-daemon fails to launch on macOS 10.5 and above because of a breaking
change in setrlimit, in which RLIM_INFINITY is no longer supported
for RLIMIT_NOFILE. Instead we must use OPEN_MAX.

Resolves: #309

docs: generate reproducible ids

See merge request !189

With this parameter, docbook will generate the same id's when generating the
same docs. This is helpful to get bit-by-bit 'reproducible' output, which
makes auditing the package easier.

Tested both the cmake output and the automake output

ci-build: Update required MSYS packages

Closes #318

See merge request !190

The older versions we were previously building against are no longer
available on mirrors.

Based on changes proposed in !189 by Arnout Engelen, and the package
list gathered by Ralf Habacker in #318.

Resolves: #318

Signed-off-by: Simon McVittie <smcv@collabora.com>

doc: Fix typo in dbus-daemon(1)

See merge request !183

disable fork-malloc-exec for non-glibc-systems

See merge request !181

Calling malloc() after fork is undefined behaviour if the process is
multi-threaded. locks held by a thread on fork() will never be released.
malloc() is usally protected by a lock and can therefore deadlock. glibc
is known not to deadlock in this case.

This commit does not rule out other problems on glibc-systems, but fixes an
issue on musl-libc-systems. Only restricting to async-signal safe functions
between fork() and exec() prevents undefined behaviour for sure. See
signal-safety(7).

CMake: allow traditional activation to be disabled

See merge request !159

Traditional activation is enabled/disabled with the cmake configure
parameter -DENABLE_TRADITIONAL_ACTIVATION, which is enabled by default.

This was added to the Autotools build system as part of !107
but until now was not possible to disable when building with CMake.