GitLab

The two relevant tests already exit 0 with a message if importing those
modules fails.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37847Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

pkg-config is not a hard dependency, and this check avoids errors in a
minimal build environment:

./configure: line 21777: --variable=systemdsystemunitdir: command not found

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37847Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

We want to indicate why it's a problem that GLib, dbus-glib are missing.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37847Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

As with the optional test-dependencies on GLib and dbus-glib, we make this
a hard dependency if --enable-tests[=yes], but not if --enable-tests=auto.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=37847Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=11668Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39987Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39987Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Previously, it'd fail when done twice, because you can't rmdir a
nonexistent directory.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40004Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40235Tested-by: Dagobert Michelsen <dam@opencsw.org>
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

The STATIC_DOCS, DTDS and all dist_ files except XMLTO_OUTPUT are in the
source tree. The XMLTO_OUTPUT and the man2html output are in the build
tree, and the BONUS_FILES already have $(srcdir) in their names.

Also change the rules that generate the dbus-docs directory so that if
they fail, they leave behind a temporary directory, rather than leaving
behind a dbus-docs directory that causes make to not run those rules
if re-run; and change the rules to scp files to the server, to put a
trailing "/" on paths, ensuring that the tarball won't be uploaded as
"www" if the www directory doesn't already exist.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=41047Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40905

In commit ab7b3f92, Ralf notes that handle_reload_watch() is (in principle)
cross-platform. However, there's no way to trigger it on Windows, because
nothing ever writes to the pipe. Make the entire pipe-to-self trick
Unix-specific instead.
Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40002

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40313Reviewed-by: Thiago Macieira <thiago@kde.org>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

do {} while (0) isn't valid at file scope, so the non-gcc code path
was broken; in particular, this affected MSVC.
Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

diagram.png and diagram.svg are linked from dbus-tutorial.html but recent
changes to doc/Makefile.am mean that if htmldir is set with configure they are
installed such that the relative link from dbus-tutorial.html does not work.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

This fix is limited to msvc compilers only.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=40003Reviewed-by: Colin Walters <walters@verbum.org>

The __alignof__() checks here will fail if compiling for an architecture
where more-than-natural alignment is needed.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39636Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39636Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

This patch ensures the daemon process doesn't inherit any supplemental
groups for the root user from an administrator login via an init
script.

This is only an issue for pre-systemd systems.

https://bugzilla.redhat.com/show_bug.cgi?id=726953

See http://people.gnome.org/~walters/docs/build-api.txt

Some duplicates are there by accident mostly because of the git
learning curve (as in my case). Other duplicates could be outdated
and may be candidates for additional mappings.

msvc compilers define 'inline' only for c++ code, so wrap it
with a platform independent DBUS_INLINE define in cmake
generated config.h.

(The dbus-1.4 version.)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39836Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39836Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Our abstract socket names look like filenames (/tmp/dbus-MwozdykBNK or
whatever), so if we incorrectly unlink the abstract socket name, in
highly unlikely circumstances we could accidentally unlink a non-abstract
socket belonging to another process!

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=38656Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

On OSs with abstract sockets, this is close enough. On OSs without
abstract sockets, this results in failing to clean up Unix sockets
in /tmp if someone has sent us thousands of SIGHUP signals since we
last entered the main loop - I think that's acceptable.

The reload pipe should never get closed, but if it is for some reason,
we want a SIGTERM after that to cause an exit too.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=38656Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Backported to dbus-1.4, originally part of commit c7ef3ead.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33336Reviewed-by: Thiago Macieira <thiago@kde.org>

Signals are POSIX but not ISO C, so guard it with DBUS_UNIX.

dbus-sysdeps-util-win doesn't actually implement _dbus_set_signal_handler
anyway, so not compiling this code on non-Unix seems more honest.

Backported to dbus-1.4, originally part of commit c7ef3ead.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33336Reviewed-by: Thiago Macieira <thiago@kde.org>

Windows doesn't have it, for instance.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=38656Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=38656Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

If the C library is (e)glibc, this allows use of POSIX, BSD, SVID, GNU,
etc., extensions to ISO C, regardless of using -ansi or not.

Not doing this broke the cmake build on Linux since commit 18b08180,
which added AC_USE_SYSTEM_EXTENSIONS to configure.ac (and removed
_GNU_SOURCE from files that use it) without also updating the cmake
build system. SO_PEERCRED is defined unconditionally, but struct ucred
is considered to be a GNU extension, so can't be used under _GNU_SOURCE.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=29228Reviewed-by: Will Thompson <will.thompson@collabora.co.uk>