GitLab

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

dbus has never actually had this option.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

We no longer run man2html.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>
Fixes: e93b4211

Signed-off-by: Simon McVittie <smcv@collabora.com>
Fixes: b8057440

This gives us a way to build on a more recent host OS if we want to.
For Gitlab-CI it's disabled by default.
Signed-off-by: Simon McVittie <smcv@collabora.com>

The version of gcc in trusty is too old for AddressSanitizer, which we
want to be able to start using, and Travis-CI finally supports Ubuntu
16.04 'xenial' now. This lets us remove some workarounds, but we need
to update others.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

This is technically a denial of service because the dbus-daemon will
run out of memory eventually, but it's a very slow and noisy one,
because all the rejected messages are also very likely to have
been logged to the system log.

Detected by AddressSanitizer.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: #234
Reviewed-by: pwithnall

Signed-off-by: Simon McVittie <smcv@collabora.com>

test/dbus-daemon: Mark max-connections-per-user as unimplemented on Windows

See merge request !54

Reviewed-by: pwithnall
Reviewed-by: rhabacker

spec: Fix a typo in an ObjectManager example

Closes #221

See merge request !56

Reviewed-by: smcv

As spotted by Peter Bigot.

Closes #221Signed-off-by: Philip Withnall <withnall@endlessm.com>

This check is now possible because with merge request
 !55
the prerequisites are valid.

It was already run if built with Autotools, because DBUS_WIN_FIXME
was only defined in the CMake build system.

[smcv: Add more context regarding Autotools vs. CMake]
Signed-off-by: Simon McVittie <smcv@collabora.com>

bus test: Accept GetConnectionUnixProcessID() success on Windows

See merge request !55

Reviewed-by: pwithnall

Despite its name, which is a historical quirk, this is now a
generic cross-platform process ID on anything with the concept of
numbered processes. It appears it has actually worked on Windows
since dbus 1.7.x.

Bug: #239Signed-off-by: Simon McVittie <smcv@collabora.com>

The limit is accepted on Windows, but not enforced.
Signed-off-by: Simon McVittie <smcv@collabora.com>

The implementation of the max-connections-per-user limit works in terms
of Unix uids, so it doesn't apply on Windows.

This is not a problem in practice, because it only makes sense to limit
connections per user if you have multiple users, and we don't support
the well-known system bus on Windows.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Don't let dbus-daemon and its subprocesses inherit unnecessary fds

See merge request !50

Reviewed-by: rhabacker
Reviewed-by: pwithnall

Simplify configure checks

See merge request !10

This should avoid test failures under CMake in which the
dbus-daemon inherits an unwanted fd from CMake's test framework, causing
the close-on-exec check before executing activated services to fail.

The dbus-daemon now marks all fds that it inherits, except for its
stdin, stdout and stderr, to be closed on exec. For completeness, the
dbus-daemons run by dbus-run-session and dbus-launch also now inherit
stdin, stdout, stderr and the pipes used to communicate with their
callers, but nothing else.
Signed-off-by: Simon McVittie <smcv@collabora.com>

In operating systems where /proc/self/fd works like it does on Linux
(Linux itself, and FreeBSD with Linux /proc emulation) this will give
us a clue about the fd that was leaked or opened incorrectly.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Taken from
<https://github.com/KDE/kdoctools/blob/master/cmake/FindDocBookXSL.cmake>
Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: #237

Fix broken meinproc4-based Docbook processing by using xsltproc instead

Closes #233

See merge request !48

Reviewed-by: smcv

Using xsltproc helps to reduce manual editing of xml doc and avoids
cyclic dependency (kdelibs depends on dbus and dbus depends on kdelibs).
It is available on all platforms (in the opposite to xmlto) and supports
freedesktop CI out of the box.

This commit adds docbook-xml and docbook-xsl as new dependency for cmake
and removes obsolate xmlto support, which depends on xsltproc.

Add _DBUS_ASSERT_ERROR_XOR_BOOL, and a test for assertions

See merge request !49

Reviewed-by: pwithnall

BusDesktopFile: Refactor logic to free the parser contents

See merge request !43

Reviewed-by: pwithnall

marshal-recursive test: improve clarity, avoid undefined behaviour

See merge request !46

Reviewed-by: pwithnall

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

Signed-off-by: Simon McVittie <smcv@collabora.com>

There is now a top-level target "doc" that is always built.
Depending on the detected generators it depends on optional
targets like apidoc' and 'devhelp2'.

As suggested by Philip Withnall in !43.
Signed-off-by: Simon McVittie <smcv@collabora.com>

Now that we have _DBUS_STRING_INIT_INVALID, we can initialize
parser.data to a value that is safe for _dbus_string_free(), which
means we can put all the cleanup through a single code path that
definitely frees everything.

(This is just refactoring, not a correctness fix.)
Signed-off-by: Simon McVittie <smcv@collabora.com>