1. 29 Jan, 2015 1 commit
  2. 27 Jan, 2015 1 commit
  3. 06 Jan, 2015 2 commits
  4. 23 Dec, 2014 1 commit
  5. 18 Nov, 2014 1 commit
  6. 06 Nov, 2014 3 commits
  7. 29 Oct, 2014 3 commits
    • Simon McVittie's avatar
      dbus-spawn: do not forget the exec() errno when the grandchild exits · 595dc4f8
      Simon McVittie authored
      As is already noted in a comment in
      _dbus_babysitter_set_child_exit_error(), if the grandchild fails
      to exec() the desired process, we get both CHILD_EXEC_FAILED (with
      an errno) and CHILD_EXITED (with a status), and we want to report
      the former, since it is more informative. However, clearing
      sitter->errnum meant we lose the errno value.
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=24821
      Reviewed-by: Ross Lagerwall
      595dc4f8
    • Simon McVittie's avatar
    • Simon McVittie's avatar
      Consistently save and restore errno · c7fdbe77
      Simon McVittie authored
      Some functions in dbus-transport-socket.c make a (wrapped)
      socket syscall, then call other APIs, then test the result and
      errno of the socket syscall.
      
      This would break horribly if those "other APIs" overwrote errno with
      their own value (... and this is part of why errno is an awful API).
      
      Notably, if running under DBUS_VERBOSE, _dbus_verbose() is basically
      fprintf(), which sets errno; and our Unix fd-passing support
      makes calls of the form _dbus_verbose ("Read/wrote %i unix fds\n", n)
      between the syscall and the result processing.
      
      Maybe one day we'll convert all of dbus' syscall wrappers to either
      raise a DBusError, or use the "negative errno" convention that systemd
      borrowed from the Linux kernel, and in particular, we would need to
      do that if we ever ported it to a platform where socket error reporting
      was not basically errno. However, in practice everyone uses something
      derived from BSD sockets, so "this sets errno, you know what errno is"
      is a good enough internal API if we make sure to use it correctly.
      
      Nothing calls _dbus_get_is_errno_nonzero(), so I just removed it instead
      of converting it to the new calling convention.
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=83625
      c7fdbe77
  8. 28 Oct, 2014 2 commits
  9. 24 Oct, 2014 1 commit
  10. 13 Oct, 2014 1 commit
  11. 25 Sep, 2014 1 commit
  12. 15 Sep, 2014 9 commits
  13. 08 Sep, 2014 2 commits
  14. 30 Jun, 2014 2 commits
  15. 11 Jun, 2014 1 commit
  16. 28 Apr, 2014 3 commits
  17. 03 Mar, 2014 1 commit
  18. 19 Feb, 2014 2 commits
  19. 17 Jan, 2014 1 commit
  20. 10 Jan, 2014 1 commit
  21. 07 Jan, 2014 1 commit