1. 02 Dec, 2003 1 commit
  2. 07 Sep, 2003 1 commit
  3. 12 Aug, 2003 1 commit
    • Havoc Pennington's avatar
      2003-08-12 Havoc Pennington <hp@pobox.com> · 1d1b0f20
      Havoc Pennington authored
      	* bus/dispatch.c (bus_dispatch): make this return proper
      	DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD
      
      	* dbus/dbus-errors.c (dbus_set_error): use
      	_dbus_string_append_printf_valist
      
      	* dbus/dbus-string.c (_dbus_string_append_printf_valist)
      	(_dbus_string_append_printf): new
      
      	* dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
      	UNKNOWN_METHOD
      
      	* dbus/dbus-connection.c (dbus_connection_dispatch): handle
      	DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
      	message is unhandled.
      1d1b0f20
  4. 03 May, 2003 1 commit
  5. 31 Mar, 2003 1 commit
    • Havoc Pennington's avatar
      2003-03-31 Havoc Pennington <hp@redhat.com> · fa05de92
      Havoc Pennington authored
              Fix some annoying DBusString API and fix all affected code.
      
      	* dbus/dbus-string.c (_dbus_string_init): get rid of annoying
      	max_length argument
      	(_dbus_string_get_data): change to return string instead of using
      	an out param
      	(_dbus_string_get_const_data): ditto
      	(_dbus_string_get_data_len): ditto
      	(_dbus_string_get_const_data_len): ditto
      fa05de92
  6. 26 Mar, 2003 1 commit
  7. 25 Mar, 2003 1 commit
    • Havoc Pennington's avatar
      2003-03-24 Havoc Pennington <hp@redhat.com> · ce4fd314
      Havoc Pennington authored
      	* dbus/dbus-sysdeps.c (_dbus_set_fd_nonblocking): move to this
      	file
      
      	* dbus/dbus-errors.c (dbus_set_error, dbus_set_error_const): allow
      	NULL argument for "message" if the error is a well-known one,
      	fill in a generic message in this case.
      
      	* dbus/dbus-errors.h (DBusResultCode): Kill DBusResultCode in
      	favor of DBusError
      
      	* bus/test.c (bus_test_flush_bus): add
      
      	* bus/policy.c (bus_policy_test): test code stub
      ce4fd314
  8. 17 Mar, 2003 1 commit
  9. 16 Mar, 2003 1 commit
    • Havoc Pennington's avatar
      2003-03-16 Havoc Pennington <hp@pobox.com> · ce173b29
      Havoc Pennington authored
      	Oops - test code was only testing failure of around 30 of the
      	mallocs in the test path, but it turns out there are 500+
      	mallocs. I believe this was due to misguided linking setup such
      	that there was one copy of dbus_malloc etc. in the daemon and one
      	in the shared lib, and only daemon mallocs were tested. In any
      	case, the test case now tests all 500+ mallocs, and doesn't pass
      	yet, though there are lots of fixes in this patch.
      
      	* dbus/dbus-connection.c (dbus_connection_dispatch_message): fix
      	this so that it doesn't need to allocate memory, since it
      	has no way of indicating failure due to OOM (and would be
      	annoying if it did).
      
      	* dbus/dbus-list.c (_dbus_list_pop_first_link): new function
      
      	* bus/Makefile.am: rearrange to create two self-contained
      	libraries, to avoid having libraries with overlapping symbols.
      	that was resulting in weirdness, e.g. I'm pretty sure there
      	were two copies of global static variables.
      
      	* dbus/dbus-internals.c: move the malloc debug stuff to
      	dbus-memory.c
      
      	* dbus/dbus-list.c (free_link): free list mempool if it becomes
      	empty.
      
      	* dbus/dbus-memory.c (_dbus_disable_mem_pools): new function
      
      	* dbus/dbus-address.c (dbus_parse_address): free list nodes
      	on failure.
      
      	* bus/dispatch.c (bus_dispatch_add_connection): free
      	message_handler_slot when no longer using it, so
      	memory leak checkers are happy for the test suite.
      
      	* dbus/dbus-server-debug-pipe.c (debug_finalize): free server name
      
      	* bus/bus.c (new_connection_callback): disconnect in here if
      	bus_connections_setup_connection fails.
      
      	* bus/connection.c (bus_connections_unref): fix to free the
      	connections
      	(bus_connections_setup_connection): if this fails, don't
      	disconnect the connection, just be sure there are no side
      	effects.
      
      	* dbus/dbus-string.c (undo_alignment): unbreak this
      
      	* dbus/dbus-auth.c (_dbus_auth_unref): free some stuff we were
      	leaking
      	(_dbus_auth_new): fix the order in which we free strings
      	on OOM failure
      
      	* bus/connection.c (bus_connection_disconnected): fix to
      	not send ServiceDeleted multiple times in case of memory
      	allocation failure
      
      	* dbus/dbus-bus.c (dbus_bus_get_base_service): new function to
      	get the base service name
      	(dbus_bus_register_client): don't return base service name,
      	instead store it on the DBusConnection and have an accessor
      	function for it.
      	(dbus_bus_register_client): rename dbus_bus_register()
      
      	* bus/dispatch.c (check_hello_message): verify that other
      	connections on the bus also got the correct results, not
      	just the one sending hello
      ce173b29
  10. 13 Mar, 2003 1 commit
    • Havoc Pennington's avatar
      2003-03-12 Havoc Pennington <hp@redhat.com> · 29560adc
      Havoc Pennington authored
              Mega-patch that gets the message bus daemon initially handling
      	out-of-memory. Work still needed. Also lots of random
      	moving stuff to DBusError instead of ResultCode.
      
      	* dbus/dbus-list.c (_dbus_list_length_is_one): new function
      
      	* dbus/dbus-connection.c
      	(dbus_connection_send_with_reply_and_block): use DBusError
      
      	* dbus/dbus-bus.c: adapt to API changes, make it use DBusError not
      	DBusResultCode
      
      	* dbus/dbus-connection.c (dbus_connection_send): drop the result
      	code here, as the only failure possible is OOM.
      
      	* bus/connection.c (bus_connection_disconnect):
      	rename bus_connection_disconnected as it's a notification only
      
      	* bus/driver.c (bus_driver_handle_acquire_service): don't free
      	"name" on get_args failure, should be done by get_args;
      	don't disconnect client for bad args, just return an error.
      	(bus_driver_handle_service_exists): ditto
      
      	* bus/services.c (bus_services_list): NULL-terminate returned array
      
      	* bus/driver.c (bus_driver_send_service_lost)
      	(bus_driver_send_service_acquired): send messages from driver to a
      	specific client to the client's unique name, not to the broadcast
      	service.
      
      	* dbus/dbus-message.c (decode_header_data): reject messages that
      	contain no name field
      	(_dbus_message_get_client_serial): rename to
      	dbus_message_get_serial and make public
      	(_dbus_message_set_serial): rename from set_client_serial
      	(_dbus_message_set_reply_serial): make public
      	(_dbus_message_get_reply_serial): make public
      
      	* bus/connection.c (bus_connection_foreach): allow stopping
      	iteration by returning FALSE from foreach function.
      
      	* dbus/dbus-connection.c (dbus_connection_send_preallocated)
      	(dbus_connection_free_preallocated_send)
      	(dbus_connection_preallocate_send): new API for sending a message
      	without possibility of malloc failure.
      	(dbus_connection_send_message): rename to just
      	dbus_connection_send (and same for whole function family)
      
      	* dbus/dbus-errors.c (dbus_error_free): make this reinit the error
      
      	* dbus/dbus-sysdeps.c (_dbus_exit): new function
      
      	* bus/activation.c: handle/return errors
      
      	* dbus/dbus-errors.h: add more DBUS_ERROR #define
      
      	* dbus/dbus-sysdeps.c (_dbus_directory_open) (_dbus_file_get_contents)
      	(_dbus_directory_get_next_file): use DBusError instead of DBusResultCode
      	(_dbus_result_from_errno): move to this file
      29560adc
  11. 31 Jan, 2003 2 commits
    • Anders Carlsson's avatar
      2003-01-31 Anders Carlsson <andersca@codefactory.se> · 8ab042b9
      Anders Carlsson authored
      	* dbus/dbus-address.c: (dbus_address_entry_free):
      	Free key and value lists.
      
      	* dbus/dbus-internals.c: (_dbus_type_to_string):
      	Add the types we didn't have.
      
      	* dbus/dbus-marshal.c: (_dbus_marshal_get_arg_end_pos),
      	(_dbus_marshal_validate_arg):
      	Add NIL types.
      
      	* dbus/dbus-message.c: (dbus_message_set_sender):
      	Remove todo about being able to set sender to NULL.
      
      	(dbus_message_set_is_error_reply),
      	(dbus_message_get_is_error_reply):
      	* dbus/dbus-message.h:
      	New functions.
      
      	* dbus/dbus-protocol.h:
      	Add error reply flag.
      
      	* test/data/valid-messages/opposite-endian.message:
      	Add NIL type to test.
      8ab042b9
    • Havoc Pennington's avatar
      2003-01-30 Havoc Pennington <hp@pobox.com> · 6fc53eb1
      Havoc Pennington authored
      	* dbus/dbus-server.c (dbus_server_listen): @todo about how we need
      	a better way to report errors here. e.g.  "unix address lacks
      	path" or something. also "no such file" when the path doesn't
      	exist, etc.
      
      	* dbus/dbus-address.c (dbus_address_entries_free): add @todo about
      	leaking list nodes
      	(dbus_parse_address): add @todo about documenting address format,
      	and allowing , and ; to be escaped
      6fc53eb1
  12. 30 Jan, 2003 1 commit
    • Anders Carlsson's avatar
      2003-01-30 Anders Carlsson <andersca@codefactory.se> · 5ebb5748
      Anders Carlsson authored
      	* dbus/Makefile.am:
      	Add dbus-address.[ch]
      
      	* dbus/dbus-address.c: (dbus_address_entry_free),
      	(dbus_address_entries_free), (create_entry),
      	(dbus_address_entry_get_method), (dbus_address_entry_get_value),
      	(dbus_parse_address), (_dbus_address_test):
      	* dbus/dbus-address.h:
      	New files for dealing with address parsing.
      
      	* dbus/dbus-connection.c:
      	Document timeout functions.
      
      	* dbus/dbus-message.c:
      	Document dbus_message_new_from_message.
      
      	* dbus/dbus-server-debug.c:
      	Document.
      
      	* dbus/dbus-server.c: (dbus_server_listen):
      	Parse address and use correct server implementation.
      
      	* dbus/dbus-string.c: (_dbus_string_find_to), (_dbus_string_test):
      	* dbus/dbus-string.h:
      	New function with test.
      
      	* dbus/dbus-test.c: (dbus_internal_symbol_do_not_use_run_tests):
      	* dbus/dbus-test.h:
      	Add address tests.
      
      	* dbus/dbus-transport-debug.c:
      	Document.
      
      	* dbus/dbus-transport.c: (_dbus_transport_open):
      	Parse address and use correct transport implementation.
      5ebb5748