1. 05 May, 2015 1 commit
    • Adrian Szyndela's avatar
      DBusCounter: add a mutex to protect the refcount and notify function · bbef8e40
      Adrian Szyndela authored
      The overall problem here is that DBusCounter is indirectly linked
      to a DBusConnection, but is not actually guaranteed to be protected by
      that connection's mutex; and a DBusMessage can carry a reference to the
      DBusCounter, resulting in freeing that DBusMessage having an effect on
      the DBusCounter.
      
      Making the refcount atomic would not be a sufficient fix, since it would
      not protect the notify function: _dbus_counter_notify() could be called
      indirectly by dbus_message_unref(), in an arbitrary thread that does not
      hold the DBusConnection's lock, at the same time that the holder
      of the DBusConnection lock calls _dbus_transport_set_max_message_size().
      
      [smcv: added commit message]
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89297Reviewed-by: default avatarSimon McVittie <simon.mcvittie@collabora.co.uk>
      bbef8e40
  2. 21 Feb, 2012 1 commit
  3. 04 Jan, 2012 1 commit
    • Simon McVittie's avatar
      Revert all changes since a36d4918 · 5df8c3db
      Simon McVittie authored
      Someone seems to have merged part of master into 1.4. Again. Let's go
      back to the "last known good" point (the branch-point of some 1.4
      branches I had locally), then we can cherry-pick the changes that
      should have gone in.
      5df8c3db
  4. 28 Jul, 2011 1 commit
  5. 24 Jun, 2011 1 commit
  6. 19 Mar, 2010 1 commit
  7. 14 Jul, 2009 1 commit
  8. 10 Jul, 2009 1 commit
  9. 20 May, 2009 1 commit
  10. 14 Jul, 2007 1 commit
  11. 10 Aug, 2004 1 commit
  12. 02 Dec, 2003 1 commit
  13. 27 Nov, 2003 1 commit
  14. 19 Jan, 2003 1 commit
    • Havoc Pennington's avatar
      2003-01-18 Havoc Pennington <hp@pobox.com> · 502fbda2
      Havoc Pennington authored
      	* dbus/dbus-transport-unix.c (unix_do_iteration): only do the
      	reading/writing if read_watch != NULL or write_watch != NULL.
      
      	* dbus/dbus-message.c (_dbus_message_loader_return_buffer): fix
      	the message loader code to actually load message->header and
      	message->body into the newly-created message.
      
      	* dbus/dbus-transport-unix.c (check_write_watch): fix a mem leak
      	in OOM case
      
      	* dbus/dbus-connection.c (dbus_connection_set_max_message_size)
      	(dbus_connection_get_max_message_size)
      	(dbus_connection_set_max_live_messages_size)
      	(dbus_connection_get_max_live_messages_size): implement some
      	resource limitation functions
      
      	* dbus/dbus-resources.c: new file implementing some of the
      	resource limits stuff
      
      	* dbus/dbus-message.c (dbus_message_iter_get_byte_array): add
      	missing docs, add @todo to handle OOM etc.
      
      	* dbus/dbus-marshal.c (_dbus_demarshal_byte_array): add missing
      	docs
      502fbda2