1. 02 Oct, 2015 1 commit
    • Simon McVittie's avatar
      Cancel pending activation on any activation error · 694d63b6
      Simon McVittie authored
      This fixes the error reporting if you make two attempts
      to activate a service that cannot be activated due to an
      error that is reported synchronously, such as a system
      service with no User= line in its .service file.
      
      This is easy to reproduce with the gdbus(1) tool, which
      sends an Introspect call in addition to the one you asked
      it to. If you try to activate a service using
      
      gdbus call --session -d com.example.FailToActivate \
          -o / -m org.freedesktop.DBus.Peer.Ping
      
      then gdbus will actually send two method calls: one
      Introspect, and one Ping. The Introspect gets the correct
      error reply, but when dbus-daemon enters
      bus_activation_activate_service() for the Ping call, it
      sees that there is a pending activation and does an
      early-return. The pending activation does not finish
      until the timeout is reached.
      
      A couple of error cases handled this correctly, but the
      majority did not; make them all go into the same code path.
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92200Reviewed-by: Thiago Macieira's avatarThiago Macieira <thiago@kde.org>
      694d63b6
  2. 30 Sep, 2015 2 commits
  3. 20 Sep, 2015 1 commit
  4. 17 Sep, 2015 1 commit
  5. 25 Aug, 2015 4 commits
  6. 06 Aug, 2015 9 commits
  7. 21 Jul, 2015 9 commits
  8. 13 Jul, 2015 1 commit
  9. 17 Jun, 2015 5 commits
  10. 27 May, 2015 4 commits
  11. 14 May, 2015 3 commits