1. 23 Feb, 2018 1 commit
  2. 20 Feb, 2018 4 commits
  3. 08 Feb, 2018 5 commits
  4. 07 Feb, 2018 3 commits
  5. 06 Feb, 2018 5 commits
  6. 29 Jan, 2018 3 commits
  7. 11 Jan, 2018 2 commits
  8. 14 Dec, 2017 2 commits
  9. 28 Nov, 2017 1 commit
  10. 27 Nov, 2017 1 commit
    • Simon McVittie's avatar
      _dbus_server_new_for_socket: Iterate over arrays as intended · 9a842883
      Simon McVittie authored
      Commit 0c03b505 was meant to clear all the fds indexed by j in
      [0, n_fds), which socket_disconnect() can't be allowed to close
      (because on failure the caller remains responsible for closing them);
      but instead it closed the one we failed to add to the main loop
      (fd i), repeatedly.
      
      Similarly, it was meant to invalidate all the watches indexed by j
      in [i, n_fds) (the one we failed to add to the main loop and the ones
      we didn't try to add to the main loop yet), which socket_disconnect()
      can't be allowed to see (because it would fail to remove them from
      the main loop and hit an assertion failure); but instead it invalidated
      fd i, repeatedly.
      
      These happen to be the same thing if you only have one fd, resulting
      in the test-case passing on an IPv4-only system, but failing on a
      system with both IPv4 and IPv6.
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89104Signed-off-by: Simon McVittie's avatarSimon McVittie <smcv@collabora.com>
      Reviewed-by: Philip Withnall's avatarPhilip Withnall <withnall@endlessm.com>
      (cherry picked from commit c9aa00ce)
      9a842883
  11. 24 Nov, 2017 5 commits
  12. 14 Nov, 2017 2 commits
  13. 13 Nov, 2017 2 commits
  14. 10 Nov, 2017 4 commits