Commits · 54f92110f653965b791c8e38cba29582d99fba65 · dbus / dbus

14 Apr, 2015 1 commit

CID 54766: Resource leak (RESOURCE_LEAK). · 54f92110

Ralf Habacker authored Apr 14, 2015

Variable original_argv going out of scope leaks the storage it points to.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

54f92110

13 Apr, 2015 3 commits

Merge branch 'dbus-1.8' · 718843d3
Ralf Habacker authored Apr 13, 2015
```
Conflicts:
	dbus/dbus-sysdeps-win.c
```
718843d3

Fix 'dbus connection referencing issue in test-relay'. · c225ff83

Ralf Habacker authored Apr 13, 2015

The watches added on connection setup should be removed on shutdown.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90005Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

c225ff83

Add newline to verbose output in _dbus_trace_ref(). · 96e02c5d

Ralf Habacker authored Apr 10, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90004Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

96e02c5d

24 Mar, 2015 4 commits

cmake: Extend underlines below dbus version print on configure summary title. · 4101e0bc
Ralf Habacker authored Mar 24, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
```
4101e0bc

Fix assorted compiler warnings on Windows. · 76471790

Simon McVittie authored Mar 12, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
[rh: rebased because a few hunks have already been applied with commit
 92c39d1d]

76471790

Rename _dbus_full_duplex_pipe() to more descriptive name _dbus_socketpair(). · 73af0d5d
Ralf Habacker authored Mar 06, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
73af0d5d

cmake: only set CMP0053, CMP0054 on CMake >= 3.1 · 21c41b3e

Simon McVittie authored Mar 12, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

21c41b3e

17 Mar, 2015 1 commit
- Fix of 'warning: variable ‘..‘ set but not used [-Wunused-but-set-variable]'. · 92c39d1d
  Ralf Habacker authored Mar 04, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
  92c39d1d
11 Mar, 2015 6 commits
- Revert "Rename _dbus_full_duplex_pipe() to more descriptive name _dbus_socketpair()." · 40a6b6e8
  Ralf Habacker authored Mar 11, 2015
```
This reverts commit ee0e1536.
```
  40a6b6e8
- Revert "Use typedef DBusSocket for sockets fd's to avoid conversion warnings." · dfaf56e9
  Ralf Habacker authored Mar 11, 2015
```
This reverts commit f9192688.
```
  dfaf56e9
- cmake: opt-in to not implicitly expanding variables in if() (policy CMP0054) · 72f246f8
  Ralf Habacker authored Mar 11, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
  72f246f8
- Revert "cmake: @VAR@ substitutions in set() are deprecated, use... · f756aead
  Ralf Habacker authored Mar 11, 2015
```
Revert "cmake: @VAR@ substitutions in set() are deprecated, use string(CONFIGURE) instead (policy CMP0053)"

This reverts commit 45f2e84a.
```
  f756aead
- Use typedef DBusSocket for sockets fd's to avoid conversion warnings. · f9192688
  Ralf Habacker authored Mar 05, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
```
  f9192688
- Rename _dbus_full_duplex_pipe() to more descriptive name _dbus_socketpair(). · ee0e1536
  Ralf Habacker authored Mar 06, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89444
```
  ee0e1536
06 Mar, 2015 4 commits
- cmake: @VAR@ substitutions in set() are deprecated, use string(CONFIGURE) instead (policy CMP0053) · 45f2e84a
  Ralf Habacker authored Mar 06, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
  45f2e84a
- cmake: @VAR@ substitutions in set() are deprecated, use string(CONFIGURE) instead (policy CMP0053) · d46f7bac
  Ralf Habacker authored Mar 05, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
  d46f7bac
- cmake: stop using deprecated LOCATION property (policy CMP0026) · 924bff39
  Ralf Habacker authored Mar 05, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
  924bff39
- Fix cmake build system bug not generating versioned library name in case LT_REVISION is zero. · 5d8f82d6
  Ralf Habacker authored Feb 20, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89450Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
  5d8f82d6
05 Mar, 2015 10 commits

Add missing include file for cmake function check_include_files() (commit 2d2b5af9 ) · ee9c52ca
Ralf Habacker authored Mar 05, 2015

ee9c52ca

dbus-print-message: conditionalize Unix FD handling on DBUS_UNIX · 58f66e6c

Simon McVittie authored Mar 04, 2015

We close() the fd after we have printed it, but close() isn't
standard functionality on Windows. Unix FD-passing is never going
to work on non-Unix platforms anyway.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89428Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

58f66e6c

dbus-monitor: use _dbus_get_real_time instead of gettimeofday · 188884dd

Simon McVittie authored Mar 04, 2015

gettimeofday is implicitly declared (i.e. not in our #include'd header
files) when cross-compiling for on Windows. Now that fd.o#83115
has been fixed, using _dbus functions is not a problem.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89428Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

188884dd

Improve diagnostics when UpdateActivationEnvironment calls are rejected · 49d67163

Simon McVittie authored Mar 05, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88812Reviewed-by: Colin Walters <walters@verbum.org>
[smcv: rebased to not require the extra code initially on that bug]

49d67163

Keep cmake generated defines for include files in sync with autotools. · e4885885
Ralf Habacker authored Mar 05, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
e4885885
Move include file checks to ConfigureChecks.cmake for cmake build system. · cd8524ce
Ralf Habacker authored Mar 05, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
cd8524ce
Add check to cmake build system if config.h.cmake is in sync with autotools. · 939b3d97
Ralf Habacker authored Mar 05, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
939b3d97

Keep include file checks in sync with autotools. · add6b4f5

Ralf Habacker authored Mar 05, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

add6b4f5

Add cmake macro autoheaderchecks(). · 4d8a2770

Ralf Habacker authored Mar 05, 2015

This macro prints out any include file defined as HAVE_..._H in the config
header template and not in the related cmake configure checks file.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=85418Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

4d8a2770

Fix broken cmake HAVE_SOCKLEN_T type finding check. · 8696bfdf

Ralf Habacker authored Mar 04, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

8696bfdf

04 Mar, 2015 11 commits

Add missing header for _dbus_sleep_milliseconds() (commit 43d2455e ) · 2d2b5af9
Simon McVittie authored Mar 04, 2015

2d2b5af9

Add test-fdpass to cmake build system. · 2c7abec2

Ralf Habacker authored Mar 04, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

2c7abec2

signal_handler: avoid signed/unsigned mismatch (-Wsign-compare) · 0d42526e

Simon McVittie authored Mar 04, 2015

We're ignoring the result of this write() to stderr anyway, because
if it failed... what would we do? Write to stderr? That wouldn't work
any better the second time :-)

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

0d42526e

Enable -Wsign-compare for cmake builds. · 08a75e07

Ralf Habacker authored Mar 04, 2015

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

08a75e07

Autotools: enable -Wsign-compare and optionally -Werror=sign-compare · 50bd76ac
Simon McVittie authored Mar 04, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
```
50bd76ac
fd-passing test: numbers of things are unsigned (-Wsign-compare) · c3e345f1
Simon McVittie authored Mar 04, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
```
c3e345f1
_dbus_listen_systemd_sockets: fds are signed ints (-Wsign-compare) · 719829a4
Simon McVittie authored Mar 04, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>
```
719829a4

Use new _dbus_string_get_length_uint() to avoid another -Wsign-compare · 51a718c6

Simon McVittie authored Mar 04, 2015

DBusString's length is signed for historical reasons: the right type
would have been size_t or some other unsigned type. We have a *lot*
of callers of _dbus_string_get_length(), so it is not really desirable
to do a flag-day switch; but we know that the length is always in the
range [0, INT_MAX] that is common to int and unsigned int, so we can
safely add an unsigned accessor.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=17289Reviewed-by: Ralf Habacker <ralf.habacker@freenet.de>

51a718c6

Drop duplicated function tool_millisleep() and use dbus_sleep_milliseconds() instead. · 43d2455e
Ralf Habacker authored Mar 04, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
```
43d2455e

Fix warning 'conversion to ‘long unsigned int’ from ‘WriteResult’ may change... · 6588c657

Ralf Habacker authored Mar 03, 2015

Fix warning 'conversion to ‘long unsigned int’ from ‘WriteResult’ may change the sign of the result [-Wsign-conversion]'.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

6588c657

Fix of 'warning: conversion to ‘dbus_bool_t‘ from ‘int‘ may change the sign of... · 72549f31

Ralf Habacker authored Mar 04, 2015

Fix of 'warning: conversion to ‘dbus_bool_t‘ from ‘int‘ may change the sign of the result [-Wsign-conversion]'.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89284Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>

72549f31