- 02 Nov, 2015 1 commit
-
-
Simon McVittie authored
A similar simplification was already done on master as part of commit f830e14d, Bug #83539. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92721Reviewed-by:
Ralf Habacker <ralf.habacker@freenet.de>
-
- 16 Apr, 2015 1 commit
-
-
Ralf Habacker authored
We already skipped processing for DBUS_ERROR_FILE_NOT_FOUND; but if the error was something else, we would pass the NULL pointer dir to _dbus_directory_get_next_file(), which dereferences it. Reported by Coverity: CID 54744: Dereference after null check (FORWARD_NULL) Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021 [smcv: re-worded commit message] Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 25 Feb, 2015 1 commit
-
-
Dimitri John Ledkov authored
Empty include directories were already not treated as failures. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=89280Signed-off-by:
Dimitri John Ledkov <dimitri.j.ledkov@intel.com> Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 18 Feb, 2015 1 commit
-
-
Tyler Hicks authored
The <apparmor> element can contain a single mode attribute that has one of three values: "enabled" "disabled" "required" "enabled" means that kernel support is autodetected and, if available, AppArmor mediation occurs in dbus-daemon. If kernel support is not detected, mediation is disabled. "disabled" means that mediation does not occur. "required" means that kernel support must be detected for dbus-daemon to start. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=75113Signed-off-by:
Tyler Hicks <tyhicks@canonical.com> Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 22 Nov, 2014 1 commit
-
-
Simon McVittie authored
This reverts commit 54d26df5. It appears this change may cause intermittent slow or failed boot, more commonly on slower/older machines, in at least Mageia and possibly also Debian. This would indicate that while the system is under load, system services are not completing authentication within 5 seconds. This change was not the main part of fixing CVE-2014-3639, but does help to mitigate that attack. As such, increasing this timeout makes the denial of service attack described by CVE-2014-3639 somewhat more effective: a local user connecting to the system bus repeatedly from many parallel processes can cause other users' attempts to connect to take longer. If your machine boots reliably with the shorter timeout, and resilience against local denial of service attacks is important to you, putting this in /etc/dbus-1/system-local.conf or a file matching /etc/dbus-1/system.d/*.conf can restore the lower limit: <busconfig> <limit name="auth_timeout">5000</limit> </busconfig> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=86431
-
- 15 Sep, 2014 3 commits
-
-
Alban Crequy authored
This is one of four commits needed to address CVE-2014-3637. When a file descriptor is passed to dbus-daemon, the associated D-Bus message might not be fully sent to dbus-daemon yet. Dbus-daemon keeps the file descriptor in the DBusMessageLoader of the connection, waiting for the rest of the message. If the client stops sending the remaining bytes, dbus-daemon will wait forever and keep that file descriptor. This patch adds pending_fd_timeout (milliseconds) in the configuration to disconnect a connection after a timeout when a file descriptor was sent but not the remaining message. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=80559Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
Alban Crequy authored
This partially addresses CVE-2014-3639. This will change the default on the system bus where the limit <limit name="auth_timeout">...</limit> is not specified. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=80919Reviewed-by:
Thiago Macieira <thiago@kde.org> Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
Alban Crequy authored
This addresses CVE-2014-3638. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=81053Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 14 Jan, 2014 1 commit
-
-
Matthew Hoosier authored
The algorithm to collapse a subsidiary config file's data into the master data structure forgot to examine this flag. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=73475Reviewed-by:
Chengwei Yang <chengwei.yang@intel.com> Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 23 Aug, 2013 1 commit
-
-
Simon McVittie authored
It's sufficiently portable that GLib has an equivalent, and I really don't want to have to either open-code it in dbus-run-session or link dbus-run-session statically. We have enough statically-linked rubbish already. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39196Reviewed-by:
Colin Walters <walters@verbum.org>
-
- 28 Jun, 2013 1 commit
-
-
Chengwei Yang authored
Signed-off-by:
Chengwei Yang <chengwei.yang@intel.com> Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=66291
-
- 11 Apr, 2013 1 commit
-
-
Matt Fischer authored
QNX has an arbitrary limit to the number of file descriptors which may be passed in a message, which is smaller than the current default. This patch therefore changes the default from a hardcoded constant to a macro, which is determined at configure time by looking at the host operating system. [This reduces the limit from 4096 (session)/1024 (system) to 128 fds per message on QNX, and 1024 fds per message on other operating systems. I think the reduced session bus limit on other OSs is a reasonable change too, given that the default hard/soft ulimits in Linux are only 4096/1024 fds per process. -smcv] Bug: https://bugs.freedesktop.org/show_bug.cgi?id=61176 Reviewed-by: Simon McVittie <simon.mcvittie.collabora.co.uk>
-
- 12 Feb, 2013 1 commit
-
-
Krzysztof Konopko authored
<servicehelper> is not supported in the included config file, i. e. it's not merged in merge_included(). There's clearly no reason it shouldn't be supported in the included config file along with <user>, <type> and others. It's quite reasonable for a client willing to override the default servicehelper, e. g. in system-local.conf. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=51560Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 22 Mar, 2012 1 commit
-
-
Alban Crequy authored
After parsing [allow|deny] rules with own_prefix, check they are enforced correctly. https://bugs.freedesktop.org/show_bug.cgi?id=46886
-
- 04 Mar, 2012 1 commit
-
-
- 08 Feb, 2012 1 commit
-
-
Simon McVittie authored
In practice, it never works, because the activation helper doesn't respect environment variables for security reasons. If you want to vary the search path, alter system.conf instead, to replace or augment <standard_system_servicedirs/> with your preferred search path. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=21620Signed-off-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 04 Jan, 2012 1 commit
-
-
Simon McVittie authored
Someone seems to have merged part of master into 1.4. Again. Let's go back to the "last known good" point (the branch-point of some 1.4 branches I had locally), then we can cherry-pick the changes that should have gone in.
-
- 05 Aug, 2011 1 commit
-
-
Simon McVittie authored
It's unused on Unix, and gcc warns. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39231Reviewed-by:
Will Thompson <will.thompson@collabora.co.uk>
-
- 28 Jul, 2011 1 commit
-
-
Lennart Poettering authored
In order to allow D-Bus usage during early boot (where /usr is not accessible) also search for bus activation files in /lib/dbus-1/system-services/. This is only a first step in the right direction, before we really can boot without /usr we'd need to move all current activation files (or possibly replace /usr/dbus-1/system-services to a symlink to /lib/dbus-1/system-services).
-
- 07 Apr, 2011 1 commit
-
-
Simon McVittie authored
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=10887Reviewed-by:
Colin Walters <walters@verbum.org>
-
- 07 Mar, 2011 1 commit
-
-
Andre Heinecke authored
On Windows Systems ELEMENT_TYPE is already defined in Winioctl.h this header is included indirectly in dbus-sysdeps.h. By avoiding the use of the Name ELEMENT_TYPE it is ensured that config-parser-common.h can be included together with dbus-sysdeps.h Reviewed-by:
Simon McVittie <simon.mcvittie@collabora.co.uk>
-
- 24 Feb, 2011 1 commit
-
-
Simon McVittie authored
Reviewed-by:
Will Thompson <will.thompson@collabora.co.uk>
-
- 31 Jan, 2011 1 commit
-
-
Simon McVittie authored
This is more graceful than failing entirely (our previous behaviour), but more visible than ignoring it completely (the previous behaviour patched in by Debian and derivatives). Based on a patch from Daniel Silverstone back in 2004, which was meant to be temporary; I think it makes sense to change this permanently, since files in *.d are typically supplied by other packages, whose bugs shouldn't be able to bring down dbus-daemon. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=19186 Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=230231Reviewed-by:
Colin Walters <walters@verbum.org>
-
- 29 Dec, 2010 1 commit
-
-
Ralf Habacker authored
-
- 19 Mar, 2010 1 commit
-
-
Marcus Brinkmann authored
-
- 01 Dec, 2009 1 commit
-
-
Ralf Habacker authored
-
- 14 Jul, 2009 2 commits
-
-
Tobias Mueller authored
No comment. Signed-off-by:
Colin Walters <walters@verbum.org> (cherry picked from commit 5baf2f85)
-
Scott James Remnant authored
* bus/config-parser.c (bus_config_parser_new): change the default reply timeout to "never" Signed-off-by:
Scott James Remnant <scott@ubuntu.com> (cherry picked from commit 8f1d2a2f)
-
- 10 Jul, 2009 1 commit
-
-
Tobias Mueller authored
No comment. Signed-off-by:
Colin Walters <walters@verbum.org>
-
- 28 May, 2009 1 commit
-
-
Scott James Remnant authored
* bus/config-parser.c (bus_config_parser_new): change the default reply timeout to "never" Signed-off-by:
Scott James Remnant <scott@ubuntu.com>
-
- 20 May, 2009 1 commit
-
-
Lennart Poettering authored
Create configuration settings and enforce message unix fd limits the same way we do for allocated message memory.
-
- 06 Jan, 2009 1 commit
-
-
Matt McCutchen authored
Signed-off-by:
Colin Walters <walters@verbum.org>
-
- 16 Dec, 2008 2 commits
-
-
Colin Walters authored
This lets us have a backwards compatibility allow rule but still easily see when that rule is being used.
-
Colin Walters authored
This lets us have a backwards compatibility allow rule but still easily see when that rule is being used.
-
- 12 Dec, 2008 2 commits
-
-
Colin Walters authored
We need to start logging denials so that they become more easily trackable and debuggable.
-
Colin Walters authored
We need to start logging denials so that they become more easily trackable and debuggable.
-
- 12 Nov, 2008 1 commit
-
-
Dennis Kaarsemaker authored
* bus/bus.c: Set allow_anonymous if specified from parser. * bus/config-parser.c: Parse it. * bus/config-parser-common.h: Declare it. Signed-off-by:
Colin Walters <walters@verbum.org>
-
- 10 Nov, 2008 1 commit
-
-
Matt McCutchen authored
Signed-off-by:
Colin Walters <walters@verbum.org>
-
- 15 Jan, 2008 1 commit
-
-
John Palmieri authored
2008-01-15 John (J5) Palmieri <johnp@redhat.com> * patch by Kimmo Hämäläinen <kimmo dot hamalainen at nokia dot com> * bus/config-parser.c (locate_attributes): remove dead code which always evaluated to TRUE * dbus/dbus-shell.c (_dbus_shell_quote): remove unused code
-
- 24 Jul, 2007 1 commit
-
-
Havoc Pennington authored
* configure.in: add AM_PROG_CC_C_O to allow per-target CPPFLAGS * bus/dispatch.c (bus_dispatch_test_conf): Fix up setting TEST_LAUNCH_HELPER_CONFIG to include the full path, and enable test shell_fail_service_auto_start when use_launcher==TRUE * bus/activation-helper-bin.c (convert_error_to_exit_code): pass through the INVALID_ARGS error so the test suite works * bus/activation.c (handle_activation_exit_error): return DBUS_ERROR_NO_MEMORY if we get BUS_SPAWN_EXIT_CODE_NO_MEMORY * dbus/dbus-spawn.c (_dbus_babysitter_get_child_exit_status): return only the exit code of the child, not the entire thingy from waitpid(), and make the return value indicate whether the child exited normally (with a status code) * bus/bus.c (process_config_first_time_only): _dbus_strdup works on NULL so no need to check (process_config_every_time): move servicehelper init here, so we reload it on HUP or config file change * bus/Makefile.am (install-data-hook): remove comment because Emacs make mode seems to be grumpy about it
-