Commits · 1a28f82926c31ae17b8688bdeb6d68f29d628592 · dbus / dbus

03 Feb, 2015 4 commits

Treat root as a valid candidate for TEST_USER_ME · 3cf71c27

Simon McVittie authored Feb 03, 2015

If spawn_dbus_daemon() can fail for TEST_USER_ME, then we'd have to
go through all the tests adding the ability to skip tests after
it fails, which is a fairly extensive change.

The tests have historically all run as whatever uid is supplied, and
if the tests are being run as root for some reason - perhaps in a CI
framework for an embedded platform that doesn't have non-root users,
or in an environment where you can be root or non-root but not both -
there is no particular reason to skip them.

3cf71c27

Add a test for uid-controlled permissions · 98ae1149

Simon McVittie authored Jan 26, 2015

This is technical debt from mitigating CVE-2014-8148, which should
really have had a regression test at the time.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88810
Reviewed-by: Philip Withnall

98ae1149

Add infrastructure to run bits of tests under an alternative uid · 6a49ced2
Simon McVittie authored Jan 26, 2015
```
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88810
Reviewed-by: Philip Withnall
```
6a49ced2

Factor out some utility functions from test/dbus-daemon* · 8b238f3f

Simon McVittie authored Jan 26, 2015

In the process, make test_kill_pid() safer: do not try to terminate
more than one pid, or the NULL handle.

Also stop leaking the address_fd in spawn_dbus_daemon, a pre-existing
bug that was spotted by Philip Withnall during review.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=88810
Reviewed-by: Philip Withnall

8b238f3f