Commit 423ab7cd authored by Simon McVittie's avatar Simon McVittie

update_desktop_file_entry: initialize return value properly, and actually return it

Since 1.4.4 (commit 75cfd97f) this function always returned FALSE. As far
as I can see this was actually harmless, because both of its callers
ignore any error that is not NoMemory (and treat it the same as success).

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=39230Reviewed-by: Will Thompson's avatarWill Thompson <will.thompson@collabora.co.uk>
parent c38e9823
......@@ -268,6 +268,7 @@ update_desktop_file_entry (BusActivation *activation,
_DBUS_ASSERT_ERROR_IS_CLEAR (error);
retval = FALSE;
name = NULL;
exec = NULL;
user = NULL;
......@@ -478,7 +479,7 @@ out:
if (entry)
bus_activation_entry_unref (entry);
return FALSE;
return retval;
}
static dbus_bool_t
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment