ChangeLog 167 KB
Newer Older
1 2 3 4 5 6 7 8 9
2003-08-29  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object-tree.c: modify to allow overlapping paths to be
	registered
	(struct DBusObjectSubtree): shrink this
	a lot, since we may have a lot of them
	(_dbus_object_tree_free_all_unlocked): implement
	(_dbus_object_tree_dispatch_and_unlock): implement

10 11 12 13
2003-08-29  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-internals.h: fix _DBUS_N_GLOBAL_LOCKS

14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
2003-08-28  Havoc Pennington  <hp@pobox.com>

	purge DBusObjectID
	
	* dbus/dbus-connection.c: port to no ObjectID, create a
	DBusObjectTree, rename ObjectTree to ObjectPath in public API

	* dbus/dbus-connection.h (struct DBusObjectTreeVTable): delete 
	everything except UnregisterFunction and MessageFunction
	
	* dbus/dbus-marshal.c: port away from DBusObjectID, 
	add DBUS_TYPE_OBJECT_PATH
	
	* dbus/dbus-object-registry.[hc], dbus/dbus-object.[hc], 
	dbus/dbus-objectid.[hc]: remove these, we are moving to 
	path-based object IDs

31 32 33 34 35 36 37 38 39 40 41
2003-08-25  Havoc Pennington  <hp@pobox.com>

        Just noticed that dbus_message_test is hosed, I wonder when I
	broke that. I thought make check was passing earlier...
	
	* dbus/dbus-object-tree.c: add new "object tree" to match DCOP 
	container tree, will replace most of dbus-object-registry

	* dbus/dbus-string.c (_dbus_string_append_printf_valist): fix C99
	screwup

42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57
2003-08-19  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-message.c (decode_string_field): support FIELD_SENDER
	(dbus_message_is_error): fix this function

	* bus/dbus-daemon-1.1: clarify logic on when <deny>/<allow> rules
	match

	* bus/policy.c (bus_client_policy_check_can_receive): fix code to
	reflect clarified man page
	(bus_client_policy_check_can_send): ditto
	
	* bus/session.conf.in: fixup

	* bus/system.conf.in: fixup

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81
2003-08-18  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-hash.c (_dbus_hash_table_insert_two_strings): fix

	* dbus/dbus-message.c (_dbus_message_loader_queue_messages): fix
	dumb bug created earlier (wrong order of args to
	decode_header_data())
	
	* tools/dbus-send.c: port

	* tools/dbus-print-message.c (print_message): port

        * test/data/*messages: port all messages over
	
        * dbus/dbus-message-builder.c: support including 
	message type
	
        * bus/driver.c: port over
	
	* bus/dispatch.c: port over to new stuff

	* dbus/dbus-connection.c (_dbus_connection_new_for_transport):
	rename disconnect signal to "Disconnected"

82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111
2003-08-17  Havoc Pennington  <hp@pobox.com>

	This doesn't compile yet, but syncing up so I can hack on it from
	work. What are branches for if not broken code? ;-)
	
	* dbus/dbus-protocol.h: remove DBUS_HEADER_FIELD_NAME, add
	DBUS_HEADER_FIELD_INTERFACE, DBUS_HEADER_FIELD_MEMBER,
	DBUS_HEADER_FIELD_ERROR_NAME
	
	* dbus/dbus-hash.c: Introduce DBUS_HASH_TWO_STRINGS as hack to use
	for the interface+member pairs
	(string_hash): change to use g_str_hash algorithm
	(find_direct_function, find_string_function): refactor these to
	share most code.
	
	* dbus/dbus-message.c: port all of this over to support 
	interface/member fields instead of name field

	* dbus/dbus-object-registry.c: port over
	
	* dbus/dbus-string.c (_dbus_string_validate_interface): rename
	from _dbus_string_validate_name

	* bus/dbus-daemon-1.1: change file format for the 
	<deny>/<allow> stuff to match new message naming scheme

	* bus/policy.c: port over

	* bus/config-parser.c: parse new format
	
112 113 114 115 116 117 118
2003-08-16  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object-registry.c (add_and_remove_objects): remove
	broken assertion

	* glib/dbus-gproxy.c: some hacking

119 120 121 122 123 124 125 126 127
2003-08-15  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-pending-call.c (dbus_pending_call_block): implement

	* dbus/dbus-connection.c
	(dbus_connection_send_with_reply_and_block): factor out internals;
	change to convert any error replies to DBusError instead of 
	returning them as a message

128 129 130 131 132
2003-08-15  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-connection.c, 
	dbus/dbus-pending-call.c: Finish the pending call stuff

133 134 135 136 137 138 139 140 141 142 143
2003-08-14  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-pending-call.c: start on new object that will replace
	DBusMessageHandler and ReplyHandlerData for tracking outstanding
	replies

	* dbus/dbus-gproxy.c: start on proxy object used to communicate
	with remote interfaces

	* dbus/dbus-gidl.c: do the boring boilerplate in here
	
144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161
2003-08-12  Havoc Pennington  <hp@pobox.com>

	* bus/dispatch.c (bus_dispatch): make this return proper 
	DBusHandlerResult to avoid DBUS_ERROR_UNKNOWN_METHOD

	* dbus/dbus-errors.c (dbus_set_error): use
	_dbus_string_append_printf_valist

	* dbus/dbus-string.c (_dbus_string_append_printf_valist)
	(_dbus_string_append_printf): new

	* dbus/dbus-errors.h (DBUS_ERROR_UNKNOWN_MESSAGE): change to
	UNKNOWN_METHOD

	* dbus/dbus-connection.c (dbus_connection_dispatch): handle
	DBUS_HANDLER_RESULT_NEED_MEMORY; send default error reply if a
	message is unhandled.

162 163 164 165 166 167 168 169 170 171
2003-08-11  Havoc Pennington  <hp@pobox.com>

	* bus/test.c (client_disconnect_handler): change to return
	HANDLED (would have been REMOVE_MESSAGE)

	* dbus/dbus-object.h (enum DBusHandlerResult): rename to
	HANDLED/NOT_YET_HANDLED instead of
	REMOVE_MESSAGE/ALLOW_MORE_HANDLERS to make it clearer how it 
	should be used.

172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193
2003-08-10  Havoc Pennington  <hp@pobox.com>

	* tools/dbus-send.c (main): add --type argument, for now
	supporting only method_call and signal types.

	* tools/dbus-print-message.c: print message type

	* dbus/dbus-connection.c (_dbus_connection_new_for_transport):
	init connection->objects

	* doc/dbus-specification.sgml: fix sgml

	* bus/*.c: port over to object-instance API changes

	* test/test-service.c: ditto
	
	* dbus/dbus-message.c (dbus_message_create_header): allow #NULL
	name, we will have to fix up the rest of the code to also handle
	this
	(dbus_message_new): generic message-creation call
	(set_string_field): allow appending name field

194 195 196 197 198 199 200 201 202
2003-08-06  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object-registry.c: implement signal connection 
	and dispatch

	* dbus/dbus-connection.c (_dbus_connection_unref_unlocked): new

	* dbus/dbus-internals.c (_dbus_memdup): new function

203 204 205 206 207 208 209 210 211
2003-08-02  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-message.c (dbus_message_get_no_reply)
	(dbus_message_set_no_reply): add these and remove
	set_is_error/get_is_error

	* dbus/dbus-protocol.h, doc/dbus-specification.sgml: 
	remove the ERROR flag, since there's now an ERROR type

212 213 214 215 216 217 218 219 220
2003-08-01  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object-registry.c (_dbus_object_registry_handle_and_unlock):
	implement

	* dbus/dbus-message.c (dbus_message_get_type): new function

	* doc/dbus-specification.sgml: add "type" byte to messages

221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249
2003-08-01  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-protocol.h (DBUS_MESSAGE_TYPE_*): introduce
	a message type enum to distinguish kinds of message
	(DBUS_HEADER_FLAG_NO_REPLY_EXPECTED): flag for a message 
	that need not be replied to

2003-08-01  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-marshal.c: adapt to DBusObjectID changes
	(unpack_8_octets): fix no-64-bit-int bug

	* dbus/dbus-object-registry.c (validate_id): validate the 
	connection ID bits, not just the instance ID.

	* dbus/dbus-connection.c (_dbus_connection_init_id): initialize
	the connection-global 33 bits of the object ID

	* dbus/dbus-object-registry.c (info_from_entry): fill in 
	object ID in the new way

	* dbus/dbus-objectid.h: rather than high/low bits, specifically 
	define server/client/instance bits.

2003-07-30  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-connection.c (dbus_connection_register_object): fix
	build

250 251 252 253 254
2003-07-13  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object.h (struct DBusObjectVTable): add padding
	fields to DBusObjectVTable and DBusObjectInfo

255 256 257 258 259 260 261 262 263 264 265
2003-07-12  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object-registry.c: implement unit test,
	fix bugs discovered in process

	* dbus/dbus-connection.c: remove handler_table and
	register_handler(), add DBusObjectRegistry usage

	* dbus/dbus-objectid.c (dbus_object_id_is_null)
	(dbus_object_id_set_null): new functions

266 267 268 269 270 271 272 273 274
2003-07-08  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object.c: implement some of this

	* dbus/dbus-object-registry.c
	(_dbus_object_registry_add_and_unlock): fill in the object_id out
	param
	(_dbus_object_registry_new): handle OOM

275 276 277 278 279 280 281 282 283 284
2003-07-08  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-object.h: sketch out an API for registering objects
	with a connection, that allows us to use as little as 24 bytes
	per object and lets application code represent an object in 
	any conceivable way.

	* dbus/dbus-object-registry.c: implement the hard bits of the
	DBusConnection aspect of object API. Not yet wired up.
	
285 286 287 288 289 290
2003-07-06  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-marshal.c (_dbus_marshal_set_object_id): new function
	(_dbus_marshal_object_id): new
	(_dbus_demarshal_object_id): new
	(_dbus_marshal_get_arg_end_pos): support object ID type, and
291
	consolidate identical switch cases. Don't conditionalize handling
292
	of DBUS_TYPE_UINT64, need to handle the type always.
293
	(_dbus_marshal_validate_arg): consolidate identical cases, and
294 295 296 297 298 299
	handle DBUS_TYPE_OBJECT_ID

	* dbus/dbus-objectid.c: new file with DBusObjectID data type.

	* dbus/dbus-protocol.h: add DBUS_TYPE_OBJECT_ID

300 301 302 303 304 305 306 307 308 309 310
2003-06-29  Havoc Pennington  <hp@pobox.com>

	* mono/Test.cs (class Test): fire up a main loop and run it

	* mono/DBus.cs (DBus): don't g_thread_init since it can only be
	done once, the app has to do it

2003-06-26  Havoc Pennington  <hp@pobox.com>

	* mono/Connection.cs: set up connection with the glib main loop

311 312
2003-07-01  Havoc Pennington  <hp@redhat.com>

313
	* doc/dbus-specification.sgml: clarify the format of a type code,
314 315
	change suggested by Jim Blandy

316 317
2003-06-29  Miloslav Trmac  <mitr@volny.cz>

318 319 320
	* doc/Makefile.am:
	* tools/Makefile.am: Don't assume srcdir == builddir.

321 322 323 324 325 326
	* dbus/dbus-memory.c (dbus_realloc): Don't check guards after shrinking
	the allocated block.
	(_dbus_memory_test): New function.
	* dbus/dbus-test.h: Add _dbus_memory_test ().
	* dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): Call it.

327 328 329 330
	* dbus/dbus-message.c (decode_header_data): Use %.4s instead
	of %c%c%c%c.
	(dbus_message_new): Remove obsolete @todo.

331
	* dbus/dbus-marshal.c (_dbus_marshal_set_int64)
332 333
	(_dbus_marshal_set_uint64): Fix comment.

334 335 336
	* dbus/dbus-message.c (append_int_field, append_uint_field): Don't
	hardcode FIELD_REPLY_SERIAL.

337 338 339 340 341 342
	* dbus/dbus-mainloop.c (_dbus_loop_remove_watch)
	(_dbus_loop_remove_timeout): Cast function pointers to (void *) for %p

	* configure.in: Add -D_POSIX_C_SOURCE=199309L -DBSD_SOURCE to CFLAGS
	and disable DBUS_USE_ATOMIC_INT_486 when --enable-ansi is used

343 344 345 346
2003-06-24  Havoc Pennington  <hp@pobox.com>

	* mono/*.cs: Use IntPtr.Zero instead of ((IntPtr) 0)

347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363
2003-06-23  Anders Carlsson  <andersca@codefactory.se>

	* configure.in:
	* gcj/.cvsignore:
	* gcj/Hello.java:
	* gcj/Makefile.am:
	* gcj/TestMessage.java: (TestMessage), (TestMessage.main):
	* gcj/org/.cvsignore:
	* gcj/org/Makefile.am:
	* gcj/org/freedesktop/.cvsignore:
	* gcj/org/freedesktop/Makefile.am:
	* gcj/org/freedesktop/dbus/.cvsignore:
	* gcj/org/freedesktop/dbus/Makefile.am:
	* gcj/org/freedesktop/dbus/Message.java: (Message),
	(Message.Message):
	* gcj/org/freedesktop/dbus/natMessage.cc:
	Fix the build system.
364

365 366 367 368 369 370 371
2003-06-22  Havoc Pennington  <hp@pobox.com>

	* mono/Connection.cs: add more bindings

	* dbus/dbus-threads.c (dbus_threads_init): allow calling this
	more than once.

372 373
2003-06-22  Havoc Pennington  <hp@pobox.com>

374
	* mono/Connection.cs, mono/DBus.cs, mono/Error.cs:
375 376
	Start wrapping more stuff.

377 378 379
2003-06-22  Havoc Pennington  <hp@pobox.com>

	* mono/Message.cs: implement Message.Wrap() that ensures we only
380
	have a single C# wrapper per DBusMessage, assuming it works which
381 382 383 384 385 386 387
	it probably doesn't.

	* dbus/dbus-message.c (dbus_message_allocate_data_slot): new
	(dbus_message_free_data_slot): new
	(dbus_message_set_data): new
	(dbus_message_get_data): new

388 389 390 391
2003-06-22  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-dataslot.c (_dbus_data_slot_allocator_unref)
	(_dbus_data_slot_allocator_alloc): rework these to keep a
392
	reference count on each slot and automatically manage a global
393
	slot ID variable passed in by address
394

395 396 397 398 399 400 401 402 403 404 405 406 407 408
	* bus/bus.c: convert to new dataslot API

	* dbus/dbus-bus.c: convert to new dataslot API

	* dbus/dbus-connection.c: convert to new dataslot API

	* dbus/dbus-server.c: convert to new dataslot API

	* glib/dbus-gmain.c: ditto

	* bus/test.c: ditto

	* bus/connection.c: ditto

409 410
2003-06-22  Anders Carlsson  <andersca@codefactory.se>

411 412 413 414
	* configure.in: Add AM_PROG_GCJ and move AM_PROG_LIBTOOL
	after the gcj checks so that the correct configuration tags
	will be added to libtool.

415 416 417
	* dbus-glib-1.pc.in: No need to specify any includes since
	dbus-1.pc.in has those.

418 419
2003-06-22  Havoc Pennington  <hp@pobox.com>

420 421 422
	* mono/*, gcj/*, configure.in, Makefile.am:
	Check in makefiles and subdirs for mono and gcj bindings.
	Neither binding actually exists, just trying to get through
423 424
	all the build and other boring bits.

425 426 427 428 429 430
2003-06-21  Philip Blundell  <philb@gnu.org>

	* tools/dbus-monitor.1: Updated.

	* tools/dbus-send.1: Likewise.

431 432
2003-06-20  Anders Carlsson  <andersca@codefactory.se>

433
	* dbus/dbus-transport-unix.c (unix_handle_watch): Check
434 435 436
	for hangup and error after checking read so we won't discard
	pending data if both hangup and read are set.

437 438 439 440 441
2003-06-19  Philip Blundell  <philb@gnu.org>

	* tools/dbus-print-message.c (print_message): Handle BOOLEAN.

	* tools/dbus-send.c: Accept both --system and --session.
442

443
	* tools/dbus-monitor.c: Same here.
444

445 446 447 448 449
2003-06-19  Anders Carlsson  <andersca@codefactory.se>

	* glib/dbus-glib.h: Fix so that dbus-glib.h can be used
	from C++ (Patch by Miloslav Trmac).

450 451 452 453 454 455 456 457 458 459 460
2003-06-15  Joe Shaw  <joe@assbarn.com>

	* configure.in: Check for socklen_t.

	* dbus/dbus-sysdeps.c: Define socklen_t if it's not defined.

	* test/test-segfault.c: Add #include <sys/time.h>

	* tools/Makefile.am: Add DBUS_X_CFLAGS to the INCLUDES since
	dbus-launch needs it.

461 462 463 464 465 466 467 468
2003-06-09  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-sysdeps.c (_dbus_listen_unix_socket): don't use
	SUN_LEN, it breaks abstract socket usage

	* dbus/dbus-internals.c (_dbus_verbose_real): only print PID at
	starts of lines.

469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487
2003-06-04  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-server.c (dbus_server_listen): allow abstract sockets
	using unix:abstract=/foo, and when listening in a tmpdir
	i.e. unix:tmpdir=/tmp, always use abstract sockets if we can.

	* dbus/dbus-transport.c (_dbus_transport_open): support
	unix:abstract=/foo

	* dbus/dbus-server-unix.c (_dbus_server_new_for_domain_socket):
	support abstract sockets

	* dbus/dbus-transport-unix.c
	(_dbus_transport_new_for_domain_socket): support abstract sockets

	* dbus/dbus-sysdeps.c (_dbus_connect_unix_socket): add "abstract"
	toggle as an argument, implement abstract namespace support
	(_dbus_listen_unix_socket): ditto

488
	* configure.in: add --enable-abstract-sockets and implement
489 490
	a configure check for autodetection of the right value.

491 492
2003-06-01  Havoc Pennington  <hp@pobox.com>

493 494
	* tools/dbus-cleanup-sockets.c: add utility to clean up sockets
	in /tmp (though on Linux this will end up being useless,
495 496 497 498 499
	when we add abstract namespace support)

	* configure.in: define DBUS_SESSION_SOCKET_DIR in addition to
	subst'ing it

500 501 502 503
2003-05-28  Colin Walters  <walters@verbum.org>

	* tools/dbus-monitor.c (main): Fix silly typo (s/--session/--system/).

504 505 506 507
2003-05-18  Anders Carlsson  <andersca@codefactory.se>

	* dbus/dbus-message.c (dbus_message_new): Remove @todo.

508 509 510 511 512
2003-05-17  Colin Walters  <walters@gnu.org>

	* tools/dbus-send.c: Don't exit with an error code if --help was
	passed.  Default to using the session bus instead of the system
	one.
513 514

	* tools/dbus-launch.c: Ditto.
515 516 517 518

	* tools/dbus-monitor.c: Ditto.

	* tools/dbus-send.1: Update with new arguments.
519

520 521 522
	* tools/dbus-launch.c: Emit code to export variables.  New
	arguments -s and -c to specify shell syntax, and a bit of code to
	autodetect syntax.  Also, allow specifying a program to run.
523

524
	* tools/dbus-launch.1: Update with new arguments.
525

526 527 528
	* tools/dbus-send.1: Ditto.

	* tools/dbus-monitor.1: Ditto.
529

530 531 532 533 534
2003-05-17  Havoc Pennington  <hp@pobox.com>

	* bus/config-parser.c (merge_included): merge in policies from
	child configuration file.

535
	* bus/policy.c (bus_policy_merge): function to merge two policies
536 537
	together

538 539 540 541 542 543
2003-05-16  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-connection.c: disable verbose lock spew

	* tools/dbus-send.c: add --print-reply command line option

544
	* tools/dbus-print-message.h (print_message): new util function
545 546 547 548
	shared by dbus-send and dbus-monitor

	* tools/dbus-monitor.c (handler_func): exit on disconnect

549
	* dbus/dbus-transport-unix.c (do_reading): if the transport is
550 551 552 553 554
	disconnected, don't try to use the read_watch

	* dbus/dbus-watch.c (dbus_watch_get_enabled): assert watch != NULL
	so we can find this bug more easily

555 556 557 558 559
2003-05-16  Havoc Pennington  <hp@redhat.com>

	* bus/policy.c (free_rule_list_func): avoid a crash when passed
	NULL as DBusHashTable is annoyingly likely to do.

560 561 562 563 564 565 566 567 568 569
2003-05-16  Colin Walters  <walters@verbum.org>

	* tools/dbus-monitor.c: Add --session argument and usage()
	function.

	* tools/dbus-monitor.1: Update with new --session arg.

	* bus/Makefile.am (install-data-hook): Create
	$(libdir)/dbus-1.0/services so that the session bus is happy.

570 571 572 573 574
2003-05-15  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-sysdeps.c (_dbus_atomic_dec, _dbus_atomic_inc): work
	on non-x86. ifdef's are evil.

575 576 577 578 579 580 581 582 583 584 585 586 587
2003-05-15  Havoc Pennington  <hp@redhat.com>

	* configure.in: 0.11

	* NEWS: update

	* bus/Makefile.am (initddir): apparently we are supposed to put
	init scripts in /etc/rc.d/init.d not /etc/init.d

	* bus/Makefile.am: remove the "you must --enable-tests to make
	check" as it broke distcheck

	* bus/Makefile.am (install-data-hook): create /etc/dbus-1/system.d
588

James Willcox's avatar
 
James Willcox committed
589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607
2003-05-13  James Willcox  <jwillcox@gnome.org>

	* configure.in:
	* bus/activation.c: (bus_activation_service_created),
	(bus_activation_activate_service):
	* bus/driver.c: (bus_driver_send_service_deleted),
	(bus_driver_send_service_created), (bus_driver_send_service_lost),
	(bus_driver_send_service_acquired),
	(bus_driver_send_welcome_message),
	(bus_driver_handle_list_services):
	* bus/session.conf.in:
	* dbus/dbus-bus.c: (dbus_bus_acquire_service),
	(dbus_bus_service_exists), (dbus_bus_activate_service):
	* dbus/dbus-bus.h:

	Add some convenience API which lets you activate a service, and did a
	bunch of s/0/DBUS_TYPE_INVALID/ in calls to dbus_message_append_args()
	and dbus_message_get_args()

608 609
2003-05-11  Havoc Pennington  <hp@pobox.com>

610
	* dbus/dbus-marshal.c (_dbus_marshal_validate_arg): fix to avoid
611 612 613
	calling _dbus_marshal_validate_arg() for every byte in a byte
	array, etc.

614
	* dbus/dbus-message-handler.c: use atomic reference counting to
615 616 617 618 619 620
	reduce number of locks slightly; the global lock in here sucks

	* dbus/dbus-connection.c
	(_dbus_connection_update_dispatch_status_and_unlock): variant of
	update_dispatch_status that can be called with lock held; then use
	in a couple places to reduce locking/unlocking
621
	(dbus_connection_send): hold the lock over the whole function
622 623 624 625 626 627 628 629 630 631 632 633 634 635 636
	instead of acquiring it twice.

	* dbus/dbus-timeout.c (_dbus_timeout_new): handle OOM

	* bus/connection.c (bus_connections_setup_connection): fix access
	to already-freed memory.

	* dbus/dbus-connection.c: keep a little cache of linked list
	nodes, to avoid using the global linked list alloc lock in the
	normal send-message case. Instead we just use the connection lock
	that we already have to take.

	* dbus/dbus-list.c (_dbus_list_find_last): new function

	* dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec):
637
	change to use a struct for the atomic type; fix docs,
638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653
	they return value before increment, not after increment.

	* dbus/dbus-string.c (_dbus_string_append_4_aligned)
	(_dbus_string_append_8_aligned): new functions to try to
	microoptimize this operation.
	(reallocate_for_length): break this out of set_length(), to
	improve profile info, and also so we can consider inlining the
	set_length() part.

	* dbus/dbus-message.c (dbus_message_new_empty_header): init data
	strings with some preallocation, cuts down on our calls to realloc
	a fair bit. Though if we can get the "move entire string to empty
	string" optimization below to kick in here, it would be better.

	* dbus/dbus-string.c (_dbus_string_move): just call
	_dbus_string_move_len
654 655
	(_dbus_string_move_len): add a special case for moving
	an entire string into an empty string; we can just
656 657 658
	swap the string data instead of doing any reallocs.
	(_dbus_string_init_preallocated): new function

659 660 661 662 663 664 665
2003-05-11  Havoc Pennington  <hp@pobox.com>

	Write a "test-profile" that does echo client-server with threads;
	profile reveals lock contention, memcpy/realloc of buffers, and
	UTF-8 validation as hot spots. 20% of lock contention eliminated
	with dbus_atomic_inc/dec implementation on x86.  Much remaining
	contention is global mempool locks for GList and DBusList.
666

667 668 669 670
	* dbus/dbus-sysdeps.c (_dbus_atomic_inc, _dbus_atomic_dec): add
	x86 implementation

	* dbus/dbus-connection.c (struct DBusConnection): use
671
	dbus_atomic_t for the reference count
672

673
	* dbus/dbus-message.c (struct DBusMessage): declare
674 675 676 677 678 679 680 681
	dbus_atomic_t values as volatile

	* configure.in: code to detect ability to use atomic integer
	operations in assembly, from GLib patch

	* dbus/dbus-internals.c (_dbus_verbose_real): call getpid every
	time, tired of it being wrong in threads and forked processes

682
	* glib/test-profile.c: a little program to bounce messages back
683 684 685
	and forth between threads and eat CPU

	* dbus/dbus-connection.c: add debug spew macros for debugging
686
	thread locks; include config.h at top; fix deadlock in
687 688
	dbus_connection_flush()

689 690 691
2003-05-08  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-spawn.c: s/_exit/exit/ because it was keeping gcov
692
	data from getting written, and there wasn't a good reason to
693 694 695 696
	use _exit really.

	* test/decode-gcov.c (mark_inside_dbus_build_tests): don't count
	dbus_verbose lines in test coverage
697
	(main): add list of functions sorted by # of untested blocks
698 699 700 701 702 703 704 705 706 707 708 709 710 711 712
	to the coverage report

	* dbus/dbus-mempool.c: put some test-only code in DBUS_BUILD_TESTS

	* dbus/dbus-marshal.c (_dbus_marshal_test): extend test coverage

	* dbus/dbus-message-handler.c (_dbus_message_handler_test):
	extend test coverage

	* test/data/auth/cancel.auth-script: test canceling an
	authentication

	* dbus/Makefile.am: remove dbus-server-debug.[hc] for now, as they
	aren't used. in CVS history if we end up needing them.

713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730
2003-05-04  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-message-handler.c (_dbus_message_handler_test): add
	unit test

	* dbus/dbus-marshal.c (_dbus_demarshal_string_array): fix this
	function, which assumed length was in # of strings, not bytes

	* dbus/dbus-message.c (_dbus_message_test): add tests for some
	missing coverage

	* dbus/dbus-connection.c
	(_dbus_connection_queue_received_message): disable function for
	now, we are only using it in test mode

	* dbus/dbus-message.c (_dbus_message_loader_queue_messages):
	remove a mistaken FIXME

731 732 733 734 735
2003-05-04  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-connection.c (dbus_connection_preallocate_send):
	unlock mutex on successful return, patch from Anders Gustafsson

736 737
2003-05-04  Havoc Pennington  <hp@pobox.com>

738
	* dbus-glib-1.pc.in (Requires): fix dependencies, from
739 740
	Anders Gustafsson

741 742 743 744
2003-05-04  Havoc Pennington  <hp@pobox.com>

	* tools/dbus-launch.c: implement

745
	* bus/main.c (main), bus/bus.c (bus_context_new):
746 747
	implement --print-pid and --fork

748 749 750 751 752 753
2003-05-03  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-address.c (dbus_parse_address): fix bug when a key in
	the address had no value, and add to test suite. Fix and
	regression test from Miloslav Trmac

754 755 756 757 758 759 760 761
2003-05-03  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-watch.c (dbus_watch_handle): warn and return if a
	watch is invalid when handled

	* tools/Makefile.am, tools/dbus-launch.c, tools/dbus-launch.1: add
	dbus-launch utility to launch the bus from a shell script.  Didn't
	actually implement dbus-launch yet, it's just a placeholder still.
762

763 764 765 766 767 768 769
2003-05-03  Havoc Pennington  <hp@pobox.com>

	* bus/Makefile.am, bus/dbus-daemon-1.1.in: man page for the
	daemon; also documents daemon config file, so replaces
	doc/config-file.txt. Corrected some stuff from config-file.txt in
	the process of moving it.

770 771
2003-05-03  Havoc Pennington  <hp@pobox.com>

772
	* tools/Makefile.am, tools/dbus-send.1, tools/dbus-monitor.1:
773 774
	add some man pages

775 776 777 778 779 780 781
2003-05-03  Colin Walters  <walters@verbum.org>

	* dbus/dbus-sysdeps.c (fill_user_info): Test against
	DBUS_UID_UNSET to determine whether to do a uid lookup or not.

	* Makefile.am: Update to use new .pc versioning scheme.

782 783 784 785 786
2003-05-02  Havoc Pennington  <hp@redhat.com>

	* bus/system.conf.in: allow send/receive to/from message bus
	service

787 788 789 790 791
2003-04-30  Havoc Pennington  <hp@redhat.com>

	* configure.in: print a note when building with unit tests and
	without assertions

792 793 794 795 796
2003-04-30  Havoc Pennington  <hp@redhat.com>

	* Makefile.am: add a check-local that complains if you didn't
	configure with --enable-tests

797 798 799 800 801 802 803 804 805
2003-04-29  Havoc Pennington  <hp@redhat.com>

	* glib/dbus-gmain.c: docs cleanups

	* dbus/dbus-types.h: add docs on int64 types

	* dbus/dbus-memory.c: fix docs to avoid putting private API in
	public API docs section

806 807 808 809 810 811 812 813 814 815 816 817
2003-04-29  Havoc Pennington  <hp@redhat.com>

	* dbus-1.pc.in, dbus-glib-1.pc.in: rename these from
	dbus-1.0.pc.in, dbus-glib-1.0.pc.in. As these change with the
	parallel install API version, not with the D-BUS package version.

	* HACKING: move some of README over here

	* README: updates, and document API/ABI policy

	* configure.in: reindentation

818 819 820 821 822
2003-04-29  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus.h: add "you have to define DBUS_API_SUBJECT_TO_CHANGE
	to use this library" to be sure people have the right
	expectations.
823

824 825 826 827 828 829 830 831
2003-04-28  Havoc Pennington  <hp@redhat.com>

	* configure.in: add --enable-docs which by default is auto yes if
	doxygen and db2html found, no otherwise; but can be forced on/off

	* doc/Makefile.am: conditionalize whether to build docs on
	--enable-docs

832 833 834 835 836 837 838
2003-04-28  Havoc Pennington  <hp@redhat.com>

	* configure.in: 0.10

	* NEWS: update

	* bus/system.conf.in: add <includedir>system.d</includedir>
839

840 841 842 843
	* dbus/dbus-userdb.c (_dbus_user_database_lookup): fix bug when
	username was provided but not uid

	* bus/config-parser.c (struct BusConfigParser): keep track of
844
	whether the parser is toplevel or was included; change some
845
	of the error handling if it's included.
846

847 848 849 850 851 852 853
2003-04-27  Havoc Pennington  <hp@pobox.com>

	Unbreak my code...

	* dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
	report correct status if we finish processing authentication
	inside this function.
854

855 856 857 858 859 860 861 862
	* bus/activation.c (try_send_activation_failure): use
	bus_transaction_send_error_reply

	* bus/connection.c (bus_connection_get_groups): return an error
	explaining the problem

	* bus/bus.c (bus_context_check_security_policy): implement
	restriction here that inactive connections can only send the
863
	hello message. Also, allow bus driver to send anything to
864 865 866 867 868 869 870 871 872 873 874 875 876 877 878
	any recipient.

	* bus/connection.c (bus_connection_complete): create the
	BusClientPolicy here instead of on-demand.
	(bus_connection_get_policy): don't return an error

	* dbus/dbus-message.c (dbus_message_new_error_reply): allow NULL
	sender field in message being replied to

	* bus/bus.c (bus_context_check_security_policy): fix silly typo
	causing it to return FALSE always

	* bus/policy.c (bus_client_policy_check_can_send): fix bug where
	we checked sender rather than destination

879 880 881
2003-04-25  Havoc Pennington  <hp@redhat.com>

        test suite is slightly hosed at the moment, will fix soon
882

883 884 885 886 887 888 889 890 891
	* bus/connection.c (bus_connections_expire_incomplete): fix to
	properly disable the timeout when required
	(bus_connection_set_name): check whether we can remove incomplete
	connections timeout after we complete each connection.

	* dbus/dbus-mainloop.c (check_timeout): fix this up a bit,
	probably still broken.

	* bus/services.c (bus_registry_acquire_service): implement max
892
	number of services owned, and honor allow/deny rules on which
893 894 895 896 897 898 899
	services a connection can own.

	* bus/connection.c (bus_connection_get_policy): report errors here

	* bus/activation.c: implement limit on number of pending
	activations

900 901 902 903 904
2003-04-25  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-transport.c (_dbus_transport_get_unix_user): fix bug
	where we used >= 0 instead of != DBUS_UID_UNSET.

905 906 907 908 909
2003-04-25  Havoc Pennington  <hp@redhat.com>

	* glib/dbus-gmain.c (remove_watch): fix for a crash when watches
	were toggled without add/remove, fix from Anders Gustafsson

910 911 912 913
2003-04-24  Havoc Pennington  <hp@redhat.com>

	* test/data/valid-config-files/basic.conf: add <limit> tags to
	this test
914

915 916
	* bus/config-parser.h, bus/config-parser.c, bus/bus.c: Implement
	<limit> tag in configuration file.
917

918 919 920 921
2003-04-24  Havoc Pennington  <hp@redhat.com>

	* bus/dispatch.c: somehow missed some name_is

922
	* dbus/dbus-timeout.c (_dbus_timeout_set_enabled)
923 924 925
	(_dbus_timeout_set_interval): new

	* bus/connection.c (bus_connections_setup_connection): record time
926
	when each connection is first set up, and expire them after the
927 928
	auth timeout passes.

929 930 931 932 933 934 935
2003-04-24  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-message.c (dbus_message_name_is): rename
	(dbus_message_service_is): rename
	(dbus_message_sender_is): rename
	(dbus_message_get_service): rename

936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951
2003-04-24  Havoc Pennington  <hp@redhat.com>

	* configure.in: add --enable-checks

	* dbus/dbus-message.c (dbus_message_new): reverse name/service arguments

	* dbus/dbus-connection.c (dbus_connection_preallocate_send): fix
	to use thread locks.
	(_dbus_connection_handler_destroyed_locked): move some private
	functions into proper docs group

	* dbus/dbus-internals.h: add _dbus_return_if_fail,
	_dbus_return_val_if_fail

	Throughout: use dbus_return_if_fail

James Willcox's avatar
 
James Willcox committed
952 953 954 955 956 957 958 959 960 961 962 963 964 965
2003-04-23  James Willcox  <jwillcox@gnome.org>

	* glib/dbus-glib.h:
	* glib/dbus-gmain.c: (add_timeout), (wakeup_main), (create_source),
	(dbus_connection_setup_with_g_main),
	(dbus_server_setup_with_g_main):
	* glib/test-dbus-glib.c: (main):
	* glib/test-thread-client.c: (main):
	* glib/test-thread-server.c: (new_connection_callback), (main):
	* tools/dbus-monitor.c: (main):

	Added a GMainContext argument to dbus_connection_setup_with_g_main()
	and dbus_server_setup_with_g_main().

966 967 968 969 970
2003-04-20  Havoc Pennington  <hp@pobox.com>

	* doc/dbus-specification.sgml: document the restrictions on
	message and service names

971 972 973
2003-04-22  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-message.c, dbus/dbus-marshal.c: add 64-bit integer
974
	support, and do some code cleanups to share more code and
975 976 977 978 979 980 981 982 983
	speed up array marshal/demarshal.

	* dbus-1.0.pc.in (Cflags): put libdir include file in cflags

	* configure.in: generate dbus-arch-deps.h

	* dbus/dbus-protocol.h (DBUS_TYPE_INT64, DBUS_TYPE_UINT64): add
	64-bit typecodes

984 985 986 987 988 989
2003-04-22  Havoc Pennington  <hp@redhat.com>

	* test/data/valid-messages/opposite-endian.message: fix test
	to use proper type for rply field

        * test/data/invalid-messages: add tests for below validation
990

991 992 993 994 995 996 997
	* dbus/dbus-message.c (decode_header_data): validate field types,
	and validate that named fields are valid names
	(decode_name_field): consider messages in the
	org.freedesktop.Local. namespace to be invalid.

	* dbus/dbus-string.c (_dbus_string_validate_name): new

998 999
2003-04-19  Havoc Pennington  <hp@pobox.com>

1000
	* bus/driver.c (bus_driver_handle_hello): check limits and
1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011
	return an error if they are exceeded.

	* bus/connection.c: maintain separate lists of active and inactive
	connections, and a count of each. Maintain count of completed
	connections per user. Implement code to check connection limits.

	* dbus/dbus-list.c (_dbus_list_unlink): export

	* bus/bus.c (bus_context_check_security_policy): enforce a maximum
	number of bytes in the message queue for a connection

1012 1013
2003-04-18  Havoc Pennington  <hp@pobox.com>

1014 1015 1016 1017 1018
	* dbus/dbus-auth.c (record_mechanisms): memleak fixes

	* dbus/dbus-sysdeps.c (_dbus_string_save_to_file): fix some
	memleaks

1019
	* dbus/dbus-keyring.c (add_new_key): fix a memleak, and
1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
	on realloc be sure to update the pointer in the keyring

	* dbus/dbus-string.c (_dbus_string_zero): compensate for align
	offset to avoid writing to unallocated memory

	* dbus/dbus-auth.c (process_rejected): return FALSE if we fail to
	try the next mechanism, so we properly handle OOM

	* dbus/dbus-keyring.c (_dbus_keyring_new_homedir): fix double-free
	on OOM.
	(_dbus_keyring_new): fix OOM bug
	(_dbus_keyring_new_homedir): always set error; impose a maximum
	number of keys we'll load from the file, mostly to speed up the
	test suite and make its OOM checks more useful, but also for
	general sanity.

	* dbus/dbus-auth.c (process_error_server): reject authentication
	if we get an error from the client
	(process_cancel): on cancel, send REJECTED, per the spec
	(process_error_client): send CANCEL if we get an error from the
	server.

2003-04-18  Havoc Pennington  <hp@pobox.com>
1043

1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054
	* dbus/dbus-mainloop.c (_dbus_loop_iterate): fix UMR in verbose
	debug spew

	* dbus/dbus-auth.c (handle_client_data_cookie_sha1_mech): fix OOM
	handling problem

	* dbus/dbus-keyring.c (_dbus_keyring_new_homedir): only whine
	about DBUS_TEST_HOMEDIR once

	* bus/Makefile.am (TESTS_ENVIRONMENT): put DBUS_TEST_HOMEDIR in
	the environment
1055

1056 1057 1058 1059 1060
	* bus/dispatch.c (bus_dispatch_sha1_test): actually load sha1
	config file so we test the right thing

	Throughout: assorted docs improvements

1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074
2003-04-18  Havoc Pennington  <hp@pobox.com>

	* glib/dbus-gmain.c: adapt to watch changes

	* bus/bus.c, bus/activation.c, etc.: adjust to watch changes

	* dbus/dbus-server.h: remove dbus_server_handle_watch

	* dbus/dbus-connection.h: remove dbus_connection_handle_watch

	* dbus/dbus-watch.c (dbus_watch_handle): change DBusWatch to work
	like DBusTimeout, so we don't need dbus_connection_handle_watch
	etc.

1075 1076 1077 1078 1079
2003-04-17  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-userdb.c, dbus/dbus-sysdeps.c: redo all the passwd
	database usage so it all goes via the DBusUserDatabase cache.

1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090
2003-04-17  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-mainloop.c (_dbus_loop_iterate): fix logic so that if
	there was an OOM watch we skipped, we always return TRUE so we
	iterate again to have a look at it again. Fixes test suite hang.
	Code rearrangement also lets us lose some memset and only iterate
	over callbacks once.

	* bus/driver.c (bus_driver_handle_message): sense of test for
	reply was backward

1091 1092 1093 1094 1095 1096 1097
2003-04-16  Havoc Pennington  <hp@pobox.com>

	* doc/dbus-specification.sgml: make spec say serials are unsigned

	* dbus/dbus-message.h: change message serials to unsigned

	* dbus/dbus-connection.c: adapt to message serials being unsigned
1098

1099 1100
2003-04-15  Havoc Pennington  <hp@pobox.com>

1101
	* bus/bus.c: create and keep around a shared DBusUserDatabase
1102 1103 1104
	object.

	* bus/connection.c (bus_connection_get_groups): don't cache
1105
	groups for user in the connection object, since user database
1106 1107
	object now does that.

1108 1109 1110 1111 1112 1113 1114
2003-04-16  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-message.c (_dbus_message_add_size_counter): keep a
	list of size counters
	(_dbus_message_loader_putback_message_link): put back a popped link

	* dbus/dbus-connection.c
1115
	(dbus_connection_set_max_live_messages_size): rename
1116
	max_received_size
1117
	(dbus_connection_get_outgoing_size): get size of outgoing
1118 1119
	queue
	(_dbus_connection_set_connection_counter): remove this cruft
1120

1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131
2003-04-14  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-userdb.c: user database abstraction, mostly to get
	caching, but at some point we might want to be able to use a
	different database.

	* bus/dispatch.c (bus_dispatch_sha1_test): add a test that uses
	SHA1 conf file to test the sha1 auth mechanism, since the regular
	test always uses EXTERNAL when available.

	* configure.in,
1132
	test/data/valid-config-files/debug-allow-all-sha1.conf.in:
1133 1134
	add conf file that requires use of sha1 auth

1135
2003-04-13  Havoc Pennington  <hp@pobox.com>
1136

1137 1138
        * tools/dbus-send.c, tools/dbus-monitor.c: two utility programs
	from Philip Blundell to send messages and monitor them.
1139

1140 1141
2003-04-13  Havoc Pennington  <hp@pobox.com>

1142
	* dbus/dbus-mainloop.c: fix some reentrancy issues by refcounting
1143 1144 1145 1146 1147 1148 1149
	callbacks

	* test/data/valid-config-files/debug-allow-all.conf.in: allow all
	users

	* dbus/dbus-transport.c (_dbus_transport_get_dispatch_status):
	fix to only recover unused bytes if we're already authenticated
1150
	(_dbus_transport_get_is_authenticated): fix to still mark us
1151 1152 1153
	authenticated if there are unused bytes.

	* bus/dispatch.c: implement security policy checking
1154

1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168
	* bus/connection.c (bus_transaction_send_from_driver): new

	* bus/bus.c (bus_context_check_security_policy): new

	* bus/dispatch.c (send_service_nonexistent_error): delete this,
	now we just set the DBusError and it gets converted to an error
	reply.

	* bus/connection.c (allow_user_function): enable code using actual
	data from the config file

	* bus/policy.c (list_allows_user): handle wildcard rules for
	user/group connection perms

1169 1170 1171
2003-04-13  Havoc Pennington  <hp@pobox.com>

	* bus/config-parser.c: Load up the BusPolicy and BusPolicyRules
1172

1173 1174 1175 1176 1177 1178
	* dbus/dbus-sysdeps.c (_dbus_get_user_id): new function

	* bus/policy.c (bus_policy_append_mandatory_rule)
	(bus_policy_append_default_rule, bus_policy_append_user_rule)
	(bus_policy_append_group_rule): new functions

1179 1180 1181 1182 1183 1184 1185 1186
2003-04-12  Havoc Pennington  <hp@pobox.com>

	* bus/config-parser.c (bus_config_parser_new): fix a memleak

	* dbus/dbus-sysdeps.c: change DBusCredentials to use longs for
	the pid/gid/uid, just for paranoia.

	* test/break-loader.c (randomly_do_n_things): find a byte
1187
	containing a type code, and randomly change it to a different
1188 1189
	type code.

1190 1191 1192 1193 1194
2003-04-12  Havoc Pennington  <hp@pobox.com>

	* bus/policy.h: change BusPolicy to be the thing from the config
	file, and rename old BusPolicy to BusClientPolicy

1195
	* bus/bus.c, bus/connection.c, bus/config-parser.c: change to
1196 1197 1198 1199 1200
	match change in how policy works

	* dbus/dbus-internals.h: mark assert_not_reached as
	__attribute((noreturn))__

1201 1202
2003-04-11  Havoc Pennington  <hp@redhat.com>

1203
	* doc/dbus-specification.sgml: fix a spot with the wrong name for
1204 1205
	the broadcast service. Use boolean return for ServiceExists.

1206 1207 1208 1209
2003-04-11  Havoc Pennington  <hp@redhat.com>

	* configure.in: add another directory to look for qt in.

1210 1211 1212 1213
2003-04-11  Havoc Pennington  <hp@redhat.com>

	* AUTHORS: add Colin Walters

1214 1215 1216 1217 1218 1219
2003-04-11  Havoc Pennington  <hp@redhat.com>

	* NEWS: update

	* configure.in: 0.9

1220 1221 1222 1223 1224 1225
2003-04-11  Havoc Pennington  <hp@redhat.com>

	* bus/messagebus.in: remove pid file when stopping the
	message bus, since the bus won't have privileges to remove it
	itself.

1226 1227 1228 1229 1230
2003-04-11  Havoc Pennington  <hp@redhat.com>

	* bus/bus.c (bus_context_new): move credentials change after
	creating pidfile

1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241
2003-04-11  Havoc Pennington  <hp@pobox.com>

	* test/decode-gcov.c: add "below average functions" to the
	coverage report, and change how some of the code works.

	* bus/test-main.c: bracket some stuff in DBUS_BUILD_TESTS so it's
	not in the coverage stats.

	* test/test-service.c (main): use _dbus_verbose not fprintf in a
	couple places so running the test suite doesn't result in megaspam.

1242 1243 1244 1245 1246 1247 1248 1249 1250
2003-04-11  Havoc Pennington  <hp@pobox.com>

	* bus/dispatch.c (check_existent_service_activation): accept a no
	memory error in a place we didn't before

	* bus/test.c (bus_test_run_everything): remove hacky "do it twice
	in case the first one failed," since the test suite is less
	broken now.

1251 1252 1253 1254 1255 1256 1257 1258
2003-04-10  Havoc Pennington  <hp@pobox.com>

	* bus/dispatch.c (check_segfault_service_activation): add test
	for launching an executable that just crashes.

	* test/test-segfault.c (main): try setting coredumpsize to 0 so we
	don't leave a million cores. We'll see how portable this is.

1259 1260 1261
2003-04-10  Havoc Pennington  <hp@pobox.com>

	* dbus/dbus-spawn.c (_dbus_spawn_async_with_babysitter): move all
1262
	the possible parent failures before we fork, so that we don't
1263 1264 1265 1266 1267
	fail to create a babysitter after creating the child.

	* bus/activation.c (bus_activation_activate_service): kill child
	if we don't successfully complete the activation.

1268 1269 1270 1271 1272 1273 1274 1275 1276 1277
2003-04-10  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-connection.c (dbus_connection_flush): don't spin on
	the connection if it's disconnected

	* bus/activation.c (bus_activation_service_created): use new
	transaction features to roll back removal of pending activation if
	we don't successfully create the service after all. Don't remove
	pending activation if the function fails.

1278
	* dbus/dbus-list.c (_dbus_list_insert_before_link)
1279
	(_dbus_list_insert_after_link): new code to facilitate
1280 1281 1282 1283 1284 1285 1286
	services.c fixes

	* dbus/dbus-hash.c (_dbus_hash_table_insert_string_preallocated):
	new functionality, so we can preallocate the ability to insert
	into a hash table.

	* bus/connection.c (bus_transaction_add_cancel_hook): new function
1287
	allowing us to put custom hooks in a transaction to be used for
1288 1289 1290 1291 1292 1293
	cancelling said transaction

	* doc/dbus-specification.sgml: add some discussion of secondary
	service owners, and disallow zero-length service names

	* bus/services.c (bus_registry_acquire_service): new function,
1294 1295
	splits out part of bus_driver_handle_acquire_service() and fixes
	a bug where we didn't remove the service doing the acquiring
1296 1297
	from the secondary queue if we failed to remove the current owner
	from the front of the queue.
1298

1299 1300 1301 1302
2003-04-10  Alexander Larsson  <alexl@redhat.com>

	* doc/dbus-specification.sgml:
	s/org.freedesktop.Broadcast/org.freedesktop.DBus.Broadcast/
1303

1304 1305 1306 1307 1308 1309
2003-04-10  Alexander Larsson  <alexl@redhat.com>

	* bus/.cvsignore:
	* glib/.cvsignore:
	* test/.cvsignore:
	Added files to cvsignore
1310

1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322
	* dbus/dbus-message.h:
	* dbus/dbus-message.c: (dbus_message_iter_get_named):
	Make get_named() take two out argument and return a boolean.
	(dbus_message_iter_get_args_valist):
	Update usage of get_named().
	(dbus_message_iter_append_byte):
	Fix typo
	(dbus_message_iter_append_named)
	Fix typo
	(message_iter_test), (check_message_handling_type), (_dbus_message_test):
	More tests.

1323 1324 1325 1326 1327
2003-04-10  Alexander Larsson  <alexl@redhat.com>

	* dbus/dbus-marshal.[ch]:
	Add array_type_pos argument to _dbus_marshal_validate_arg.
	Let you pass a NULL end_pos to _dbus_marshal_validate_type.
1328

1329 1330 1331 1332
	* dbus/dbus-message.[ch]:
	Multi-dimensional arrays have full type specification in the
	outermost array. Iter code re-arranged to handle this.
	Added some more iter tests.
1333

1334 1335 1336 1337 1338
	* doc/dbus-specification.sgml:
	Add me to authors.
	Remove old FIXME.
	Update new array encoding description.
	Correct DBUS_SERVICE_FLAGS_REPLACE_EXISTING description.
1339

1340 1341 1342
	* test/data/invalid-messages/array-with-mixed-types.message:
	* test/data/valid-messages/array-of-array-of-uint32.message:
	Change to the new array format.
1343

1344 1345
	* test/data/invalid-messages/too-short-dict.message:
	Fix bug in test.
1346

1347 1348 1349
	* test/data/valid-messages/recursive-types.message:
	Fix up and extend test.

1350 1351 1352
2003-04-10  Havoc Pennington  <hp@pobox.com>

	* bus/dispatch.c: lots of fixes
1353

1354 1355 1356 1357 1358
	* dbus/dbus-mainloop.c (_dbus_loop_dispatch): export
	(_dbus_loop_iterate): remove old "quit if no callbacks" code,
	that was crack, broke the test service.

	* dbus/dbus-transport.c (_dbus_transport_open): fix error
1359
	handling to avoid piling up errors if we get a failure on the
1360 1361 1362 1363 1364 1365 1366 1367 1368 1369
	first address.

	* dbus/dbus-internals.c (_dbus_real_assert_not_reached): include
	pid in assertion failures.

	* dbus/dbus-mainloop.c (_dbus_loop_iterate): use static arrays up
	to some fixed size of file descriptor array. Don't return TRUE
	anytime a timeout exists, that led to lots of busy loop silliness
	in the tests.

1370 1371 1372 1373 1374
2003-04-09  Havoc Pennington  <hp@redhat.com>

	* dbus/dbus-mainloop.c (check_timeout): fix timeouts, I thought
	I'd checked this in earlier but hadn't.

Havoc Pennington's avatar
-  
Havoc Pennington committed
1375 1376 1377 1378 1379
2003-04-09  Havoc Pennington  <hp@redhat.com>

	* bus/dispatch.c (bus_dispatch_test): get a bit further through
	the activation test (man this is getting old!)

1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399
2003-04-09  Havoc Pennington  <hp@redhat.com>

	* test/test-utils.c: use dispatch status function to fix this up

	* bus/connection.c (connection_watch_callback): don't dispatch
	from here
	(connection_timeout_callback): don't dispatch from here
	(bus_connections_setup_connection): set the dispatch status function
	(bus_connection_disconnected): unset it

	* dbus/dbus-mainloop.c (_dbus_loop_queue_dispatch): new function
	used to add a connection to be dispatched
	(_dbus_loop_iterate): do the dispatching at the end of each
	iteration

	* dbus/dbus-connection.c
	(dbus_connection_set_dispatch_status_function): new function
	allowing us to fix up main loop usage
	(_dbus_connection_last_unref): free all the various function
	user data
1400
	(dbus_connection_dispatch): call the DispatchStatusFunction
1401 1402 1403 1404 1405 1406
	whenever this function returns
	(dbus_connection_handle_watch): call DispatchStatusFunction
	(dbus_connection_send_with_reply_and_block): call DispatchStatusFunction
	(reply_handler_timeout): call DispatchStatusFunction
	(dbus_connection_flush): call DispatchStatusFunction

1407 1408
2003-04-09  Havoc Pennington  <hp@redhat.com>

1409
	* dbus/dbus-bus.c (dbus_bus_register): fix up error handling and
1410 1411 1412 1413 1414 1415 1416 1417 1418 1419
	a memory leak

	* bus/dispatch.c (check_service_activated): fix bug in test

	* dbus/dbus-mainloop.c (check_timeout): fix this up

	* dbus/dbus-internals.c (_dbus_verbose_real): include PID in
	verbose output so we can sort out output from different processes,
	e.g. in the activation case.

1420
2003-04-08  Colin Walters  <walters@gnu.org>
1421

1422 1423 1424 1425
 	* bus/bus.c (struct BusContext) [pidfile]: New member, to store
 	the pid file.
 	(bus_context_new): Set it.
 	(bus_context_unref): Use it to delete the pid file.
1426

1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441
2003-04-08  Havoc Pennington  <hp@redhat.com>

	* test/data/invalid-messages/array-with-mixed-types.message:
	regression test that fails for the moment

	* dbus/dbus-test.c (dbus_internal_do_not_use_run_tests): reorder
	tests for convenience

	* dbus/dbus-marshal.c (_dbus_marshal_validate_arg): don't allow
	array of nil, it broke things.

	* test/data/invalid-messages/array-of-nil.message: regression test

	* test/data/valid-messages/array-of-array-of-uint32.message:
	happened to write this so added it to suite
1442

1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 </