1. 06 Jul, 2018 4 commits
    • Jon Turney's avatar
      vma/tests: Fix compilation if limits.h defines PAGE_SIZE (v2) · b3a42fa0
      Jon Turney authored
      per POSIX, limits.h may define PAGE_SIZE when the value is not indeterminate
      
      v2: just change the variable name, since there's no intended correlation
      here between this value and the machine's actual page size.
      Signed-off-by: Jon Turney's avatarJon Turney <jon.turney@dronecode.org.uk>
      Reviewed-by: D Scott Phillips's avatarScott D Phillips <scott.d.phillips@intel.com>
      b3a42fa0
    • Samuel Pitoiset's avatar
      radv: fix emitting the view index on GFX9 · 85865dbe
      Samuel Pitoiset authored
      For merged shaders, VS as HS for example.
      
      Cc: <mesa-stable@lists.freedesktop.org>
      Signed-off-by: Samuel Pitoiset's avatarSamuel Pitoiset <samuel.pitoiset@gmail.com>
      Reviewed-by: Bas Nieuwenhuizen's avatarBas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
      85865dbe
    • Ian Romanick's avatar
      i965/vec4: Make the vec4_visitor::nir_emit_instr default case unreachable · 965a06db
      Ian Romanick authored
      The bug fixed by the previous commit went undetected because extra
      stderr messages are not flagged by the CI.  Copy the solution from
      fs_visitor::nir_emit_instr and mark the default case unreachable.
      
      An alternate solution is to delete the default case so that the compiler
      will issue a warning.  That may require more work since there are other
      (impossible) cases that exist.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
      965a06db
    • Ian Romanick's avatar
      intel/compiler: More DCE after lowering · a4d47873
      Ian Romanick authored
      Some of the lowering passes, nir_lower_locals_to_regs for example, can
      cause some previously live code to be dead.  This pass in particular
      leaves a bunch of nir_instr_type_deref instructions floating around.
      This causes shader-db runs on Gen5 through Haswell to spew tons of
      messages like:
      
          VS instruction not yet implemented by NIR->vec4
      
      UnrealEngine4/EffectsCaveDemo/239.shader_test is one shader that
      generates these messages.  Cleaning up the dead code fixes that.
      
      To verify, I did a shader-db before and after.  Even though all the
      messages are gone, the results make my brain hurt. :(
      
      Haswell
      total cycles in shared programs: 411890163 -> 411891145 (<.01%)
      cycles in affected programs: 57016 -> 57998 (1.72%)
      helped: 3
      HURT: 11
      helped stats (abs) min: 2 max: 154 x̄: 96.67 x̃: 134
      helped stats (rel) min: 0.08% max: 2.23% x̄: 1.42% x̃: 1.96%
      HURT stats (abs)   min: 18 max: 686 x̄: 115.64 x̃: 20
      HURT stats (rel)   min: 0.81% max: 7.12% x̄: 1.87% x̃: 0.93%
      95% mean confidence interval for cycles value: -51.39 191.67
      95% mean confidence interval for cycles %-change: -0.14% 2.46%
      Inconclusive result (value mean confidence interval includes 0).
      
      Ivy Bridge
      total cycles in shared programs: 259114802 -> 259115032 (<.01%)
      cycles in affected programs: 24034 -> 24264 (0.96%)
      helped: 1
      HURT: 9
      helped stats (abs) min: 2 max: 2 x̄: 2.00 x̃: 2
      helped stats (rel) min: 0.08% max: 0.08% x̄: 0.08% x̃: 0.08%
      HURT stats (abs)   min: 18 max: 48 x̄: 25.78 x̃: 20
      HURT stats (rel)   min: 0.80% max: 1.94% x̄: 1.08% x̃: 0.80%
      95% mean confidence interval for cycles value: 12.42 33.58
      95% mean confidence interval for cycles %-change: 0.54% 1.38%
      Cycles are HURT.
      Signed-off-by: default avatarIan Romanick <ian.d.romanick@intel.com>
      Fixes: 5a02ffb7 nir: Rework lower_locals_to_regs to use deref instructions
      Reviewed-by: Jason Ekstrand's avatarJason Ekstrand <jason@jlekstrand.net>
      a4d47873
  2. 05 Jul, 2018 36 commits