Commit 4e880d4d authored by Zaheer Abbas Merali's avatar Zaheer Abbas Merali Committed by Sebastian Dröge
Browse files

collectpads: Don't unref NULL GstCollectData

If a pad is removed while a collectpads element (say adder) is in a chain
function waiting to be collected, there is a possibility that an unref happens
on a NULL pointer.
parent 1125b9a9
......@@ -2058,7 +2058,9 @@ gst_collect_pads_chain (GstPad * pad, GstObject * parent, GstBuffer * buffer)
unref_data (data);
/* data is definitely NULL if pad_removed goto was run. */
if (data)
unref_data (data);
if (buffer)
gst_buffer_unref (buffer);
return ret;
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment