François Laignel authored Apr 21, 2021 and Sebastian Dröge committed May 05, 2021

Instead of the deprecated gst_element_get_request_pad.

Part-of: <gstreamer/gst-editing-services!240>

Sync with gst-launch, as g_print* will print broken string on Windows.
See also
gstreamer/gstreamer!258

Part-of: <gstreamer/gst-editing-services!245>

Seungha Yang authored Apr 23, 2021 and GStreamer Marge Bot committed Apr 23, 2021

framepositioner will not touch raw video data and therefore should
be able to accept ANY caps features

Part-of: <gstreamer/gst-editing-services!243>

In gst_frame_positioner_init, there was the magic number 1
when assigning the default value of the operator. Now it
has the default value for the operator pulled from the
compositor.

Part-of: <gstreamer/gst-editing-services!241>

The 'operator' property was added to gstframepositioner so that
blending modes in the compositor could be accessed. This was done
by accessing the pad of the compositor class, and referencing the
'operator' property in that pad. Getters and Setters were also
created so that the 'operator' could be accessed by software that
is based on GES, such as Pitivi.

Related to but does not close Issue
https://gitlab.gnome.org/GNOME/pitivi/-/issues/2313

Part-of: <gstreamer/gst-editing-services!236>

GstCaps is not a GObject!

Part-of: <gstreamer/gst-editing-services!238>

Part-of: <gstreamer/gst-editing-services!235>

volatile is not sufficient to provide atomic guarantees and real atomics
should be used instead.  GCC 11 has started warning about using volatile
with atomic operations.

https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719

Discovered in gstreamer/gst-plugins-good#868

Part-of: <gstreamer/gst-editing-services!234>

Otherwise we might en up having a group which is not backed by any asset
leading to possible assertion as this should never happen (see
https://gitlab.gnome.org/GNOME/pitivi/-/issues/2526)

Part-of: <gstreamer/gst-editing-services!232>

Update the validate expectation for videoconvert caps changes in
gstreamer/gst-plugins-base!1033

Part-of: <gstreamer/gst-editing-services!229>

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

Make use of the new 'timeline specification' support in .validatetest
files.

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

So it is serialized on `--save`

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

We need to register it for all subclasses.

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

This way the command line formatter actually uses an URI and not
an ugly hack where were passing a random string instead of an URI.
This also allows the `gessrc` element to handle timelines described
in its URI meaning that you can now use, for example:

   gst-play-1.0 "ges:+test-clip blue d=4.0

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

So it can be reused in the command line formatter.

Part-of: <gstreamer/gst-editing-services!227>

Used to set properties or keyframes

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

Cleaning up the code and making everything simpler.

Part-of: <gstreamer/gst-editing-services!227>

Part-of: <gstreamer/gst-editing-services!227>

Instead of having it all handled by the tool, this way we can
set the restriction before clips are added to the timeline,
leading to better behavior in term of video images placement
in the scene.

Without that we would have the clips positioned before setting the
restriction caps which leads to weird behavior for the end users.

Part-of: <gstreamer/gst-editing-services!227>

We had cases where the frame positioner had the default natural size for
video test sources instead of the user provided one.

Part-of: <gstreamer/gst-editing-services!227>

It looks like the _set_rendering_details call is superfluous
in _startup(), as it will get called in run_pipeline.

The problem with calling it before timeline_set_user_options
is that we are going to fail creating a smart profile if
the user selected eg --track-types=video, as the get_smart_profile
method compares the tracks in the asset with those on the timeline.

Reproduce with a video-only clip:

ges-launch-1.0 --track-types=video +clip file://$PWD/jelly.mp4 \
inpoint=15.0 -o foo.mp4 --smart-rendering

Part-of: <gstreamer/gst-editing-services!228>

Henry Wilkes authored Oct 29, 2019 and GStreamer Marge Bot committed Jan 26, 2021

Force a string type for structure values obtained through parsing a
serialized timeline by inserting a (string) specifier after a '=',
rather than relying on gst_structure_from_string guessing the type.

As such, the functions that extract clocktimes and properties are
modified to accept string value types.

Part-of: <gstreamer/gst-editing-services!123>

Henry Wilkes authored Oct 29, 2019 and GStreamer Marge Bot committed Jan 26, 2021

Part-of: <gstreamer/gst-editing-services!123>

Henry Wilkes authored Oct 18, 2019 and GStreamer Marge Bot committed Jan 26, 2021

Changed deserialize method to actually reverse the serialize method by
removing the edge quote marks and reversing g_strescape.

See gstreamer/gstreamer#452

Part-of: <gstreamer/gst-editing-services!123>

Thibault Saunier authored Dec 13, 2020 and GStreamer Marge Bot committed Jan 23, 2021

The issue is that we rely on `decodebin::autoplug-select` to `SKIP`
unwanted pads, that signal was first provided to select factories during
autoplugin, not totally thought to avoid exposing pads. For streams
muxed directly in raw, decodebin has nothing to plug after the demuxer
and the pad is exposed right away, meaning that we do not have any
chance to avoid that pad to be exposed. This patch takes that limitation
into account and checks the stream ID of the pads exposed by decodebin
before exposing them itself, so we end up using the right pad even if
more are uselessly exposed by decodebin.

Fixes gstreamer/gst-editing-services#126

Part-of: <gstreamer/gst-editing-services!222>

Avoiding not negotiated errors in specific cases.

Part-of: <gstreamer/gst-editing-services!225>

We were unreffing something we were not owning

Part-of: <gstreamer/gst-editing-services!224>

Jan Schmidt authored Nov 02, 2020 and GStreamer Marge Bot committed Dec 15, 2020

This is the same fix that was applied in gst-plugins-good in
gstreamer/gst-plugins-good!603
and fixes the testsuite running in gst-build.

Part-of: <gstreamer/gst-editing-services!219>

Part-of: <gstreamer/gst-editing-services!209>