1. 30 Nov, 2021 2 commits
    • Guido Günther's avatar
      Don't compare signed and unsigned int · 06057c6e
      Guido Günther authored and James Hilliard's avatar James Hilliard committed
        CC       cups_pk_helper_mechanism-cups.o
      cups.c: In function ‘cph_cups_printer_class_rename’:
      cups.c:2272:39: error: comparison between signed and unsigned integer
      expressions [-Werror=sign-compare]
                               for (i = 0; i < g_strv_length (member_names); i++) {
                                             ^
      cups.c:2331:39: error: comparison between signed and unsigned integer
      expressions [-Werror=sign-compare]
                               for (i = 0; i < g_strv_length (member_names); i++) {
                                             ^
      06057c6e
    • Guido Günther's avatar
      Add default statements to silence compiler warnings · a4f58a9b
      Guido Günther authored and James Hilliard's avatar James Hilliard committed
      cups-pk-helper-mechanism.c: In function ‘cph_mechanism_job_set_hold_until’:
      cups-pk-helper-mechanism.c:1402:9: error: switch missing default case
      [-Werror=switch-default]
               switch (job_status) {
               ^
      cc1: all warnings being treated as errors
      a4f58a9b
  2. 04 May, 2021 1 commit
  3. 27 Apr, 2021 3 commits
  4. 09 Apr, 2021 1 commit
  5. 08 Apr, 2019 3 commits
  6. 29 Aug, 2018 1 commit
  7. 12 Apr, 2018 1 commit
  8. 03 Feb, 2016 3 commits
  9. 28 Jan, 2016 1 commit
  10. 17 Dec, 2015 1 commit
  11. 12 Nov, 2015 1 commit
  12. 07 Jun, 2013 3 commits
  13. 01 Mar, 2013 2 commits
  14. 08 Feb, 2013 2 commits
  15. 10 Dec, 2012 2 commits
    • Vincent Untz's avatar
      Document our source for validating printer names · 810b0495
      Vincent Untz authored
      Since the change that got reverted was justified by some cups
      documentation, it's important to clearly document where the current
      validation scheme comes from (lpadmin man page and cups source).
      
      Also, fix the size check: the cups source code limits this to 127.
      810b0495
    • Vincent Untz's avatar
      Revert "Be stricter when validating printer names" · f00aee0b
      Vincent Untz authored
      Apparently, this is way too strict. The lpadmin man page says:
      
        CUPS allows printer names to contain any printable character except
        SPACE, TAB, "/", or  "#".
      
      So the previous code was (mostly) correct.
      
      This reverts commit 7bf9cbe4.
      f00aee0b
  16. 12 Oct, 2012 5 commits
  17. 10 Oct, 2012 2 commits
    • Vincent Untz's avatar
      Also change supplementary groups when changing effective uid/gid · a397b908
      Vincent Untz authored
      Thanks to Alexander Peslyak <solar@openwall.com> and Sebastian Krahmer
      <krahmer@suse.de> for catching this.
      
      Part of fix for CVE-2012-4510.
      a397b908
    • Vincent Untz's avatar
      Fix a bunch of issues when getting/putting a file from cups · 6995d308
      Vincent Untz authored
      There was basically no check for permissions. Now, we temporarily change
      our effective uid/gid to the one of the user to open the file for
      writing (when getting) or reading (when putting). We then only use
      operations that work on the file descriptor to avoid potential race
      conditions.
      
      Before that, people could:
       - overwrite any file with the content of a cups resource
       - put any file in a cups resource
      
      Part of fix for CVE-2012-4510.
      6995d308
  18. 04 Oct, 2012 1 commit
  19. 03 Oct, 2012 2 commits
  20. 02 Oct, 2012 1 commit
  21. 27 Mar, 2012 2 commits