GitLab

Guido Günther authored Jul 21, 2016 and James Hilliard committed Nov 29, 2021

  CC       cups_pk_helper_mechanism-cups.o
cups.c: In function ‘cph_cups_printer_class_rename’:
cups.c:2272:39: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
                         for (i = 0; i < g_strv_length (member_names); i++) {
                                       ^
cups.c:2331:39: error: comparison between signed and unsigned integer
expressions [-Werror=sign-compare]
                         for (i = 0; i < g_strv_length (member_names); i++) {
                                       ^

Guido Günther authored Jul 21, 2016 and James Hilliard committed Nov 29, 2021

cups-pk-helper-mechanism.c: In function ‘cph_mechanism_job_set_hold_until’:
cups-pk-helper-mechanism.c:1402:9: error: switch missing default case
[-Werror=switch-default]
         switch (job_status) {
         ^
cc1: all warnings being treated as errors

This is not needed as we require CUPS 1.6 and newer now.

These are not needed as we require glib 2.36 and newer now.

Use meson build system instead of autoconf tools.

Set dependency on CUPS 1.6 and newer and glib 2.36 and newer
so we can remove some compatibility code.

worldofpeace authored Sep 15, 2019 and Marek Kasik committed Apr 09, 2021

Since D-Bus 1.9.18 configuration files installed by third-party should
go in share/dbus-1/system.d. The old location is for sysadmin overrides.

Added Friulian translation.
Updated Croatian and Kazakh translations.

This commit adds ability to process IPP_TAG_NAME and
IPP_TAG_TEXT values which contain UTF-8 characters.
This is required by RFC 2911 and CUPS is able to handle
such strings.
Users will be able to handle printers with names containing
printable UTF-8 characters now.

https://bugzilla.redhat.com/show_bug.cgi?id=982727

Pino Toscano authored Jan 12, 2013 and Marek Kasik committed Jan 28, 2016

PATH_MAX is optional in POSIX, and not provided on GNU/Hurd;
due to the shotcoming of cupsTempFile2(), a dynamically allocated buffer cannot be provided,
so define CPH_PATH_MAX as PATH_MAX (or 1024, if not available), and use it.

https://bugs.freedesktop.org/show_bug.cgi?id=59263

Martin Hatina authored Nov 10, 2015 and Marek Kasik committed Nov 12, 2015

New method PrinterRename for printer renaming, it actually deletes old printer
and add new one. It is also possible to rename classes and their members.

https://bugs.freedesktop.org/show_bug.cgi?id=92463

He made enough significant changes to be listed there!

Marek now has all the access rights to maintain cups-pk-helper, so I'm
not needed anymore :-)

He agreed to step up, that's great news!

Since the change that got reverted was justified by some cups
documentation, it's important to clearly document where the current
validation scheme comes from (lpadmin man page and cups source).

Also, fix the size check: the cups source code limits this to 127.

Apparently, this is way too strict. The lpadmin man page says:

  CUPS allows printer names to contain any printable character except
  SPACE, TAB, "/", or  "#".

So the previous code was (mostly) correct.

This reverts commit 7bf9cbe4.

This really fixes build with CUPS >= 1.6, this time.

Thanks to Jürg Billeter <j@bitron.ch> for spotting the issue.

Thanks to Alexander Peslyak <solar@openwall.com> and Sebastian Krahmer
<krahmer@suse.de> for catching this.

Part of fix for CVE-2012-4510.

There was basically no check for permissions. Now, we temporarily change
our effective uid/gid to the one of the user to open the file for
writing (when getting) or reading (when putting). We then only use
operations that work on the file descriptor to avoid potential race
conditions.

Before that, people could:
 - overwrite any file with the content of a cups resource
 - put any file in a cups resource

Part of fix for CVE-2012-4510.

Jiri Popelka authored Jul 19, 2012 and Vincent Untz committed Oct 03, 2012

CUPS 1.6 makes various structures private and introduces ippGet*
and ippSet* functions for all of the fields in these structures.
See http://www.cups.org/str.php?L3928

For compatibility with CUPS < 1.6, we manually define the needed
accessors if building against the old CUPS.

https://bugs.freedesktop.org/show_bug.cgi?id=52265

Only alphanumerical characters and the underscore are valid, and the
name must not be longer than 127 characters. See
http://www.cups.org/documentation.php/doc-1.1/sam.html#4_1