We don't have any signals or slots at the moment but add the keyword so
if we ever add them it's using the Q_SIGNAL/Q_SLOT variant so we don't
get collisions with other people that use signal/slot

Albert Astals Cid authored Nov 03, 2018 and Albert Astals Cid committed Nov 07, 2018

Scopes the entry variable so people don't try to use it in between

Adam Reichold authored Nov 06, 2018 and Albert Astals Cid committed Nov 06, 2018

Closes #660

Adam Reichold authored Nov 06, 2018 and Albert Astals Cid committed Nov 06, 2018

Closes #661

Closes #659

Christian Persch authored Oct 23, 2018 and Albert Astals Cid committed Nov 03, 2018

PopplerAttachmentPrivate has a Object member which
was never destructed, only set to an empty Object()
on dispose. While there is no memory leak (currently!),
this is still not correct.

Fix this by making  PopplerAttachmentPrivate a C++ class,
constructed in place of the gobject instance private in
init(), and call the destructor explicitly in finalize().

fixes oss-fuzz/11244

Marek Kasik authored Oct 29, 2018 and Albert Astals Cid committed Nov 02, 2018

Mark objects being processed in Parser::makeStream() as being processed
and check the mark when entering this method to avoid processing
of the same object recursively.

When a checkbox had no /AP key (which is not mandatory)
poppler was silently ignoring the setState() call that
changes the checked/unchecked state.

Fixed by using getOnStr() instead of accessing onStr
directly, as the former has code in place to return
correct values when the field is a checkbox and has
no names for the On/Off states (as a result of not
having the /AP key which could contain those names).

A testcase is included. An example definition of an
affected checkbox follows:

/F 4
/FT /Btn
/H /P
/MK /BC [1,0,0] /BG [1,1,1] /CA (4)
/Q 0
/Rect [235.277,654.247,249.224,668.194]
/Subtype /Widget
/T (basiccheckbox)
/Type /Annot
/V /Off

Fixes issue #655

to avoid using PS memory on cairo >= 1.5.10

oss-fuzz/11195

The approach is slightly different to GooList as it reimplements GooString in terms of
std::string but keeps its interface intact and does expose any std::string functionality
as of now.

This is done since GooString has a significantly larger API surface and exposing both API
would be quite confusing with with some overloads from GooString and some from std::string
being visible. But it does mean we can align the API (they are already pretty close) and
expose new things like a reserve method piece by piece.

It also already helps in that the implementation of GooString is gone except for the
original parts, i.e. the formatting, and we have zero cost conversion from/to std::string
which should help in making more use of it elsewhere. It also gives us do-nothing-access
to optimizations done for the standard library, e.g. word-level implementations of
cmp and friends.

(Note that the resulting GooString.cc is a bit funny as the formatting helper are now
local to the translation unit, but I had to redeclare them to keep the diff small as
I did not change them at all. But if this is done, they could probably just be moved to
where the declarations are to make the source file more readable.)

Alistair Thomas authored Feb 12, 2018 and Germán Poo-Caamaño committed Oct 26, 2018

The GIDL format was the pre-cursor to the GObject Introspection
Repository (GIR) format. Poppler has used GIR for a long time now.

Adam Reichold authored Sep 01, 2018 and Albert Astals Cid committed Oct 25, 2018

Add fuzzer target from oss-fuzz project and integrate it into the build system via FUZZER CMake variable.

Oliver Sander authored Oct 21, 2018 and Albert Astals Cid committed Oct 23, 2018

These are just non-standard names for bool, true, false, respectively.
Getting rid of these names saves on layer of mental redirection,
and enables proper syntax highlighting in editors.

Elliott Sales de Andrade authored Oct 21, 2018 and Albert Astals Cid committed Oct 23, 2018

Removing localtime_r allows the demo to be built on Windows.

Elliott Sales de Andrade authored Oct 21, 2018 and Albert Astals Cid committed Oct 23, 2018

dnf replaced yum a few releases ago.

Elliott Sales de Andrade authored Oct 21, 2018 and Albert Astals Cid committed Oct 23, 2018

There's no reason it can't be available (either natively, or when
cross-compiling with mingw).