Elliott Sales de Andrade authored Oct 21, 2018 and Albert Astals Cid committed Nov 18, 2018

In Python 3, exceptions must derive from the BaseException class, which
Printer definitely does not do.

Fixes issue #669

Make GooString constructible and assignable from null pointers again since some of the code expects it.

fixes oss-fuzz/9614

AnnotLine::initialize used to look for strings, which is wrong,
because PDF reference says "LE [...] An array of two names".

And don't feel like investigating why

Oliver Sander authored Nov 09, 2018 and Albert Astals Cid committed Nov 11, 2018

This is the name used by std::string.

Tobias Deiminger authored Nov 02, 2018 and Albert Astals Cid committed Nov 11, 2018

Line endings are already parsed from /LE array and are gettable and
settable as enum value in current APIs.

With this commit we implement the drawing operations so that line
endings become actually visible when document is rendered.

Enables levels 0, 1 and 2, along with some manual ones
Disables non-pod-globa-static, StructElement would need some rework to
fix it and it's only a bit about optimization of start time, we can live
with it

Albert Astals Cid authored Nov 07, 2018 and Albert Astals Cid committed Nov 09, 2018

Since they are part of the API

Albert Astals Cid authored Nov 07, 2018 and Albert Astals Cid committed Nov 09, 2018

Makes clazy happier

We don't have any signals or slots at the moment but add the keyword so
if we ever add them it's using the Q_SIGNAL/Q_SLOT variant so we don't
get collisions with other people that use signal/slot

Albert Astals Cid authored Nov 03, 2018 and Albert Astals Cid committed Nov 07, 2018

Scopes the entry variable so people don't try to use it in between

Adam Reichold authored Nov 06, 2018 and Albert Astals Cid committed Nov 06, 2018

Closes #660

Adam Reichold authored Nov 06, 2018 and Albert Astals Cid committed Nov 06, 2018

Closes #661

Closes #659

Christian Persch authored Oct 23, 2018 and Albert Astals Cid committed Nov 03, 2018

PopplerAttachmentPrivate has a Object member which
was never destructed, only set to an empty Object()
on dispose. While there is no memory leak (currently!),
this is still not correct.

Fix this by making  PopplerAttachmentPrivate a C++ class,
constructed in place of the gobject instance private in
init(), and call the destructor explicitly in finalize().