Commit 82b91c56 authored by Albert Astals Cid's avatar Albert Astals Cid Committed by Albert Astals Cid
Browse files

exclude some function-args-by-value and function-args-by-ref

Since they are part of the API
parent 1ac74b47
...@@ -4011,7 +4011,7 @@ QPointF LinkAnnotation::linkRegionPoint( int id ) const ...@@ -4011,7 +4011,7 @@ QPointF LinkAnnotation::linkRegionPoint( int id ) const
return d->linkRegion[id]; return d->linkRegion[id];
} }
void LinkAnnotation::setLinkRegionPoint( int id, const QPointF &point ) void LinkAnnotation::setLinkRegionPoint( int id, const QPointF &point ) // clazy:exclude=function-args-by-value
{ {
if ( id < 0 || id >= 4 ) if ( id < 0 || id >= 4 )
return; return;
......
...@@ -770,6 +770,7 @@ class POPPLER_QT5_EXPORT LinkAnnotation : public Annotation ...@@ -770,6 +770,7 @@ class POPPLER_QT5_EXPORT LinkAnnotation : public Annotation
void setLinkHighlightMode( HighlightMode mode ); void setLinkHighlightMode( HighlightMode mode );
QPointF linkRegionPoint( int id ) const; QPointF linkRegionPoint( int id ) const;
// TODO Next ABI break, remove ref from point
void setLinkRegionPoint( int id, const QPointF &point ); void setLinkRegionPoint( int id, const QPointF &point );
private: private:
......
...@@ -430,7 +430,7 @@ class LinkMoviePrivate : public LinkPrivate ...@@ -430,7 +430,7 @@ class LinkMoviePrivate : public LinkPrivate
} }
// LinkGoto // LinkGoto
LinkGoto::LinkGoto( const QRectF &linkArea, QString extFileName, const LinkDestination & destination ) LinkGoto::LinkGoto( const QRectF &linkArea, QString extFileName, const LinkDestination & destination ) // clazy:exclude=function-args-by-ref
: Link( *new LinkGotoPrivate( linkArea, destination ) ) : Link( *new LinkGotoPrivate( linkArea, destination ) )
{ {
Q_D( LinkGoto ); Q_D( LinkGoto );
......
...@@ -259,6 +259,7 @@ class POPPLER_QT5_EXPORT LinkGoto : public Link ...@@ -259,6 +259,7 @@ class POPPLER_QT5_EXPORT LinkGoto : public Link
* \param extFileName if not empty, the file name to be open * \param extFileName if not empty, the file name to be open
* \param destination the destination to be reached * \param destination the destination to be reached
*/ */
// TODO Next ABI break, make extFileName const &
LinkGoto( const QRectF &linkArea, QString extFileName, const LinkDestination & destination ); LinkGoto( const QRectF &linkArea, QString extFileName, const LinkDestination & destination );
/** /**
* Destructor. * Destructor.
......
...@@ -47,7 +47,7 @@ class PageTransitionData ...@@ -47,7 +47,7 @@ class PageTransitionData
::PageTransition *pt; ::PageTransition *pt;
}; };
PageTransition::PageTransition(const PageTransitionParams &params) PageTransition::PageTransition(const PageTransitionParams &params) // clazy:exclude=function-args-by-value
{ {
data = new PageTransitionData(params.dictObj); data = new PageTransitionData(params.dictObj);
} }
......
...@@ -97,6 +97,7 @@ class POPPLER_QT5_EXPORT PageTransition { ...@@ -97,6 +97,7 @@ class POPPLER_QT5_EXPORT PageTransition {
accessed by the constructor. The object is only accessed by this accessed by the constructor. The object is only accessed by this
constructor, and may be deleted after the constructor returns. constructor, and may be deleted after the constructor returns.
*/ */
// TODO Next ABI break, make this private and remove reference
PageTransition(const PageTransitionParams &params); PageTransition(const PageTransitionParams &params);
/** \brief copy constructor */ /** \brief copy constructor */
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment