Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Christian Persch
poppler
Commits
82b91c56
Commit
82b91c56
authored
Nov 07, 2018
by
Albert Astals Cid
Committed by
Albert Astals Cid
Nov 09, 2018
Browse files
exclude some function-args-by-value and function-args-by-ref
Since they are part of the API
parent
1ac74b47
Changes
6
Hide whitespace changes
Inline
Side-by-side
qt5/src/poppler-annotation.cc
View file @
82b91c56
...
...
@@ -4011,7 +4011,7 @@ QPointF LinkAnnotation::linkRegionPoint( int id ) const
return
d
->
linkRegion
[
id
];
}
void
LinkAnnotation
::
setLinkRegionPoint
(
int
id
,
const
QPointF
&
point
)
void
LinkAnnotation
::
setLinkRegionPoint
(
int
id
,
const
QPointF
&
point
)
// clazy:exclude=function-args-by-value
{
if
(
id
<
0
||
id
>=
4
)
return
;
...
...
qt5/src/poppler-annotation.h
View file @
82b91c56
...
...
@@ -770,6 +770,7 @@ class POPPLER_QT5_EXPORT LinkAnnotation : public Annotation
void
setLinkHighlightMode
(
HighlightMode
mode
);
QPointF
linkRegionPoint
(
int
id
)
const
;
// TODO Next ABI break, remove ref from point
void
setLinkRegionPoint
(
int
id
,
const
QPointF
&
point
);
private:
...
...
qt5/src/poppler-link.cc
View file @
82b91c56
...
...
@@ -430,7 +430,7 @@ class LinkMoviePrivate : public LinkPrivate
}
// LinkGoto
LinkGoto
::
LinkGoto
(
const
QRectF
&
linkArea
,
QString
extFileName
,
const
LinkDestination
&
destination
)
LinkGoto
::
LinkGoto
(
const
QRectF
&
linkArea
,
QString
extFileName
,
const
LinkDestination
&
destination
)
// clazy:exclude=function-args-by-ref
:
Link
(
*
new
LinkGotoPrivate
(
linkArea
,
destination
)
)
{
Q_D
(
LinkGoto
);
...
...
qt5/src/poppler-link.h
View file @
82b91c56
...
...
@@ -259,6 +259,7 @@ class POPPLER_QT5_EXPORT LinkGoto : public Link
* \param extFileName if not empty, the file name to be open
* \param destination the destination to be reached
*/
// TODO Next ABI break, make extFileName const &
LinkGoto
(
const
QRectF
&
linkArea
,
QString
extFileName
,
const
LinkDestination
&
destination
);
/**
* Destructor.
...
...
qt5/src/poppler-page-transition.cc
View file @
82b91c56
...
...
@@ -47,7 +47,7 @@ class PageTransitionData
::
PageTransition
*
pt
;
};
PageTransition
::
PageTransition
(
const
PageTransitionParams
&
params
)
PageTransition
::
PageTransition
(
const
PageTransitionParams
&
params
)
// clazy:exclude=function-args-by-value
{
data
=
new
PageTransitionData
(
params
.
dictObj
);
}
...
...
qt5/src/poppler-page-transition.h
View file @
82b91c56
...
...
@@ -97,6 +97,7 @@ class POPPLER_QT5_EXPORT PageTransition {
accessed by the constructor. The object is only accessed by this
constructor, and may be deleted after the constructor returns.
*/
// TODO Next ABI break, make this private and remove reference
PageTransition
(
const
PageTransitionParams
&
params
);
/** \brief copy constructor */
...
...
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment