GitLab will be down for maintenance this Sunday 13th June, from approx 7-11am UTC. This is for a PostgreSQL migration. See the tracker issue for more informations.

Commit 1cfdd1a9 authored by Dave Airlie's avatar Dave Airlie
Browse files

modesetting: remove unnecessary error message, fix zaphod leases

I introduced this error with the MST hotplug code, but it can trigger
on zaphod setups, and is perfectly fine. There is no support for
MST/hotplug on zaphod setups currently, so we can just skip over
the dynamic connector handling here. However we shouldn't skip
over the lease handling so move it into the codepath.

Fixes: 9257b125

 ("modesetting: add dynamic connector hotplug support (MST) (v3)")
Reviewed-by: Michel Dänzer's avatarMichel Dänzer <>
Signed-off-by: default avatarDave Airlie <>
parent 9e85aa9c
......@@ -3697,7 +3697,7 @@ drmmode_handle_uevents(int fd, void *closure)
goto out;
if (mode_res->count_crtcs != config->num_crtc) {
ErrorF("number of CRTCs changed - failed to handle, %d vs %d\n", mode_res->count_crtcs, config->num_crtc);
/* this triggers with Zaphod mode where we don't currently support connector hotplug or MST. */
goto out_free_res;
......@@ -3746,15 +3746,16 @@ drmmode_handle_uevents(int fd, void *closure)
drmmode_output_init(scrn, drmmode, mode_res, i, TRUE, 0);
/* Check to see if a lessee has disappeared */
if (changed) {
/* Check to see if a lessee has disappeared */
RRGetInfo(xf86ScrnToScreen(scrn), TRUE);
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment