Skip to content

Merging the docker stuff

Hi @yookoala

I can't believe it took me so long to finally have a serious look at merging all your work with Docker for our CI. Seriously, I've done a terrible job at this, my sincere apologies for that. 😞

In any case, I'm looking at it right now, hoping to merge it all real soon. I'm starting with this repository for obvious reasons, and I've got a few questions.

  1. What is the Dockerfile symlink for? Does something really need a default here? Or can we remove it, so we don't give the impression that one OS is better supported than others?

  2. It seems that all the build-essential images get rebuild automatically by the Docker Hub every time we push to this repository, can you confirm I got this right?

  3. Can we set it up so that the images get rebuilt when the base images (i.e the ones used as FROM, for example fedora:25) are changed?

  4. I'm not sure how openSUSE Leap works, in terms of their release cycle, and I see you haven't used it anyway for the libcangjie CI, so maybe we should just remove that image? (also, neither of us uses openSUSE, I use Fedora and IIRC you use Ubuntu, so maybe we should just focus on those 2 at first)

  5. I'm not sure what those latest and latest-fedora tags are, can we remove them?

All in all, you've done a great job with all this, let me apologize once more for not looking into it in a reasonable amount of time.

Once you've answered those questions above and I understand better this build-essential repo, I'll proceed with your work on the libcangjie CI. I'll also probably replace the fedora:25 and ubuntu:16.04 images by ones based on the latest versions of their respective OS.