regression in cairo-clip-boxes.c

Sounds easy and legit. Copying from new thread on mailing list:

tobias.fle...@reduxfx.com 10:34 AM (1 hour ago) to cairo

I just noticed that between Cairo release 1.17.2 and 1.17.4, a suspicious looking always return line was added in function _cairo_clip_reduce_to_boxes() on line 526 in file cairo-clip-boxes.c :

1.17.2: static cairo_clip_t * _cairo_clip_reduce_to_boxes (cairo_clip_t *clip) { struct reduce r; cairo_clip_path_t *clip_path; cairo_status_t status;

if (clip->path == NULL)

return clip; ...

1.17.4 static cairo_clip_t * _cairo_clip_reduce_to_boxes (cairo_clip_t *clip) { struct reduce r; cairo_clip_path_t *clip_path; cairo_status_t status;

return clip; if (clip->path == NULL) return clip; ...

The additional return before the if condition practically skips the whole function. Is this intentional? Best, Toby