1. 17 Jan, 2021 2 commits
  2. 16 Jan, 2021 2 commits
  3. 15 Jan, 2021 1 commit
  4. 11 Jan, 2021 6 commits
  5. 07 Jan, 2021 2 commits
    • Uli Schlachter's avatar
      Slightly improve dealing with error snapshots · 66c99118
      Uli Schlachter authored
      An error in _cairo_surface_snapshot_copy_on_write() results in a
      snapshot in an error state and the snapshot's ->target could now point
      to a surface from _cairo_surface_create_in_error(). These surfaces e.g.
      have ->backend == NULL. Thus, anything looking at ->backend->type now
      explodes. This commit deals with two places which caused segfaults in
      this situation.
      
      There is no test case for this, because
      _cairo_surface_snapshot_copy_on_write() really is not supposed to fail.
      
      Found-while-investigating: #448Signed-off-by: Uli Schlachter's avatarUli Schlachter <psychon@znc.in>
      66c99118
    • Uli Schlachter's avatar
      Add a bounds check to cairo_cff_font_read_fdselect() · b1e81ee9
      Uli Schlachter authored
      The code in cairo-cff-subset.c parses a binary format without seeming to
      bother much with verifying the data. The result is that poppler can be
      used to cause an out-of-bounds write in cairo_cff_font_read_fdselect()
      via a crafted font file. Fix this by adding the needed length check.
      
      The other code in the file also contains lots of similar things. Since I
      cannot really fix everything properly, I'll just fix the one instance
      that was found by a fuzzer.
      
      No testcase is added, because this depends on a broken font that is
      quite large. Adding something this big to the test suite does not seem
      sensible.
      
      Fixes: #451Signed-off-by: Uli Schlachter's avatarUli Schlachter <psychon@znc.in>
      b1e81ee9
  6. 06 Jan, 2021 3 commits
  7. 04 Jan, 2021 7 commits
  8. 31 Dec, 2020 1 commit
  9. 29 Dec, 2020 1 commit
  10. 27 Dec, 2020 1 commit
  11. 26 Dec, 2020 1 commit
  12. 25 Dec, 2020 4 commits
  13. 24 Dec, 2020 1 commit
  14. 23 Dec, 2020 1 commit
  15. 22 Dec, 2020 1 commit
  16. 19 Dec, 2020 1 commit
    • Uli Schlachter's avatar
      autoconf: Reject --enable-xml --disable-png · a012540d
      Uli Schlachter authored
      The xml surface depends on png. Before this commit, configuring with
      autogen.sh --disable-png --disable-svg --enable-xml resulted in a
      failing build:
      
      src/cairo-xml-surface.c: In function ‘_cairo_xml_emit_image’:
      src/cairo-xml-surface.c:673:14: error: implicit declaration of function
      ‘cairo_surface_write_to_png_stream’
      
      After this commit, configure instead rejects this combination with:
      
      checking whether cairo's xml surface backend feature could be enabled... no (requires --enable-png)
      configure: error:  xml surface backend feature could not be enabled
      
      Noticed-at: !67 (comment 644347)Signed-off-by: Uli Schlachter's avatarUli Schlachter <psychon@znc.in>
      a012540d
  17. 15 Dec, 2020 5 commits