Skip to content
  • Taylor R Campbell's avatar
    Avoid misuse of ctype(3) · 7dfde9b7
    Taylor R Campbell authored and Akira TAGOH's avatar Akira TAGOH committed
    The ctype(3) functions take arguments of type int that are either
    
    (a) EOF, or
    (b) unsigned char values, {0, 1, 2, ..., 255} if char is 8-bit.
    
    Passing values of type char, on platforms where it is signed, can go
    wrong -- negative values may be confused with EOF (typically -1) or
    may lead to undefined behaviour ranging in practice from returning
    garbage data (possibly out of an adjacent buffer in memory that may
    contain secrets) to crashing with SIGSEGV (if the page preceding the
    ctype table is unmapped).
    
    The ctype(3) functions can't themselves convert to unsigned char
    because then they would give the wrong answers for EOF, for use with
    functions like getchar and fgetc; the user has to cast char to
    unsigned char.
    7dfde9b7