1. 28 Nov, 2018 5 commits
  2. 27 Nov, 2018 9 commits
    • Christian Kellner's avatar
      boltctl: free 'label' in print_device · d5c1ec99
      Christian Kellner authored
      It is dynamically allocated by bolt_device_get_display_name, so must
      be free. Thanks valgrind.
      
      ==2656== 45 bytes in 2 blocks are definitely lost in loss record 641 of 1,149
      ==2656==    at 0x483880B: malloc (vg_replace_malloc.c:299)
      ==2656==    by 0x48CFFA5: g_malloc (gmem.c:99)
      ==2656==    by 0x48EA2A2: g_strdup (gstrfuncs.c:363)
      ==2656==    by 0x40A68C: bolt_device_get_display_name (bolt-device.c:583)
      ==2656==    by 0x410C17: print_device (boltctl.c:190)
      ==2656==    by 0x40E914: list_devices (boltctl-list.c:66)
      ==2656==    by 0x4051AE: main (boltctl.c:386)
      d5c1ec99
    • Christian Kellner's avatar
      boltctl: add salting for '--uuid=alias' option · 1b9fe4b5
      Christian Kellner authored
      When the alias option is used to format uuids, a SHA1 hash is used
      to hide the identity of the unique ids (UUIDS). Add salting to that
      hashing operation, so that hashes can not be pre-computed. Probably
      not really needed but does not hurt much either.
      1b9fe4b5
    • Christian Kellner's avatar
      test: integration: adjustment of default policy · 7f97a666
      Christian Kellner authored
      When enrolling an already authorized device with the 'default'
      policy, make sure we end up with the specific default of the daemon.
      7f97a666
    • Christian Kellner's avatar
      manager: properly adjust 'default' policy · 7ee10f09
      Christian Kellner authored
      When enrolling an already authorized device and the client supplied
      BOLT_POLICY_DEFAULT, adjust that to the global default policy.
      7ee10f09
    • Christian Kellner's avatar
      manager: slightly more useful log message · 6ee6bfbf
      Christian Kellner authored
      Include the policy in the log message when enrolling devices that
      were already authorized.
      6ee6bfbf
    • Christian Kellner's avatar
      test: integration: whitespace fixes · 67a3419a
      Christian Kellner authored
      PEP-8 please, kthxbye.
      67a3419a
    • Christian Kellner's avatar
      test: integration: properly initialize local var · 86495439
      Christian Kellner authored
      Typo in the variable and a dynamic language. That is what I get for
      not fixing the python language server before making changes to the
      python code.
      86495439
    • Christian Kellner's avatar
      test: journal: don't 'exit' but return from fork · b49a45ec
      Christian Kellner authored
      In the /journal/object test, a subprocess is created and at the
      end of the child process' code an exit call was made to end it.
      For some reason (not sure why) that would generate a leak warning
      for the child (generating a negative exit code), making the main
      test fail at "g_test_trap_assert_passed". Now instead we simply
      return in the child.
      
      Child leak warning when using 'exit()':
      
      ==18507==ERROR: LeakSanitizer: detected memory leaks
      
      Direct leak of 32 byte(s) in 1 object(s) allocated from:
          #0 0x7f9b8cccbc88 in realloc (/lib64/libasan.so.5+0xefc88)
          #1 0x7f9b8cb1105d in g_realloc (/lib64/libglib-2.0.so.0+0x5405d)
      b49a45ec
    • Christian Kellner's avatar
      test: exported: free the CallCtx struct · d0626820
      Christian Kellner authored
      In call_ctx_free, all the resources associated with the CallCtx
      were freed, but not the struct itself, which also was dynamically
      allocated.
      
      Direct leak of 24 byte(s) in 1 object(s) allocated from:
          #0 0x7f3b56061a50 in __interceptor_calloc (/lib64/libasan.so.5+0xefa50)
          #1 0x7f3b55ea6ffd in g_malloc0 (/lib64/libglib-2.0.so.0+0x53ffd)
          #2 0x409a95 in test_exported_props ../tests/test-exported.c:806
          #3 0x7f3b55ec91a9  (/lib64/libglib-2.0.so.0+0x761a9)
      d0626820
  3. 26 Nov, 2018 11 commits
  4. 23 Nov, 2018 15 commits