1. 20 Sep, 2018 6 commits
  2. 18 Sep, 2018 8 commits
  3. 17 Sep, 2018 15 commits
  4. 14 Sep, 2018 7 commits
    • Christian Kellner's avatar
      power: setup io channel earlier · 325d65d3
      Christian Kellner authored
      This will prevent the fd to be leaked and not closed in case opening
      the writer side fails. Uncovered by coverity (cid 320275).
      We explicitly set the fd to -1 and add a comment, even though we
      will overwrite it in the next line again; hopefully the compiler
      will optimize it away but it makes it explicit what is going on.
      325d65d3
    • Christian Kellner's avatar
      store: don't leak va_list in error case · ddb1c37b
      Christian Kellner authored
      Redo control flow to always hit va_end. Defect uncovered by
      coverity (cids 320276, 320278, 320280).
      ddb1c37b
    • Christian Kellner's avatar
      power: properly check result of bolt_open · afe39cfa
      Christian Kellner authored
      The check was "< 1" which in this case was correct, because we
      just opened another fd, so it must be > 0, but OTOH taken by
      itself it is not correct because 0 is a valid fd. Also coverity
      complained about it (cid 320275).
      afe39cfa
    • Christian Kellner's avatar
      test: pass fd as pointer · 3444b648
      Christian Kellner authored
      The fd was passed as value, but is no passed as a pointer in the
      hope that coverity will detect this, because it was reporting the
      fd as a leaked (cid 320279).
      3444b648
    • Christian Kellner's avatar
      meson: include option to fix coverity builds · ec01a09a
      Christian Kellner authored
      Include a new meson option 'coverity' which will, if enabled, use
      the code from Peter to fix coverity builds.
      The new option needs to be manually enabled via -Dcoverity=true
      NB: CC also needs to be specified so 'ccache' is not used, otherwise
      we also get non-working results.
      ec01a09a
    • Peter Jones's avatar
      common: include fix-coverity hack · b53d3df2
      Peter Jones authored
      Original file from Peter Jones:
       https://github.com/rhboot/efivar/blob/master/src/fix_coverity.h
      
      Included with modification to the license, i.e. re-licensed to
      the same as the rest of bolt, with permission from Peter, as
      on #fedora-laptops, 13. September 2018, 22:07:
       ‹pjones› You have my permission to relabel it as LGPL 2.1+
       ‹gicmo› \o/
      b53d3df2
    • Christian Kellner's avatar
      meson: configure config.h from a template · 89665d50
      Christian Kellner authored
      Allows for greater flexibility (which will be used in the next
      following commit) and also nicer grouping; if anyone ever looks
      at it.
      89665d50
  5. 11 Sep, 2018 2 commits
  6. 10 Sep, 2018 2 commits
    • Christian Kellner's avatar
      test: integration: key upgrade checks · 40358774
      Christian Kellner authored
      Two devices, one stored with no key, the other not stored at all.
      The controller is in SECURE mode. When both devices get authorized
      the one that is stored with a key should have a new key generated
      and stored.
      40358774
    • Christian Kellner's avatar
      device: upgrade to key authorization if possible · 11b0334a
      Christian Kellner authored
      If a device gets "manually" authorized via the d-bus "Authorize"
      method, the controller is in SECURE mode, but there is currently
      not a key stored for the device, a new key will now be generated,
      if possible. The preconditions are: the device is stored and it
      allows for key authorization.
      11b0334a