1. 14 Jun, 2021 5 commits
    • Rhys Perry's avatar
      aco: adjust the condition for expanding vertex fetch data format · 1d50ef9c
      Rhys Perry authored
      
      
      Instead of avoiding out-of-bounds access, avoid creating a load larger
      than the original attribute. This should work just as well, since the only
      situations expending a load helped was because we shrunk it first.
      
      Also fixes a bug where a 3 component load (4 components with the first
      component skipped) would be incorrectly expanded to 4 components because
      the stride check would never be performed. Maybe we should avoid skipping
      the first component in some situations, but I'm not sure if it's worth
      the VGPR cost.
      
      fossil-db (vega10):
      Totals from 583 (0.39% of 149974) affected shaders:
      CodeSize: 1496848 -> 1500868 (+0.27%); split: -0.03%, +0.30%
      Instrs: 286155 -> 286575 (+0.15%); split: -0.07%, +0.22%
      Latency: 2947101 -> 2946865 (-0.01%); split: -0.23%, +0.22%
      InvThroughput: 797396 -> 797127 (-0.03%); split: -0.08%, +0.04%
      
      fossil-db (polaris10):
      Totals from 583 (0.39% of 151365) affected shaders:
      SGPRs: 38880 -> 39216 (+0.86%)
      VGPRs: 24440 -> 24356 (-0.34%)
      CodeSize: 1506808 -> 1510876 (+0.27%); split: -0.01%, +0.28%
      Instrs: 288735 -> 289167 (+0.15%); split: -0.06%, +0.21%
      Latency: 2963263 -> 2961884 (-0.05%); split: -0.24%, +0.19%
      InvThroughput: 802351 -> 801665 (-0.09%); split: -0.12%, +0.04%
      Signed-off-by: Rhys Perry's avatarRhys Perry <pendingchaos02@gmail.com>
      Reviewed-by: Daniel Schürmann's avatarDaniel Schürmann <daniel@schuermann.dev>
      Part-of: <mesa/mesa!9007>
      1d50ef9c
    • Rhys Perry's avatar
      radv,aco: use all attributes in a binding to obtain an alignment for fetch · 91f8f828
      Rhys Perry authored
      
      
      Instead of assuming scalar alignment for an attribute, we can use the
      required alignment of other attributes in a binding to expect a higher
      one.
      
      This uses the alignment of all attributes in the pipeline, not just the
      ones loaded. This can create slightly better code, but could break
      pipelines which relied on unused (and unaligned) attributes no being
      loaded. I don't think such pipelines are allowed by the spec.
      
      fossil-db (Sienna Cichlid):
      Totals from 44350 (30.32% of 146267) affected shaders:
      VGPRs: 1694464 -> 1700616 (+0.36%); split: -0.08%, +0.44%
      CodeSize: 60207184 -> 58093836 (-3.51%); split: -3.51%, +0.00%
      MaxWaves: 1175998 -> 1174948 (-0.09%); split: +0.02%, -0.11%
      Instrs: 11763444 -> 11458952 (-2.59%); split: -2.60%, +0.01%
      Latency: 70679612 -> 67062215 (-5.12%); split: -5.27%, +0.15%
      InvThroughput: 11482495 -> 11362911 (-1.04%); split: -1.20%, +0.16%
      VClause: 359459 -> 343248 (-4.51%); split: -6.36%, +1.85%
      SClause: 422404 -> 419229 (-0.75%); split: -1.17%, +0.42%
      Copies: 754384 -> 764368 (+1.32%); split: -1.74%, +3.06%
      Branches: 197472 -> 197474 (+0.00%); split: -0.03%, +0.03%
      PreVGPRs: 1215348 -> 1215503 (+0.01%)
      Signed-off-by: Rhys Perry's avatarRhys Perry <pendingchaos02@gmail.com>
      Reviewed-by: Daniel Schürmann's avatarDaniel Schürmann <daniel@schuermann.dev>
      Part-of: <mesa/mesa!9007>
      91f8f828
    • Tomeu Vizoso's avatar
      Revert "ci: Disable the iris APL jobs" · d41faa69
      Tomeu Vizoso authored
      This reverts commit 209c8297
      
      .
      
      They are stable now.
      Signed-off-by: Tomeu Vizoso's avatarTomeu Vizoso <tomeu.vizoso@collabora.com>
      Part-of: <mesa/mesa!11355>
      d41faa69
    • Iago Toral's avatar
    • Hyunjun Ko's avatar
      turnip: add missing VKAPI_ATTR/CALL · 1a773c00
      Hyunjun Ko authored
      
      Signed-off-by: Hyunjun Ko's avatarHyunjun Ko <zzoon@igalia.com>
      Part-of: <!11099>
      1a773c00
  2. 13 Jun, 2021 12 commits
  3. 12 Jun, 2021 1 commit
  4. 11 Jun, 2021 22 commits