From bc8b9a38ed8fbe10dd37909354cebe61915d57cc Mon Sep 17 00:00:00 2001
From: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Date: Tue, 11 Mar 2025 12:21:00 -0400
Subject: [PATCH] libagx: assert alignment for copies
would have exposed the bug fixed.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
---
src/asahi/libagx/copy.cl | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/asahi/libagx/copy.cl b/src/asahi/libagx/copy.cl
index 57d27e3f2f2a1..dd922fb385a3a 100644
--- a/src/asahi/libagx/copy.cl
+++ b/src/asahi/libagx/copy.cl
@@ -7,12 +7,17 @@
KERNEL(32)
libagx_fill(global uint32_t *address, uint32_t value)
{
+ assert((((uintptr_t)address) & 0x3) == 0);
+
address[cl_global_id.x] = value;
}
KERNEL(32)
libagx_copy_uint4(global uint4 *dest, global uint4 *src)
{
+ assert((((uintptr_t)dest) & 0xf) == 0);
+ assert((((uintptr_t)src) & 0xf) == 0);
+
dest[cl_global_id.x] = src[cl_global_id.x];
}
--
GitLab