- 21 May, 2019 1 commit
-
-
Aaron Plattner authored
Commit 56c0a71f incremented the GLXSERVER_VENDOR_ABI_MINOR_VERSION define, but this define was not actually being used to set glxServer.minorVersion. Update the initializer for glxServer to use the correct version numbers. Signed-off-by:
Aaron Plattner <aplattner@nvidia.com>
-
- 20 May, 2019 1 commit
-
-
On pointer enter notification, Xwayland checks for an existing pointer warp with a `NULL` sprite. In turn, `xwl_pointer_warp_emulator_maybe_lock()` checks for an existing grab and the destination window using `XYToWindow()` which does not check for the actual sprite not being `NULL`. So, in some cases, when the pointer enters the surface and there is an existing X11 grab which is not an ownerEvents grab, Xwayland would crash trying to dereference the `NULL` sprite pointer: #0 __GI_raise () #1 __GI_abort () at abort.c:79 #2 OsAbort () at utils.c:1351 #3 AbortServer () at log.c:879 #4 FatalError () at log.c:1017 #5 OsSigHandler () at osinit.c:156 #6 OsSigHandler () at osinit.c:110 #7 <signal handler called> #8 XYToWindow (pSprite=0x0, x=0, y=0) at events.c:2880 #9 xwl_pointer_warp_emulator_maybe_lock () at xwayland-input.c:2673 #10 pointer_handle_enter () at xwayland-input.c:434 Avoid the crash by simply checking for the sprite being not `NULL` in `xwl_pointer_warp_emulator_maybe_lock()` Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Bugzilla: https://bugzilla.redhat.com/1708119
-
- 18 May, 2019 5 commits
-
-
Jon Turney authored
I don't know how I feel about the promise made in 2e7f790b :)
-
Jon Turney authored
Only _sigset_t is defined by MinGW's signal.h
-
Jon Turney authored
MinGW defines SIG_BLOCK, but doesn't have signal masks, so rather than checking for SIG_BLOCK, add a configure check for sigprocmask. v2: Also add check to meson.build
-
Jon Turney authored
Include winsock.h for definition of fd_set type and select() Future work: Maybe this also needs some error checking for fd > FD_SETSIZE?
-
Jon Turney authored
I don't think an input thread can ever be useful on Windows. There is a pthread emulation, so having the thread itself isn't much of a problem. However, there is no device to wait on for Windows events, and even if we were to replace select() with WFMO, Windows wants to send events for a window to the thread which created that window. So, disable input thread by default for MinGW v2: Also add similar to meson.build
-
- 17 May, 2019 4 commits
-
-
Aaron Plattner authored
-
Add a new function, GlxServerExports::setClientScreenVendor, which will change the vendor that handles GLX requests for a screen, but only for requests from a specific client. v2: Increment the GLXVND minor version number. v3: Note the GLXVND version requirement for setClientScreenVendor. Signed-off-by:
Adam Jackson <ajax@redhat.com>
-
When GlxGetXIDMap looks up an unknown XID, it will now look up a vendor based on the screen number for the XID and the client that sent the current request. In GlxGetXIDMap, if the XID is for a regular X window, then it won't be in the (XID -> vendor) mapping, so we have to look up a vendor by screen number. With this change, GlxGetXIDMap will use the (screen -> vendor) map for whichever client sent the current request, instead of using the global (screen -> vendor) map. Since GlxGetXIDMap doesn't take a ClientPtr argument, GlxDispatchRequest will store the client for the current request in a global variable. That way, the ABI for GLXVND doesn't need to change. v2: Fix an error check in GlxDispatchRequest. Signed-off-by:
-
Each client now has its own (screen, vendor) mapping. Currently, it's just a copy of the global mapping, but later changes will allow it to change. Signed-off-by:
-
- 14 May, 2019 1 commit
-
-
Adam Jackson authored
glxc->drawPriv will be NULL if the context is direct, or if it is current but without a bound drawable. Mesa's libGL won't normally emit protocol for direct contexts for these calls, but a malign client could still crash the server.
-
- 12 May, 2019 1 commit
-
-
- 07 May, 2019 1 commit
-
-
Topi Miettinen authored
It can take some time for Xorg to start. If Xorg runs as a systemd service and other services are based on it, they have no way to determine when Xorg is really ready to accept requests. Let's use sd_notify() provided by libsystemd to signal systemd for readiness. If Xorg has not been started as a systemd service, this won't do anything. Signed-off-by:Topi Miettinen <toiwoton@gmail.com>
-
- 02 May, 2019 8 commits
-
-
Adam Richter authored
Separate each statement of the form "assert(a && b);" into "assert(a);" and "assert(b);" for more precise diagnostics, except for this clever use in drmmode_display.c where it was used to pass a hint to developers: assert(num_infos <= 32 && "update return type");
-
Suppress uninteresting warnings on OSX that we are drowning in, turned on by default in meson.
-
Unfortunately, a 'brew update' is currently needed to get the meson >= 0.46.0 required by xserver.
-
Trying to build fat binaries for multiple arches tickles a bug [1] in the framework detector in meson 0.50. Workaround this by not bothering building for x86, which is probably no great loss :S https://github.com/mesonbuild/meson/issues/5290
-
Differences from autotools: * Autotools defined NO_ALLOCA for OSX builds. I don't think we need this anymore as Xalloc.h is no longer used anywhere in the xserver. * X11.bin is linked with -u,miDCInitialize, and then libserver_mi provided to satisfy (just) that. It's been that way since the commit which added it. We can't write the equivalent in meson due to linker argument ordering issues, but do we really need to? * An explicit -Dsecure-rpc=false is required for OSX, since in meson we don't do the checks that XTRANS_SECURE_RPC_FLAGS did for the existence of the specific RPC functions required.
-
-
-
Promote the generated file containing the date & time build was configured to top-level. Rename it from xf86Build.h to buildDateTIme.h. Use it as well in XQuartz, stringize BUILD_DATE when needed.
-
- 01 May, 2019 5 commits
-
-
Adam Richter authored
hw/dmx/glxProxy/glxcmds.c CreateContext(): free glxc->real_ids and glxc in a couple of error branches, per complaints from cppcheck.
-
Adam Richter authored
hw/xfree86/os-support/linux/lnx_agp.c xf86GetAGPInfo(): free(info) in an error path, caught by cppcheck.
-
Adam Richter authored
hw/xwin/glx/indirect.c glxWinScreenProbe(): Add free(screen) that was missing from an error path. Caught by cppcheck.
-
None of this was getting compiled because we hadn't defined the macro (and aren't getting them from <GL/glxext.h> because reasons). Fix that. Fixes: xorg/xserver#684
-
Jon Turney authored
This has always been described as 'experimental' We don't think this has any users: This mode has been disabled in Cygwin packages since March 2016. We've never provided the xwinwm WM for x86_64 Cygwin. No one has even asked where the option has gone. This leaves XQuartz as the only user of the rootless extension. Remove --enable-windowswm configure option Remove multiwindowextwm stuff from Makefiles Remove -mwextwm option Remove -mwextwm from man-page and help Un-ifdef XWIN_MULTIWINDOWEXTWM v2: Remove rootless include paths Remove windowswmproto from meson.build
-
- 30 Apr, 2019 9 commits
-
-
A workaround for https://github.com/mesonbuild/meson/issues/3672 MinGW-w64 gcc has a built-in strndup, but it's not in the C library and MinGW-w64 headers don't prototype it. Don't try to use it, as that will cause an undefined reference if gcc decides that an out-of-line call is appropriate.
-
In the meson build, functions to make up for the shortcomings of libc are compiled into a separate library. We don't bother making the pixman headers available (reasonably enough) to this compilation, but they are required indirectly by dix.h. Just remove this unneeded include.
-
Most of these could be made to work, but would need to be ported off using fork and poll...
-
As configure.ac, require that clock_gettime() exists as well to use MONOTONIC_CLOCK (MinGW provides the define, but not the function)
-
-
As XTRANS_CONNECTION_FLAGS did, don't try to build unix socket support on Windows.
-
hw/xwin/meson.build:140:0: ERROR: Unknown variable "xwin_windowsdri". hw/xwin/meson.build:141:0: ERROR: Unknown variable "xwin_glx".
-
hw/vfb/meson.build:7:0: ERROR: '' is not a target.
-
Currently, this can error if dri.pc isn't found, as we can't then get the value of pkgconfig variable from it: include/meson.build:199:10: ERROR: 'dri' is not a pkgconfig dependency I think we need DRI_DRIVER_PATH (only) when building GLX, even if dri2/3 isn't enabled, so we know where to load swrast_dri.so from. (For autotools, configure.ac directly calls `pkg-config --variable=dridriverdir dri`, the backticks swallowing any error, causing the value of this define to be empty if dri.pc isn't present)
-
- 29 Apr, 2019 1 commit
-
-
Jon Turney authored
-
- 28 Apr, 2019 1 commit
-
-
Omitted from 4ad21c32
-
- 23 Apr, 2019 1 commit
-
-
Commit d8ec33fe added libglxvnd.la to Xwayland_LDFLAGS but GLX can be disabled through --disable-glx. In this case, build fails on: make[3]: *** No rule to make target '../../glx/libglxvnd.la', needed by 'Xwayland'. Stop. make[3]: *** Waiting for unfinished jobs.... Fixes: - http://autobuild.buildroot.org/results/397f8098c57fc6c88aa12dc8d35ebb1b933d52ef Signed-off-by:
Fabrice Fontaine <fontaine.fabrice@gmail.com>
-
- 20 Apr, 2019 1 commit
-
-
Diego Viola authored
Signed-off-by:Diego Viola <diego.viola@gmail.com>
-
