GitLab

virgl wants this so that it gets declaration of input arrays (Otherwise,
it does a reconstruction of the arrays when indirect indexing happens, and
it looks like perhaps that loses the interpolation qualifier).

Noticed while tracing NIR-to-TGSI shaders in
dEQP-GLES3.functional.shaders.indexing.varying_array.vec4_dynamic_loop_write_static_loop_read

I think the logic is clearer this way around, too.

glsl_to_tgsi had been emitting outputs in sorted order, and it seems virgl
has a dependency on that -- it collects outputs into an array and indexes
by the subtracting .First value of the first one seen, even if that's not
the first entry in the array.

Found missing when taking virgl on the nir-to-tgsi path.  Super broken so
far.

Just like for ntt, it's nice to be able to dump what assertion failed on
you.

They accidentally require that stores to clipdistance have a full
writemask.  This w/a means that a series of store_outputs to channels of
clipdistance would be broken, but it gets the KHR test unregressing for
now.

KHR-GL30.clip_distance.functional

Now that the TGSI frontend paths in mesa/st are gone, this code is unused.

Now that glsl-to-tgsi is gone, a bunch of this is dead.

All UBO-supporting drivers now go through the NIR path, which does a
better job of it.

Last use removed in "radeonsi: remove TGSI" this year.

Now that nir_to_tgsi exists, we can get rid of the much larger
infrastructure to support converting GLSL to TGSI.

As with the NIR-to-TGSI usage in softpipe, this comes the downside of
increased TGSI register file usage for the remaining TGSI drivers, but
with the upside of making sure every driver benefits from shared NIR
optimizations.

We failed to translate the target type, which virgl needs for translation.
Also the read_only flag is for consts, shader inputs, and uniforms.  The
access flag gives you the readonly qualifier.

This is required for virglrenderer to be able to properly size the UBOs it
declares in the GLSL it generates on the host.

This is useful information to have for a backend lowering GLSL on the
frontend to eventually-GLSL on the backend after lowering to UBO
intrinsics (such as virgl does throguh TGSI).  Without this, you don't
know how large to declare your UBO variables without duplicating this
sizing logic.

These are only used in manual runs, and I noticed in a recent run that
something on master had fixed them.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <mesa/mesa!9509>

In compat GL, the gl_FrontColor/BackColor gets clamped unless you
explicitly turn it off with ARB_color_buffer_float, and most apps doing
floating point color rendering are going to be using non-compat varyings
anyway instead of hoping that ARB_color_buffer_float exists.  Thus, guess
that the app will get clamping on the color outputs to reduce draw-time
recompiles.

Saves 60 VS recompiles on half-life-2.trace on freedreno (and similarly for
many other compat GL apps).
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <mesa/mesa!9509>

This ARB_debug_output is particularly useful in that default apitrace will
log it, so we can find when we're doing draw-time recompiles we shouldn't be.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <mesa/mesa!9509>

Fixes the following issues I can see:

- Non-VS NIR shaders not gathering info after ucp lowering
- Non-VS NIR shaders not doing GL_CLAMP lowering
- Non-VS TGSI shaders not setting up stream output state.
- Non-VS TGSI shaders leaking lower_depth_clamp lowering across variant
  compiles.
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <mesa/mesa!9509>

the push set index isn't always 0, so the offsets need to be updated
in order to avoid clobbering other sets

Fixes: 6be19765 ("lavapipe: add support for VK_KHR_push_descriptor")
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <mesa/mesa!9558>

On Gen11+ we tend to only use a single configuration, so just get rid
of the stalls in the command buffers by moving the config to device
initialization.

v2: drop NULL config check
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <mesa/mesa!9534>

We're about to reuse this at device initialization.

v2: Handle NULL configs on Gen12+

v3: Handle NULL config in emission helper (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <mesa/mesa!9534>

Specifying "early_fragment_tests" in fragment shader takes precedence
over our internal conditions.

Fixes test:
 dEQP-VK.fragment_operations.early_fragment.early_fragment_tests_stencil
Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <mesa/mesa!9569>

v2: Deal with line wrapping (Jordan)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Suggested-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <mesa/mesa!9052>

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <mesa/mesa!9052>

All this code exists in gen_device_info. It will print out the same
warning.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <mesa/mesa!9052>

gen_device_info will try to use the most recent uAPI to get this
number and will fallback to this get_param. So just use what was
queries by gen_device_info_from_fd().
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <mesa/mesa!9052>

We carry those warnings in i965/anv. Let's have them here. Next commit
we remove some code from the drivers.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <mesa/mesa!9052>

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <mesa/mesa!9052>

accidentally left this in while bisecting

Fixes: 929a7484 ("zink: avoid hashing states without descriptors")
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Acked-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <mesa/mesa!9564>

Fixes compilation on win32

Fixes: 2523c477 " turnip: Move the CreateRenderPass wrapper..."
Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <!9530>

Part-of: <mesa/mesa!9540>

this stores a number (currently 5) of backing allocations for resources
for later reuse when creating matching resources

because this is on the screen object it requires locking, but this is still
far faster than allocating new memory each time
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <mesa/mesa!9540>

Some compilers complain of the implicit conversion.
Make it explicit.

Reported by:
mesa/mesa!6121
mesa/mesa!9250Signed-off-by: Axel Davy <davyaxel0@gmail.com>
Part-of: <mesa/mesa!9563>

we can reorder the pipeline state and avoid hashing the big arrays based
on context states that we already have available to us

also we can do incremental hashes for the shader modules to further reduce
hashing

Part-of: <mesa/mesa!9539>

we can use this to optimize pipeline hashing

Part-of: <mesa/mesa!9539>

Just make sure it's initialized properly.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <mesa/mesa!9473>

some flakes here that will be resolved in the very near future
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <mesa/mesa!9348>

these need to pass a constructed array of buffers, not a single buffer per
descriptor
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <mesa/mesa!9348>

this is unnecessary hashing which decreases the accuracy of the states
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <mesa/mesa!9348>

these are always the same value, so there's no need to track them
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <mesa/mesa!9348>