GitLab

And rename section to match that of fpi-dev-img

To appease gtk-doc's struct parser, which chokes on the short name for
the data type.

See https://gitlab.gnome.org/GNOME/gtk-doc/issues/63

The API docs for fp_minutia_get_coords() as added in commit 1006467f
had the parameters in the docs not match the actual names used.

Now that this name is free. This makes all the image manipulation
functions have the same "fpi_img_" prefix.

To better match what it does. It does not resize an image, but
reallocate its internal data structure's size.

As it's not used in other parts of the library after the changes in
commit 422f81b6.

Those are not public headers, so don't need to be documented. This
removes 18 symbols from the undocumented symbols list.

This reverts commit 700c5791.

We don't need a poll setup to be able to call sync functions, which then
use async functions for implementation internally.

Closes: #124

Conflicts:
	libfprint/fpi-async.c

Otherwise the caller won't be able to call the appropriate _finish()
calls when done.

See libfprint/libfprint#119 for
the long-term plan

No period at the end of parameter docs.

No mainloop, no async.

This checks whether polling was correctly setup for integration with a
mainloop.

So things can't be called out-of-order.

They mentioned verification instead of capture.

So we don't need to open a device before checking whether it supports
imaging.

You can't call fp_discover_devs() without calling fp_init() and having
it not fail, otherwise there's nothing to discover...

struct xyt_struct uses a fixed-sized array to fit MAX_BOZORTH_MINUTIAE (200)
minutiae. MAX_FILE_MINUTIAE is 1000. So if we detected more than
MAX_BOZORTH_MINUTIAE, we would crash copying the data from the capture
to the structure.

We might want to use dynamically allocated arrays in the future (or
bigger ones) so that we don't lose minutiae.

Closes: #116

The checks weren't:
- checking whether the width or height were negative
- whether img->width * img->height would overflow, or
  was bigger than G_MAXINT
- whether img->width * img->height was bigger than the total
  length of the buffer

The last one looks like a thinko, it checked for:
(img->length * img->height) < img->length
which is equivalent to:
img->height < 1
which we already check for earlier.

Closes: #85

cimage is leaked when mimage fails to allocate.

Spotted by Seth Arnold

Closes: #82

pmap was not freed in error cases.

Spotted by Seth Arnold

Closes: #83

A copy/paste error meant we were trying to free a variable we only just
failed to allocate.

Spotted by Seth Arnold

Closes: #81

Add fp_minutia_get_coords() so that debugging applications can show the
detected minutiae along with the captured image.

This will also help fix the positively ancient fprint_demo.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907470

Closes: #109

So that we can be sure that the build doesn't break when those drivers
are not built.