1. 18 Aug, 2021 3 commits
    • Alyssa Rosenzweig's avatar
      panfrost: Dither fast clears · 4f782742
      Alyssa Rosenzweig authored
      
      
      We can do this at no additional cost, the DDK does it, and I already
      went to the effort of typing this all out and unit testing it under the
      mistaken belief it was mandatory... so we might as well take advantage
      of it after all.
      Signed-off-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <alyssa@collabora.com>
      4f782742
    • Alyssa Rosenzweig's avatar
      panfrost: Handle non-dithered clear colours · 2ac29047
      Alyssa Rosenzweig authored
      In b9c095cc ("panfrost: Rewrite the clear colour packing code"),
      packing of clear colours was corrected to use the tilebuffer's
      fractional bits, fixing dithering of the clear colour with formats like
      RGB565. Unfortunately, that commit did so unconditionally. If the
      framebuffer is dithered, but dithering is disabled at the time of
      the clear, we would incorrectly dither the clear.
      
      This is a regression, as the old (broken) code passed the relevant CTS
      test. What's the catch? Depending on dither state, there are two
      formulas to pack tilebuffer colours. We need to handle both. Fixes
      KHR-GLES31.core.draw_buffers_indexed.color_masks.
      
      Fixes: b9c095cc
      
       ("panfrost: Rewrite the clear colour packing code")
      Signed-off-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <alyssa@collabora.com>
      2ac29047
    • Alyssa Rosenzweig's avatar
      mesa/st: Validate blend state for pipe->clear() · 7fef42a3
      Alyssa Rosenzweig authored
      
      
      This allows the driver to respect dither state.  Drivers that are able
      to dither fast clears MAY respect this hint.  However, as dithering is
      completely implementation defined and implementations may ignore
      dithering altogether, this may be ignored.  Existing drivers should have
      no behaviour change.
      Signed-off-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <alyssa@collabora.com>
      7fef42a3
  2. 17 Aug, 2021 26 commits
  3. 16 Aug, 2021 11 commits